gerrit 147554 redirects old-style Flow_Board?workflow=<uuid> URLs to Topic:<uuid> URLs, fixing bug 68224. However, it leaves the unneeded workflow query string parameter and drops other query string parameters.
does a 302 redirect to
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Rylar2mda6g0d4fz&workflow=rylar2mda6g0d4fz
but the obsolete workflow parameter is still part of the URL. And if this was the only query string parameter, then the redirect URL can be the cleaner /wiki/Topic:Rylar2mda6g0d4f
Other query string parameters in the old URL are lost, so for example old actions don't work any more. A contrived example:
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow&workflow=rylar2mda6g0d4fz&action=edit-topic-summary
does the same 302 redirect to
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:Rylar2mda6g0d4fz&workflow=rylar2mda6g0d4fz
losing the action and any other parameters.
I think a 301 Moved Permanently redirect would be better.
Version: master
Severity: minor