Page MenuHomePhabricator
Create Task
Maniphest T61099

mw.notify() with type to get different ui with predefined styles
Closed, ResolvedPublic
Actions

Assigned To
Fomafix
Authored By
Fomafix
Dec 29 2013, 11:45 AM
Tags
Referenced Files
F482828: pasted_file
Aug 5 2015, 12:53 PM
F419035: pasted_file
Aug 4 2015, 11:23 PM
F418967: pasted_file
Aug 4 2015, 11:23 PM
F12574: notify-type.patch
Aug 4 2015, 11:23 PM
Subscribers
Aklapper
Fomafix
gerritbot
• Jonas
Krinkle
matmarex
• TrevorParscal

Description

mw.notify() with type for watch and patrol

mw.notify() is used for success and for fail notifications. But it has always the same style.

It would be nice to have a set of predefined ui styles for different types. The types should orient at the API results: For example:

  • type "notify": Green. Success. Default style.
  • type "warn": Yellow. Success but with warning.
  • type "error": Red. Fail.

I created a patch to demonstrate the idea. The styles use different background colors for the different types. It would be better to have self-explanatory icons.

Version: 1.23.0
Severity: enhancement

Attached:

notify-type.patch3 KBDownload

Details

Reference
bz59099
SubjectRepoBranchLines +/-
Fixes css rules warn, error not appliedmediawiki/coremaster+2 -2
mediawiki.notification: Add message type with predefined stylesmediawiki/coremaster+31 -7
Style for notification typesmediawiki/skins/Vectormaster+10 -0
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:35 AM
• bzimport added projects: MediaWiki-JavaScript, Design.
• bzimport set Reference to bz59099.
• bzimport added a subscriber: Unknown Object (MLST).
Fomafix created this task.Dec 29 2013, 11:45 AM
Aklapper added a comment.Jan 2 2014, 11:45 AM

Hi! Thanks for your patch!

You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again! We appreciate your contribution.

gerritbot added a comment.Jan 2 2014, 10:40 PM

Change 105104 had a related patch set uploaded by Gerrit Patch Uploader:
mw.notify() with message type and predefined styles

https://gerrit.wikimedia.org/r/105104

matmarex added a comment.Jan 3 2014, 12:16 AM

(Fomafix, there are some comments on the gerrit change – I'm posting here since I'm not sure if you're watching it. You should get a labs/gerrit account (aka "Developer access") to be able to get automated mail about new comments from gerrit and to reply there, even if you're using the patch uploader to submit patches :) )

matmarex edited projects, added MediaWiki-User-Interface, JavaScript; removed MediaWiki-JavaScript.Dec 31 2014, 12:28 AM
gerritbot subscribed.Aug 3 2015, 4:45 PM

Change 105104 had a related patch set uploaded (by Gerrit Patch Uploader):
mediawiki.notification: Add message type with predefined styles

https://gerrit.wikimedia.org/r/105104

gerritbot added a comment.Aug 4 2015, 4:12 PM

Change 229148 had a related patch set uploaded (by Gerrit Patch Uploader):
Style for notification types

https://gerrit.wikimedia.org/r/229148

gerritbot added a comment.Aug 4 2015, 10:55 PM

Change 229148 merged by jenkins-bot:
Style for notification types

https://gerrit.wikimedia.org/r/229148

Fomafix mentioned this in rSVECd6188be309f9: Style for notification types.Aug 4 2015, 10:56 PM
Diffusion mentioned this in rSKIN7f8f4064bd17: Updated mediawiki/skins Project: mediawiki/skins/Vector….Aug 4 2015, 10:56 PM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 4 2015, 11:00 PM
gerritbot added a comment.Aug 4 2015, 11:15 PM

Change 105104 merged by jenkins-bot:
mediawiki.notification: Add message type with predefined styles

https://gerrit.wikimedia.org/r/105104

matmarex mentioned this in rMW612b487786d4: mediawiki.notification: Add message type with predefined styles.Aug 4 2015, 11:16 PM
matmarex closed this task as Resolved.Aug 4 2015, 11:23 PM
matmarex assigned this task to Fomafix.
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
matmarex removed a subscriber: • wikibugs-l-list.

Vector:

pasted_file (242×267 px, 9 KB)

Other skins:

pasted_file (204×268 px, 5 KB)

• Forrestbot added a project: MW-1.26-release.Aug 5 2015, 12:00 AM
• Jonas subscribed.Aug 5 2015, 12:53 PM

Not working on Wikidata, please see my patch.

pasted_file (1×402 px, 70 KB)

gerritbot added a comment.Aug 5 2015, 12:53 PM

Change 229344 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fixes css rules warn, error not applied

https://gerrit.wikimedia.org/r/229344

gerritbot added a project: Patch-For-Review.Aug 5 2015, 12:53 PM
Fomafix added a comment.Aug 5 2015, 1:09 PM
In T61099#1510534, @Jonas wrote:

Not working on Wikidata, please see my patch.

https://gerrit.wikimedia.org/r/105104 and the Vector adaption https://gerrit.wikimedia.org/r/229148 are not yet deployed on Wikidata. You patch is not necessary, because https://gerrit.wikimedia.org/r/229148 does this already for skin Vector.

gerritbot added a comment.Aug 5 2015, 1:19 PM

Change 229344 abandoned by Jonas Kress (WMDE):
Fixes css rules warn, error not applied

https://gerrit.wikimedia.org/r/229344

Fomafix mentioned this in rSVEVd6188be309f9: Style for notification types.Mar 8 2016, 3:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits