Suggestion from legoktm - should be fairly easy.
Version: unspecified
Severity: enhancement
Suggestion from legoktm - should be fairly easy.
Version: unspecified
Severity: enhancement
(In reply to comment #0)
Suggestion from legoktm - should be fairly easy.
Please use comment 0, also known as the bug description, to describe the bug.
Sorry! The idea is, if someone clicks on the black area behind the image, the lightbox should close. There are already close methods that are fairly general, so the only work involved *should* be adding an event listener in the right spot, and clearing it properly.
Let me know if you need any help :)
Change 103902 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop
Change 108317 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop
Change 103902 abandoned by 01tonythomas:
Exit Lightbox when clicked on backdrop
Reason:
persistent rebase errors
Continued in
https://gerrit.wikimedia.org/r/#/c/108317/
Looks like the patch was lost after
https://gerrit.wikimedia.org/r/#/c/116921/
Reverting bug to open
Change 118667 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on Backdrop
For good reason.
We decided that this causes way too many accidental lightbox close events, and reverted.
WONTFIXing for now - we may revisit this later, but it won't be for the next few months.
Change 118667 abandoned by MarkTraceur:
Exit Lightbox when clicked on Backdrop
Reason:
We tried doing this once before, it was just confusing and overall interfered with other actions in the viewer.