Page MenuHomePhabricator

RevisionDelete: DatabaseBase::makeList: empty input for field log_id
Closed, ResolvedPublic

Description

2013-02-20 22:20:38 mw1086 enwiki: [5fcb83c4] /w/index.php?title=Special%3ARevisionDelete&target=Special%3ALog&type=logging Exception from line 1883 of /usr/local/apache/common-local/php-1.21wmf9/includes/db/Database.php: DatabaseBase::makeList: empty input for field log_id
#0 /usr/local/apache/common-local/php-1.21wmf9/includes/db/Database.php(1485): DatabaseBase->makeList(Array, 1)
#1 /usr/local/apache/common-local/php-1.21wmf9/includes/db/Database.php(1431): DatabaseBase->selectSQLText('logging', 'log_type', Array, 'SpecialRevision...', Array, Array)
#2 /usr/local/apache/common-local/php-1.21wmf9/includes/specials/SpecialRevisiondelete.php(156): DatabaseBase->select('logging', 'log_type', Array, 'SpecialRevision...', Array)
#3 /usr/local/apache/common-local/php-1.21wmf9/includes/SpecialPage.php(613): SpecialRevisionDelete->execute(NULL)
#4 /usr/local/apache/common-local/php-1.21wmf9/includes/SpecialPageFactory.php(499): SpecialPage->run(NULL)
#5 /usr/local/apache/common-local/php-1.21wmf9/includes/Wiki.php(291): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#6 /usr/local/apache/common-local/php-1.21wmf9/includes/Wiki.php(565): MediaWiki->performRequest()
#7 /usr/local/apache/common-local/php-1.21wmf9/includes/Wiki.php(458): MediaWiki->main()
#8 /usr/local/apache/common-local/php-1.21wmf9/index.php(59): MediaWiki->run()
#9 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#10 {main}


Version: 1.21.x
Severity: minor

Details

Reference
bz45211

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:13 AM
bzimport set Reference to bz45211.

$this->ids = array_unique( array_filter( $this->ids ) );

^ we don't check this contains any values before trying to use it for a query

(In reply to comment #2)

Gerrit change #54141

successfully merged