Page MenuHomePhabricator
Create Task
Maniphest T45283

InfoAction doesn't take namespace protection into account
Closed, ResolvedPublic
Actions

Description

The "Page information" page for any message in the MediaWiki: namespace says that the message can be edited and moved by all users. For example, "MediaWiki:Wikimedia-copyrightwarning" exists, so http://en.wikipedia.org/w/index.php?title=MediaWiki:Wikimedia-copyrightwarning&action=info says "Allow all users" for both rights. For a message that doesn't exist, such as MediaWiki:Is awesome, the info page says that all users may create the page.

Example from Wikidata:
For example, at https://www.wikidata.org/w/index.php?title=Property:P7006&action=info (a semi-protected property), the page information displays:

image.png (1×1 px, 192 KB)

This should clearly indicate that the page is semi-protected by $wgNamespaceProtection (as all properties on Wikidata are now semi-protected, see T254280). Apparently this is a generic issue with $wgNamespaceProtection, not something that is specific to Wikidata.

URL: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Protect-default/en
See Also:

Details

Reference
bz43283
SubjectRepoBranchLines +/-
Fix some confusion about protections in InfoActionmediawiki/coremaster+6 -5
Make InfoAction take namespace protection into accountmediawiki/coremaster+43 -2
Show correct protection detail on InfoActionmediawiki/coremaster+65 -26
Have action=info check protected namespacesmediawiki/coremaster+19 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
InvalidNoneT40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone]
Resolvedmatej_suchanekT45283 InfoAction doesn't take namespace protection into account
· · ·

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:57 AM
• bzimport added projects: MediaWiki-Page-protection, I18n.
• bzimport set Reference to bz43283.
mxn created this task.Dec 20 2012, 9:04 AM
Legoktm added a comment.Dec 21 2012, 11:54 AM

I have a patch mostly written for this, but I'd like bug 43316 to be resolved first so I can properly test it.

Legoktm added a comment.Dec 22 2012, 8:37 AM

Gerrit change #39845

Nemo_bis added a comment.Apr 16 2013, 4:52 PM

This is the same problem we had with bug 43272: "Allow all users" actually means "Don't disallow any [additional] user", and in fact the message used to read (default).
It's a tricky balancing of clarity and correctness.

Probably it's not a good idea to reuse [[MediaWiki:Protect-default]] in info action, which – to make it worse – is available to all users and not only sysops.

Aklapper added a comment.Jul 25 2013, 7:39 AM

(In reply to comment #2)

Gerrit change #39845

Patch still needs review...

gerritbot added a comment.Oct 20 2013, 10:45 AM

Change 39845 had a related patch set uploaded by Legoktm:
Have action=info check protected namespaces

https://gerrit.wikimedia.org/r/39845

Krenair mentioned this in T85707: Protection info in action=info for MediaWiki namspace says "Allow all users".Jan 2 2015, 6:07 PM
Krenair merged a task: T85707: Protection info in action=info for MediaWiki namspace says "Allow all users".
Krenair added subscribers: Aklapper, Lejonel.
jrbs subscribed.Oct 30 2015, 12:07 AM
gerritbot subscribed.Feb 8 2018, 3:01 PM

Change 39845 had a related patch set uploaded (by Matěj Suchánek; owner: Legoktm):
[mediawiki/core@master] Have action=info check protected namespaces

https://gerrit.wikimedia.org/r/39845

matej_suchanek updated the task description. (Show Details)Feb 8 2018, 3:03 PM
matej_suchanek added a project: Patch-Needs-Improvement.Feb 26 2018, 8:14 PM
matej_suchanek merged a task: T218973: ?action=info does not show correct information for namespace protection.May 26 2019, 10:39 AM
matej_suchanek added subscribers: DannyS712, Ammarpad.
gerritbot added a comment.Dec 2 2019, 5:09 PM

Change 554106 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Show correct protection detail on InfoAction

https://gerrit.wikimedia.org/r/554106

Ammarpad claimed this task.Dec 2 2019, 5:13 PM
Ammarpad removed projects: Patch-Needs-Improvement, I18n.Dec 2 2019, 6:49 PM
gerritbot added a comment.Jun 2 2020, 9:21 PM

Change 39845 abandoned by Legoktm:
Have action=info check protected namespaces

Reason:
RIP my first ever MediaWiki core patch

https://gerrit.wikimedia.org/r/39845

gerritbot added a comment.Jun 24 2020, 6:56 AM

Change 554106 abandoned by Ammarpad:
Show correct protection detail on InfoAction

https://gerrit.wikimedia.org/r/554106

Ammarpad closed this task as Declined.Jun 24 2020, 6:57 AM

Reflect reality,

Legoktm added a comment.Jun 24 2020, 7:00 AM
In T45283#6251056, @Ammarpad wrote:

Reflect reality,

What reality are you referring to? I think we still want this bug to be solved.

matej_suchanek reopened this task as Open.Jun 24 2020, 8:56 AM
matej_suchanek removed Ammarpad as the assignee of this task.
matej_suchanek lowered the priority of this task from Medium to Low.
matej_suchanek removed a project: Patch-For-Review.
matej_suchanek updated the task description. (Show Details)
gerritbot added a comment.Jul 4 2020, 2:10 PM

Change 609531 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] Make InfoAction take namespace protection into account

https://gerrit.wikimedia.org/r/609531

gerritbot added a project: Patch-For-Review.Jul 4 2020, 2:10 PM
matej_suchanek claimed this task.Jul 4 2020, 2:24 PM
matej_suchanek added a project: Platform Engineering.Aug 3 2020, 9:03 AM

https://gerrit.wikimedia.org/r/557879 and https://gerrit.wikimedia.org/r/609531 (this) touch the same code. The former also points out an edge case of page protection presentation. Tagging Platform Engineering for review to get this old bug fixed.

• AMooney edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Aug 4 2020, 8:26 PM
DannyS712 merged a task: T266395: $wgNamespaceProtection status is not displayed in the page information.Oct 25 2020, 6:26 AM
DannyS712 added subscribers: Mike_Peel, Lydia_Pintscher.
matej_suchanek merged a task: T266394: Protection interface displays 'Allow all users' despite $wgNamespaceProtection being applied.Oct 25 2020, 8:16 AM
Lydia_Pintscher added a project: Wikidata-Campsite.Nov 3 2020, 1:22 PM
Lydia_Pintscher updated the task description. (Show Details)
Restricted Application added a project: Wikidata. · View Herald TranscriptNov 3 2020, 1:22 PM
Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.Nov 3 2020, 1:22 PM
WMDE-leszek moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Nov 3 2020, 2:11 PM
WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
WMDE-leszek moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 5 2020, 10:20 AM
WMDE-leszek moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 20 2020, 10:25 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 20 2020, 11:15 AM
gerritbot added a comment.Jan 22 2021, 2:09 PM

Change 557879 had a related patch set uploaded (by Will Doran; owner: Daimona Eaytoy):
[mediawiki/core@master] Fix some confusion about protections in InfoAction

https://gerrit.wikimedia.org/r/557879

Addshore added subscribers: Lucas_Werkmeister_WMDE, WMDE-leszek, Addshore.Mar 3 2021, 12:14 PM

Is this blocked / waiting for some other team to review it or can we review it?
CC @WMDE-leszek @Lucas_Werkmeister_WMDE
Or should we remove this from campsite?

WMDE-leszek added a comment.Mar 3 2021, 12:25 PM

It was on some WMF's team (Platform Engineering I believe) to review. They were last ping in January I believe

Ammarpad unsubscribed.Mar 3 2021, 3:06 PM
Addshore added a project: Platform Engineering.Mar 19 2021, 11:33 AM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptMar 19 2021, 11:33 AM
Addshore moved this task from Inbox to External Realm on the [DEPRECATED] wdwb-tech board.Mar 19 2021, 11:33 AM
Addshore moved this task from External Realm to Blocked on the [DEPRECATED] wdwb-tech board.
BPirkle removed a project: Platform Engineering.Mar 23 2021, 8:38 PM
BPirkle added subscribers: • AMooney, BPirkle.

@AMooney to assign a reviewer

WMDE-leszek added a comment.May 10 2021, 8:14 AM

Hello @AMooney - any chance your team could take a look at the patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/609531/ (or this bug in general), and advise on the solution here? Thanks!

matej_suchanek added a comment.May 24 2021, 4:06 PM

Patch demo: https://patchdemo.wmflabs.org/wikis/b3bd5d2702/wiki/Main_Page
Example from the original task description: https://patchdemo.wmflabs.org/wikis/b3bd5d2702/w/index.php?title=MediaWiki:Is_awesome&action=info

gerritbot added a comment.May 24 2021, 4:26 PM

Change 557879 merged by jenkins-bot:

[mediawiki/core@master] Fix some confusion about protections in InfoAction

https://gerrit.wikimedia.org/r/557879

gerritbot added a comment.May 24 2021, 4:28 PM

Change 609531 merged by jenkins-bot:

[mediawiki/core@master] Make InfoAction take namespace protection into account

https://gerrit.wikimedia.org/r/609531

Jdforrester-WMF closed this task as Resolved.May 24 2021, 5:36 PM
Jdforrester-WMF subscribed.

I've made a minor code style follow-up, but this is done. Thank you!

Aklapper added a project: Voice & Tone.May 24 2021, 9:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits