Inputbox tag only generates background: CSS line, and not corresponding color: line..
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	ShakespeareFan00
	Jul 9 2024, 11:39 AM

Description

Steps to replicate the issue (include links if applicable):

https://en.wikisource.org/wiki/Special:LintErrors/night-mode-unaware-background-color?wpNamespaceRestrictions=10&titlecategorysearch=Engine&exactmatch=1&tag=all&template=all

What happens?:
A 'Background color inline style rule exists without a corresponding text color' lint is reported as arising inside the inputbox tag.

What should have happened instead?:
The inputbox pusedo-tag should be generating an appropriate 'color:' to pair with the background. (typicaly:'color:inherit') if a foreground color is not supplied as a parameter.

Looking at the code in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/InputBox/+/refs/heads/master/includes/InputBox.php (around line 822) this should be a relatively simple patch

QA Results - PROD

AC	Status	Details
1	✅	Pass per T369619#9993259

Details

	Subject	Repo	Branch	Lines +/-
	InputBox should not trigger lint warnings	mediawiki/extensions/InputBox	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: T370084: Verify 1.43.0-wmf.14 deployment

Event Timeline

ShakespeareFan00 created this task.Jul 9 2024, 11:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2024, 11:39 AM

ShakespeareFan00 added a project: dark-mode.Jul 9 2024, 11:51 AM

Thanks for the report. @Catrope if I post a patch could you review? Seems like this would cause lots of false positives in our LintErrors category...

Jdlrobson triaged this task as High priority.Jul 10 2024, 12:18 AM

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.

Sjoerddebruin subscribed.Jul 10 2024, 8:30 PM

Jdlrobson added a project: patch-welcome.Jul 11 2024, 7:57 PM

Jdlrobson awarded a token.

Yeah go ahead!

Change #1053799 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/InputBox@master] InputBox should not trigger lint warnings

https://gerrit.wikimedia.org/r/1053799

gerritbot added a project: Patch-For-Review.Jul 11 2024, 10:14 PM

Change #1053799 merged by jenkins-bot:

[mediawiki/extensions/InputBox@master] InputBox should not trigger lint warnings

https://gerrit.wikimedia.org/r/1053799

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2024, 11:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 12 2024, 12:00 AM

Izno moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jul 13 2024, 9:55 PM

ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 2); removed Web-Team-Backlog.Jul 15 2024, 1:23 PM

I can verify this in production once I get pinged by Edward as part of release QA.

GMikesell-WMF mentioned this in T370084: Verify 1.43.0-wmf.14 deployment.Jul 16 2024, 11:42 PM

@Jdlrobson Is this what you are looking for as seen in gif and screenshot?

Test Result - PROD

Status: ❓NMI
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

2024-07-17_12-00-54.mp4.gif (894×1 px, 1 MB)

2024-07-17_11-51-27.png (1×2 px, 795 KB)

GMikesell-WMF updated the task description. (Show Details)Jul 17 2024, 7:03 PM

@GMikesell-WMF I can verify this. The URL matches no results, so that's what we're verifying here.

GMikesell-WMF updated the task description. (Show Details)Jul 18 2024, 4:37 PM

Jdlrobson moved this task from Needs analysis to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 2) board.Jul 30 2024, 7:48 PM

Jdlrobson added a project: FY2023-24-WE 2.1 Typography and palette customizations.

Inputbox tag only generates background: CSS line, and not corresponding color: line.. Closed, ResolvedPublicBUG REPORTActions