Maniphest T364675

Special:Nearby forces pages to open in desktop view
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Open Special:Nearby in the mobile view (eg. https://en.m.wikipedia.org/wiki/Special:Nearby)
Click on one of the results

What happens?:

The page gets opened in the desktop view

What should have happened instead?:

It should have respected the current view setting and open the page in the mobile view

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Nearby: Stay on mobile domain when navigating to nearby page	mediawiki/extensions/NearbyPages	master	+31 -3

Customize query in gerrit

Related Objects

Mentioned In: T371110: Verify 1.43.0-wmf.16 deployment
Mentioned Here: T60425: Mobile site does not automatically redirect to desktop version (and not possible to use browser "use desktop view")

Event Timeline

Sjoerddebruin created this task.May 11 2024, 2:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2024, 2:19 PM

It needs to support generation of relative URIs rather than absolute to avoid hitting T60425: Mobile site does not automatically redirect to desktop version (and not possible to use browser "use desktop view")

Jdlrobson moved this task from Incoming to Holding area (temporary) on the Web-Team-Backlog board.May 23 2024, 11:46 PM

Jdlrobson removed a project: Web-Team-Backlog.Jul 17 2024, 6:17 PM

Change #1054928 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/NearbyPages@master] Nearby: Stay on mobile domain when navigating to nearby page

https://gerrit.wikimedia.org/r/1054928

gerritbot added a project: Patch-For-Review.Jul 17 2024, 7:09 PM

So this happens because https://www.mediawiki.org/wiki/API:Info returns urls that do not take into account the mobile domain.
I also think there is no way for it to do that at the moment.

Instead, a simple url rewrite when the current domain doesn't match the main domain of the server, seems the easiest solution.

Change #1054928 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] Nearby: Stay on mobile domain when navigating to nearby page

https://gerrit.wikimedia.org/r/1054928

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 9:31 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 24 2024, 10:00 PM

Jdlrobson closed this task as Resolved.Jul 25 2024, 11:24 PM

Jdlrobson claimed this task.

Jdlrobson added projects: Web-Team-Backlog (FY2024-25 Q1 Sprint 2), Unplanned-Sprint-Work.

Edtadros mentioned this in T371110: Verify 1.43.0-wmf.16 deployment.Jul 30 2024, 8:38 PM

Special:Nearby forces pages to open in desktop viewClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Special:Nearby forces pages to open in desktop view
Closed, ResolvedPublicBUG REPORT
Actions