Empty commit for Newsletter extension failed CI: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/977270
Relevant error is:
21:54:36 There was 1 failure: 21:54:36 21:54:36 1) NewsletterAPIEditTest::testAddPublisher 21:54:36 Failed asserting that two arrays are equal. 21:54:36 --- Expected 21:54:36 +++ Actual 21:54:36 @@ @@ 21:54:36 Array ( 21:54:36 - 0 => 2 21:54:36 - 1 => 1 21:54:36 + 0 => 1 21:54:36 + 1 => 2 21:54:36 )
I tested and can't reproduce the failure locally
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| tests: Require user id for UTSysop earlier | mediawiki/extensions/Newsletter | master | +3 -0 |
The test is using the user UTSysop, which seems to have now another user id as the order of user creation has changed in general in unit tests.
Should use MediaWikiIntegrationTestCase::getTestSysop to get the name and the id of the test sysop.
Change 977270 had a related patch set uploaded (by Umherirrender; author: Pppery):
[mediawiki/extensions/Newsletter@master] tests: Require user id for UTSysop earlier
Change 977270 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] tests: Require user id for UTSysop earlier