Page MenuHomePhabricator

TypeError: Cannot read properties of undefined (reading 'getAttribute')
Closed, ResolvedPublicBUG REPORT

Description

165 errors in latest deploy branch. Occurs in mobile and desktop site.
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.11.17?id=PMQE3osBk70gu8Gmwpik

Stack trace:

at https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:96:289
at ve.dm.InternalList.sortGroupIndexes  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:96:232
at ve.dm.InternalList.onTransact  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:95:546
at OO.EventEmitter.emit  https://en.m.wikipedia.org/w/load.php?lang=en&modules=oojs&skin=minerva&version=rwdvu:8:344
at ve.dm.Document.commit  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:246:912
at ve.dm.Surface.changeInternal  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:202:547
at ve.dm.Surface.change  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:202:64
at https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core%2Cmwtransclusion&skin=minerva&version=1romu:157:463

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 975332 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] ve.dm.InternalList#sortGroupIndexes: Fix merge conflict

https://gerrit.wikimedia.org/r/975332

Related to T350902. I think the two patches for that wound up merging and not producing the expected order.

Change 975335 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] Fix order of checks in InternalList.sortGroupIndexes

https://gerrit.wikimedia.org/r/975335

Change 975335 abandoned by DLynch:

[VisualEditor/VisualEditor@master] Fix order of checks in InternalList.sortGroupIndexes

Reason:

I438b6fe811b8dbe8d888298e817bf7630fef100e

https://gerrit.wikimedia.org/r/975335

Change 975332 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ve.dm.InternalList#sortGroupIndexes: Fix merge conflict

https://gerrit.wikimedia.org/r/975332

Change 976227 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1947f053c)

https://gerrit.wikimedia.org/r/976227

Change 976227 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1947f053c)

https://gerrit.wikimedia.org/r/976227