Page MenuHomePhabricator

Cannot enter a list as an argument for a test
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
It asks for a type

Since the input is a Typed List of String, this should just let us enter strings.

But ignoring that, I try to enter String in Select a type, and when I select it, it gives me a field for value, but leave an empty field in type.

empty-element-type.png (687×651 px, 36 KB)

If I then add a value and select a result validation function "string equality" and then enter a value there, and try to save it, I get a "Not wellformed" error on publishing

What should have happened instead?:

  • ideally, it should not let me select the type but use the fixed type of string for the elements
  • it should let me choose a type for the element

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This also applies when creating an implementation, or using it when running a function, e.g. here: https://wikifunctions.beta.wmflabs.org/view/en/Z11416

Event Timeline

Change 974518 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix transformation from normal to canonical typed lists on argument creation

https://gerrit.wikimedia.org/r/974518

Jdforrester-WMF changed the task status from Open to In Progress.Nov 16 2023, 1:38 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To triage to To deploy on the Abstract Wikipedia team board.

Change 974518 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix transformation from normal to canonical typed lists on argument creation

https://gerrit.wikimedia.org/r/974518