Page MenuHomePhabricator
Create Task
Maniphest T346944

Edit icons appear as text in Minerva desktop
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
matmarex
Authored By
Jdlrobson
Sep 20 2023, 4:35 PM
Tags
Referenced Files
F41461784: Screenshot 2023-11-06 at 3.36.31 PM.png
Nov 6 2023, 11:46 PM
F37676898: Screenshot 2023-09-08 at 4.52.25 PM.png
Sep 20 2023, 4:35 PM
F37676908: Screenshot 2023-09-08 at 4.56.04 PM.png
Sep 20 2023, 4:35 PM
F37676895: Screenshot 2023-09-08 at 4.50.36 PM.png
Sep 20 2023, 4:35 PM
Subscribers
Aklapper
cscott
Jdlrobson
Masumrezarock100
matmarex
ovasileva
ppelberg
View All 9 Subscribers

Description

NOTE: although this impacts Minerva desktop it should probably be addressed to avoid future regressions in this area.

Steps to replicate the issue (include links if applicable):

What happens?:

[2]

Screenshot 2023-09-08 at 4.50.36 PM.png (586×1 px, 121 KB)

  • The edit icons are using mw-ui-icon
  • The edit icons do not look like edit icons
  • The icon is using a b tag
  • In the case of page-actions-edit no edit icon is shown
  • the font size is either too big or too small
  • there appears to be a stray icon floating near the top of the page:

Screenshot 2023-09-08 at 4.56.04 PM.png (122×336 px, 15 KB)

The edit icon at the top of the page also appears unstyled

Screenshot 2023-09-08 at 4.52.25 PM.png (316×2 px, 55 KB)

What should have happened instead?:

  • A span tag should be used for the icon
  • The icons should appear.
  • The labels should disappear when the screen is resized.
  • The font size should be the same for all icons

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA steps

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 20 2023, 4:35 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 20 2023, 4:35 PM
Jdlrobson mentioned this in T345969: [Follow up][regression] Edit icons not rendering correctly in Minerva and mediawiki.ui.icon is still loaded.Sep 20 2023, 4:35 PM
gerritbot added a comment.Sep 20 2023, 4:35 PM

Change 956514 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/extensions/VisualEditor@master] Update handling of minerva icons

https://gerrit.wikimedia.org/r/956514

gerritbot added a project: Patch-For-Review.Sep 20 2023, 4:35 PM
Jdlrobson assigned this task to ppelberg.Sep 20 2023, 4:36 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited projects, added VisualEditor, MinervaNeue; removed MobileFrontend.
ovasileva triaged this task as Medium priority.Sep 20 2023, 10:13 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)); removed Web-Team-Backlog.
ovasileva subscribed.
ppelberg attached a referenced file: F37676898: Screenshot 2023-09-08 at 4.52.25 PM.png. (Show Details)Sep 20 2023, 11:07 PM
ppelberg attached a referenced file: F37676908: Screenshot 2023-09-08 at 4.56.04 PM.png. (Show Details)
ppelberg removed ppelberg as the assignee of this task.Sep 20 2023, 11:09 PM
ppelberg attached a referenced file: F37676895: Screenshot 2023-09-08 at 4.50.36 PM.png. (Show Details)
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.
ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
ppelberg subscribed.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Sep 21 2023, 3:24 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)).Sep 25 2023, 5:38 PM
Jdlrobson moved this task from Incoming to Tracking on the Web-Team-Backlog board.
matmarex subscribed.Sep 25 2023, 8:22 PM

Minerva could support using the SkinTemplateNavigation::Universal hook to modify the menu at the top of the page. It already supports using it to modify some other menus (e.g. the user personal menu). And VisualEditor already uses that hook, so this would probably allow removing some of the special cases for Minerva which are causing this problem.

Jdlrobson added a comment.Sep 25 2023, 8:55 PM

@matmarex yes. Making Minerva support the Universal hook for the p-views menu would make a lot of sense.

gerritbot added a comment.Sep 27 2023, 12:25 AM

Change 961261 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Support extension of page actions via hook anad addPortletLink

https://gerrit.wikimedia.org/r/961261

gerritbot added a comment.Sep 28 2023, 7:21 PM

Change 961880 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Change icon when both VE and source edit icons are present

https://gerrit.wikimedia.org/r/961880

gerritbot added a comment.Sep 28 2023, 8:54 PM

Change 961898 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Editor supports multiple edit buttons

https://gerrit.wikimedia.org/r/961898

gerritbot added a comment.Sep 29 2023, 4:31 PM

Change 962062 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Limit icons in views to watchstar

https://gerrit.wikimedia.org/r/962062

gerritbot added a comment.Oct 2 2023, 11:52 PM

Change 962062 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Limit icons in views to watchstar

Reason:

I've gone with a slightly different approach which allows skins to opt into icons: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/961880 - curious on your thoughts!

https://gerrit.wikimedia.org/r/962062

gerritbot added a comment.Oct 4 2023, 11:01 PM

Change 961898 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Editor supports multiple edit buttons

https://gerrit.wikimedia.org/r/961898

gerritbot added a comment.Oct 4 2023, 11:20 PM

Change 961880 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Change icon for supported skins when both VE and source edit icons are present

https://gerrit.wikimedia.org/r/961880

gerritbot added a comment.Oct 5 2023, 12:23 AM

Change 961261 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Support extension of page actions via hook and addPortletLink

https://gerrit.wikimedia.org/r/961261

matmarex merged a task: T294192: Double edit tab is inconsistently displayed in desktop Minerva.Oct 5 2023, 12:24 AM
matmarex added a subscriber: XanonymusX.

The changes so far by @Jdlrobson should fix the missing icons for the edit links at the top of the page, i.e., this:

Screenshot 2023-09-08 at 4.52.25 PM.png (316×2 px, 55 KB)

I had a look and I think we can make changes following the same pattern to also fix the section edit links, i.e., this:

Screenshot 2023-09-08 at 4.50.36 PM.png (586×1 px, 121 KB)

gerritbot added a comment.Oct 5 2023, 12:26 AM

Change 963420 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Support SkinEditSectionLinks hook as used by VisualEditor

https://gerrit.wikimedia.org/r/963420

gerritbot added a comment.Oct 5 2023, 12:26 AM

Change 963421 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Change icon for supported skins for section edit links, too

https://gerrit.wikimedia.org/r/963421

gerritbot added a comment.Oct 5 2023, 12:32 AM

Change 963422 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Editor supports multiple section edit links, too

https://gerrit.wikimedia.org/r/963422

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 5 2023, 1:00 AM
gerritbot added a comment.Oct 5 2023, 1:05 AM

Change 963423 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/963423

gerritbot added a comment.Oct 5 2023, 1:44 PM

Change 963423 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/963423

DLynch assigned this task to matmarex.Oct 5 2023, 2:43 PM
Jdlrobson mentioned this in T348267: Minerva HTML markup change: #page-actions is now #p-views.Oct 5 2023, 4:29 PM
Jdlrobson mentioned this in T348336: [Regression] Watchstar is no longer showing for anonymous users.Oct 6 2023, 6:05 PM
Jdlrobson mentioned this in T348353: Should $wgVisualEditorUseSingleEditTab apply to mobile skin?.Oct 6 2023, 8:29 PM
gerritbot added a comment.Oct 6 2023, 9:36 PM

Change 964092 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Remove doEditSectionLink() override, style section edit links with CSS

https://gerrit.wikimedia.org/r/964092

cscott subscribed.Oct 10 2023, 4:00 PM

Just linking this with T269630: Parsoid should support section editing links so we can eventually ensure any Parsoid markup/styling is compatible with this fix.

gerritbot added a comment.Oct 12 2023, 10:57 PM

Change 965604 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skin: Separate generation of edit section data from HTML

https://gerrit.wikimedia.org/r/965604

gerritbot added a comment.Oct 13 2023, 3:29 PM

Change 963421 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Change icon for supported skins for section edit links, too

https://gerrit.wikimedia.org/r/963421

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 13 2023, 4:00 PM
gerritbot added a comment.Oct 17 2023, 12:08 AM

Change 966313 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Minerva uses new Section Links generation

https://gerrit.wikimedia.org/r/966313

gerritbot added a comment.Oct 20 2023, 8:00 PM

Change 967525 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Generate section edit links via SkinMustache

https://gerrit.wikimedia.org/r/967525

gerritbot added a comment.Oct 24 2023, 12:59 AM

Change 965604 merged by jenkins-bot:

[mediawiki/core@master] Skin: Separate generation of edit section data from HTML

https://gerrit.wikimedia.org/r/965604

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.2; 2023-10-24); removed MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 24 2023, 1:00 AM
gerritbot added a comment.Oct 24 2023, 1:09 AM

Change 963422 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/MobileFrontend@master] Editor supports multiple section edit links, too

Reason:

No longer needed, see T348353

https://gerrit.wikimedia.org/r/963422

gerritbot added a comment.Oct 24 2023, 1:12 AM

Change 967525 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Generate section edit links via SkinMustache

https://gerrit.wikimedia.org/r/967525

gerritbot added a comment.Oct 24 2023, 1:15 AM

Change 964092 abandoned by Bartosz Dziewoński:

[mediawiki/skins/MinervaNeue@master] Remove doEditSectionLink() override, style section edit links with CSS

Reason:

Superseded by https://gerrit.wikimedia.org/r/967525

https://gerrit.wikimedia.org/r/964092

gerritbot added a comment.Oct 24 2023, 1:15 AM

Change 966313 abandoned by Bartosz Dziewoński:

[mediawiki/skins/MinervaNeue@master] WIP: Minerva uses new Section Links generation

Reason:

Superseded by https://gerrit.wikimedia.org/r/967525

https://gerrit.wikimedia.org/r/966313

gerritbot added a comment.Oct 24 2023, 1:15 AM

Change 963420 abandoned by Bartosz Dziewoński:

[mediawiki/skins/MinervaNeue@master] Support SkinEditSectionLinks hook as used by VisualEditor

Reason:

Superseded by https://gerrit.wikimedia.org/r/967525

https://gerrit.wikimedia.org/r/963420

matmarex edited projects, added Editing QA; removed Patch-For-Review.Oct 24 2023, 1:17 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

I think that's everything! The last unmerged change (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/956514) is just code cleanup at this point.

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.3; 2023-10-31); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 24 2023, 2:00 AM
Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Nov 6 2023, 11:46 PM
Ryasmeen removed a project: Editing QA.
Ryasmeen subscribed.

There is still a stray icon floating near the top of the page.

Screenshot 2023-11-06 at 3.36.31 PM.png (692×1 px, 148 KB)

matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Nov 7 2023, 1:07 AM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 16 2023, 5:40 PM
gerritbot added a comment.Nov 16 2023, 6:37 PM

Change 956514 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove handling of Minerva edit links

https://gerrit.wikimedia.org/r/956514

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Nov 16 2023, 7:00 PM
Jdlrobson mentioned this in T351853: Regression [production]: Edit icons are not hidden in section headings.Nov 22 2023, 10:40 PM
matmarex added a project: Editing QA.Nov 27 2023, 7:40 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Nov 27 2023, 9:49 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 28 2023, 4:36 PM
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:38 PM
gerritbot added a comment.Feb 2 2024, 6:04 PM

Change 995231 had a related patch set uploaded (by Sophivorus; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@REL1_39] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/995231

gerritbot added a project: Patch-For-Review.Feb 2 2024, 6:04 PM
gerritbot added a comment.Feb 5 2024, 6:32 PM

Change 995231 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_39] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/995231

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits