Following on from our migration to Codex markup, .mw-ui-icon is still being used by MobileFrontend. This causes confusion as it looks like we are using the deprecated mediawiki UI when that is not the case. The .mf-icon prefix should be used instead.
TODO
- The canonical prefix mf-icon should be consistently used insitead of mw-ui-icon- e.g. mf-mw-ui-icon-rotate-flip becomes mf-icon-rotate-flip
- Update Icon:: getGlyphClassName to use mf-icon- prefix.
- Consider cached HTML where applicable
- Do not use mw-ui-icon-flush-top, instead use the Codex mixin (see T322436)
- Consider any references in Minerva e.g. selenium tests, page issues code
- Upon completion https://codesearch.wmcloud.org/search/?q=mw-ui-icon-&files=&excludeFiles=&repos=Extension%3AMobileFrontend should yield no results./
QA
Exploratory testing: Check all mobile editing workflows.
Look for icons missing buttons e.g.
Key workflows to test:
- go to article, anon and logged in. Open all menus.
- Collapse/expand a section and check icon flips.
- click edit button and make an edit, checking icons on different overlays
- click an image
- click a reference to open the reference drawer
- Click on history and diff page of article
- Language overlay
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ❌ | T346184#9377542 per T346184#9380260 this error is unrelated to patch |
| 2 | ✅ | T346184#9377542 |
| 3 | ✅ | T346184#9377542 |
| 4 | ❌ | T346184#9377542 per T346184#9380260 this error is unrelated to patch |
| 5 | ✅ | T346184#9377542 |
| 6 | ✅ | T346184#9377542 |
| 7 | ✅ | T346184#9377542 |
| 8 | ✅ | T346184#9377542 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T346184#9381917 |
| 2 | ✅ | T346184#9381917 |
| 3 | ✅ | T346184#9381917 |
| 4 | ✅ | T346184#9381917 |
| 5 | ✅ | T346184#9381917 |
| 6 | ✅ | T346184#9381917 |
| 7 | ✅ | T346184#9381917 |
| 8 | ✅ | T346184#9381917 |
