Page MenuHomePhabricator

LoginNotify fully broken since January 2023
Closed, ResolvedPublicBUG REPORT

Description

I installed LoginNotify locally to investigate T329774. I tried to trigger it, but there was no notification. An event was inserted, but not a notification.

So I logged into production and did

SELECT MAX(notification_timestamp) FROM echo_event,echo_notification WHERE notification_event=event_id AND event_type='login-fail-known';

And found that the most recent LoginNotify notification was sent on 2023-01-05. This date corresponds to bc6e531aa2d410f42c65fe01d4b9767ce40b8c96 in which the locator was changed from locateEventAgent to locateArticleCreator.

LoginNotify events do not have an associated title, so locateArticleCreator() returns an empty array. They use (misuse?) the agent as the recipient.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from LoginNotify fully broken since January to LoginNotify fully broken since January 2023.Aug 23 2023, 6:05 AM

Change 952025 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/LoginNotify@master] Fix incorrect locator

https://gerrit.wikimedia.org/r/952025

Change 952027 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/LoginNotify@master] Add integration tests

https://gerrit.wikimedia.org/r/952027

Change 952025 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] Fix incorrect locator

https://gerrit.wikimedia.org/r/952025

Change 951865 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/extensions/LoginNotify@REL1_40] Fix incorrect locator

https://gerrit.wikimedia.org/r/951865

Change 951865 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@REL1_40] Fix incorrect locator

https://gerrit.wikimedia.org/r/951865

Change 952027 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] Add integration tests

https://gerrit.wikimedia.org/r/952027

Some users will notice when this goes out with the train, so we should probably put out an explanation.

For Tech News, how should we summarize the issue? My best guess is something like this - please confirm it is correct, or adapt it to be accurate:

  • Problems
    • The LoginNotify extension was not working correctly since January. It has now been fixed, and may send delayed notifications of past login attempts to some users whilst it processes the backlog.

The fix is actually already out. Despite the release notes tag, it went out with wmf.24.

  • The LoginNotify extension was not working correctly since January. It has now been fixed, and may send delayed notifications of past login attempts to some users whilst it processes the backlog.

There's no backlog. There are no plans to reconstruct lost notifications.

Suggested language:

  • The LoginNotify extension was not sending notifications since January. It has now been fixed, so going forward, you may see notifications for failed login attempts, and successful login attempts from a new device.