Page MenuHomePhabricator
Create Task
Maniphest T342280

CX: Migrate codebase from ES5 to ES6
Closed, ResolvedPublic
Actions

Description

Currently the CX codebase (i.e. all the code that lives inside ContentTranslation/modules directory) is written in ES5 and also the eslint rules applied are for ES5. However, since we are now able to use ES6 everywhere in ContentTranslation extension (https://phabricator.wikimedia.org/T333354), we should eventually migrate this codebase to ES6.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

ngkountas created this task.Jul 19 2023, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2023, 5:20 PM
ngkountas triaged this task as Medium priority.Jul 19 2023, 5:21 PM
ngkountas added a project: ContentTranslation.
gerritbot added a comment.Jul 20 2023, 6:53 AM

Change 940042 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Update eslint configuration to use es6 rules

https://gerrit.wikimedia.org/r/940042

gerritbot added a project: Patch-For-Review.Jul 20 2023, 6:53 AM
gerritbot added a comment.Jul 20 2023, 7:44 AM

Change 940088 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX ext.cx.dashboard.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940088

gerritbot added a comment.Jul 20 2023, 11:21 AM

Change 940042 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update eslint configuration to use es6 rules

https://gerrit.wikimedia.org/r/940042

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 20 2023, 1:00 PM
gerritbot added a comment.Jul 24 2023, 7:58 AM

Change 940088 merged by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX ext.cx.dashboard.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940088

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 8:10 AM
gerritbot added a comment.Jul 24 2023, 4:09 PM

Change 940962 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX mw.cx.TranslationTracker.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940962

gerritbot added a project: Patch-For-Review.Jul 24 2023, 4:09 PM

Change 940963 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX mw.cx.TranslationController.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940963

gerritbot added a comment.Jul 24 2023, 4:09 PM

Change 940964 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX ve.dm.CXSectionNode.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940964

gerritbot added a comment.Jul 25 2023, 9:52 AM

Change 940962 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX mw.cx.TranslationTracker.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940962

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 25 2023, 11:01 AM
gerritbot added a comment.Jul 25 2023, 2:53 PM

Change 940963 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX mw.cx.TranslationController.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940963

gerritbot added a comment.Jul 25 2023, 2:53 PM

Change 940964 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX ve.dm.CXSectionNode.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/940964

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 3:12 PM
gerritbot added a comment.Jul 26 2023, 12:32 PM

Change 941905 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] CX: CxUlsEntryPoint.vue: Migrate from ES5 to ES5

https://gerrit.wikimedia.org/r/941905

gerritbot added a project: Patch-For-Review.Jul 26 2023, 12:32 PM
gerritbot added a comment.Aug 1 2023, 3:23 PM

Change 944245 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Refactor mw.cx.SiteMapper.js

https://gerrit.wikimedia.org/r/944245

gerritbot added a comment.Aug 2 2023, 6:10 AM

Change 941857 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] CX: relevantlanguages.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/941857

gerritbot added a comment.Aug 2 2023, 7:15 AM

Change 941857 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: relevantlanguages.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/941857

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 2 2023, 8:00 AM
gerritbot added a comment.Aug 2 2023, 3:32 PM

Change 941905 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: CxUlsEntryPoint.vue: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/941905

Nikerabbit moved this task from Needs Triage to Epic and Trackers on the ContentTranslation board.Aug 14 2023, 11:47 AM
gerritbot added a comment.Aug 22 2023, 8:12 PM

Change 951578 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] CX: mw.cx.TargetArticle.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/951578

gerritbot added a comment.Aug 24 2023, 3:14 PM

Change 944245 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Refactor mw.cx.SiteMapper.js

https://gerrit.wikimedia.org/r/944245

gerritbot added a comment.Aug 28 2023, 8:40 AM

Change 951578 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: mw.cx.TargetArticle.js: Migrate from ES5 to ES6

https://gerrit.wikimedia.org/r/951578

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2023, 9:11 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 30 2023, 2:01 AM
gerritbot added a comment.Sep 7 2023, 6:25 PM

Change 955828 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Migrate mw.cx.init.Translation.js from ES5 to ES6

https://gerrit.wikimedia.org/r/955828

gerritbot added a project: Patch-For-Review.Sep 7 2023, 6:25 PM

Change 955829 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Migrate mw.cx.dm.Translation.js from ES5 to ES6

https://gerrit.wikimedia.org/r/955829

gerritbot added a comment.Sep 12 2023, 8:35 AM

Change 955828 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Migrate mw.cx.init.Translation.js from ES5 to ES6

https://gerrit.wikimedia.org/r/955828

gerritbot added a comment.Sep 12 2023, 8:40 AM

Change 955829 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Migrate mw.cx.dm.Translation.js from ES5 to ES6

https://gerrit.wikimedia.org/r/955829

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 12 2023, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 12 2023, 9:10 AM
Pginer-WMF edited projects, added Language-Team (Language-2023-October-December); removed Language-Team (Language-2023-July-September).Oct 2 2023, 9:02 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: Translation on the Language-Team (Language-2023-October-December) board.
gerritbot added a comment.Nov 1 2023, 2:11 PM

Change 970789 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Refactor mw.cx.SuggestionList.js to ES6

https://gerrit.wikimedia.org/r/970789

gerritbot added a project: Patch-For-Review.Nov 1 2023, 2:11 PM
ngkountas changed the task status from Open to In Progress.Nov 1 2023, 2:11 PM
ngkountas moved this task from Priority: Translation to In Progress on the Language-Team (Language-2023-October-December) board.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2023-October-December) board.
gerritbot added a comment.Nov 7 2023, 12:39 PM

Change 970789 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Refactor mw.cx.SuggestionList.js to ES6

https://gerrit.wikimedia.org/r/970789

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 7 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 1:10 PM
ngkountas moved this task from In Review to Quarter Backlog on the Language-Team (Language-2023-October-December) board.Nov 8 2023, 1:07 PM
gerritbot added a comment.Nov 16 2023, 5:23 PM

Change 975052 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Refactor ve.init.mw.CXTarget.js to ES6

https://gerrit.wikimedia.org/r/975052

gerritbot added a project: Patch-For-Review.Nov 16 2023, 5:23 PM
gerritbot added a comment.Nov 20 2023, 5:03 AM

Change 975052 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Refactor ve.init.mw.CXTarget.js to ES6

https://gerrit.wikimedia.org/r/975052

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 5:10 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 20 2023, 7:00 AM
gerritbot added a comment.May 20 2024, 7:31 PM

Change #1030992 had a related patch set uploaded (by Nik Gkountas; author: Esanders):

[mediawiki/extensions/ContentTranslation@master] ES6: Enforce no-var eslint rule

https://gerrit.wikimedia.org/r/1030992

gerritbot added a project: Patch-For-Review.May 20 2024, 7:31 PM
ngkountas edited projects, added Language-Team (Language-2024-April-June); removed Language-Team (Language-2023-October-December).May 20 2024, 7:31 PM
Pginer-WMF edited projects, added LPL Essential; removed Language-Team (Language-2024-April-June).Jul 3 2024, 9:23 AM
ngkountas added a subscriber: Pginer-WMF.Jul 5 2024, 10:14 AM

@Pginer-WMF Following the latest work, this task can be closed as done!

The eslint configuration has also been updated to force es6 syntax (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/940042) and usage of var keyword will currently lead to errors (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1030992).

Pginer-WMF closed this task as Resolved.Jul 8 2024, 9:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits