Page MenuHomePhabricator

[unplanned] Zebra: Align TOC title border with text
Closed, ResolvedPublicBUG REPORT

Description

Per T327718#8907802, the bottom border on the TOC title doesn't align vertically with the start of the TOC text.

image.png (401×705 px, 32 KB)

A/C

  • Align the TOC title border with the start of the TOC text.

QA Results - Beta

ACStatusDetails
1T340481#9377552

QA Results - Prod

ACStatusDetails
1T340481#9381857

Event Timeline

Jdlrobson renamed this task from Align TOC title border with text to Zebra: Align TOC title border with text.Jun 29 2023, 5:12 PM
LGoto triaged this task as Low priority.Jun 29 2023, 5:12 PM
LGoto moved this task from Incoming to Groomed on the Web-Team-Backlog board.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the lack of a codebase project tag I'm removing the good first task tag. Please add details what exactly has to happen where and how for a new contributor, and then add back the good first task project tag. Thanks a lot in advance!

Change 972403 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Align pinnable header bottom border with content

https://gerrit.wikimedia.org/r/972403

Change 972403 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Align pinnable header bottom border with content

https://gerrit.wikimedia.org/r/972403

Jdlrobson subscribed.

@Jdrewniak is this a blocker for this week's deploy ? I'm assuming not since priority is low so have put it in for next sprint.

Change 976282 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix the toc header underline

https://gerrit.wikimedia.org/r/976282

Change 972403 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] [Zebra] Align pinnable header bottom border with content

Reason:

Abandoned in favour of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/976282

https://gerrit.wikimedia.org/r/972403

Jdlrobson renamed this task from Zebra: Align TOC title border with text to [unplanned] Zebra: Align TOC title border with text.Nov 22 2023, 6:25 PM

This wasn't on the current sprint board because my original solution was somewhat complicated, but @bwang's patch was a much simpler 1-line CSS solution, so merging it seemed trivial.

Change 976282 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix the toc header underline

https://gerrit.wikimedia.org/r/976282

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Align the TOC title border with the start of the TOC text.

screenshot 320.png (549×557 px, 100 KB)

ovasileva claimed this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Align the TOC title border with the start of the TOC text.

screenshot 363.png (661×663 px, 139 KB)

screenshot 364.png (755×627 px, 175 KB)

screenshot 362.png (869×851 px, 196 KB)

screenshot 361.png (777×696 px, 177 KB)