Page MenuHomePhabricator
Create Task
Maniphest T339295

[M] Move away from using ChromeLikeTabSwitcher library
Closed, ResolvedPublicSpike
Actions

Description

This third-party library (which we use for rendering our Tabs screen) seems to be abandoned. (the last update was 3+ years ago)

We should seek out a new library for displaying tabs, or see if we should roll our own, or see if the platform provides a component that does this.

Related Objects

Event Timeline

Dbrant created this task.Jun 15 2023, 8:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2023, 8:39 PM
LGoto triaged this task as Low priority.Jun 27 2023, 4:20 PM
LGoto mentioned this in T339233: Tabs list doesn't have enough visual differentiation in Black mode..
LGoto moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.
LGoto added a project: Spike.
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptJun 27 2023, 4:22 PM
Dbrant moved this task from Tech Debt Backlog to Needs Triage on the Wikipedia-Android-App-Backlog board.Sep 9 2024, 6:44 PM
Seddon moved this task from Needs Triage to Android Release - FY2024-25 on the Wikipedia-Android-App-Backlog board.Sep 10 2024, 4:22 PM
Seddon edited projects, added Wikipedia-Android-App-Backlog (Android Release - FY2024-25); removed Wikipedia-Android-App-Backlog.
Seddon moved this task from Epics in Progress to Needs Engineering Sync on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.
Seddon renamed this task from Move away from using ChromeLikeTabSwitcher library to [M] Move away from using ChromeLikeTabSwitcher library.Sep 12 2024, 5:27 PM
Seddon moved this task from Needs Engineering Sync to Ready for dev on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.
Seddon moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.
Dbrant claimed this task.Sep 13 2024, 1:00 PM
Dbrant moved this task from Doing to Design signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Sep 13 2024, 1:52 PM

APK:
https://github.com/wikimedia/apps-android-wikipedia/actions/runs/10850026211

Seddon subscribed.Sep 17 2024, 4:25 PM

The goal is specifically to move away from the custom library. There are some resultant changes in appearance but this can be iterated on in the future.

SChekfa-WMF subscribed.Sep 17 2024, 8:22 PM

this looks good to me, thank you @Dbrant!

SChekfa-WMF moved this task from Design signoff to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Sep 18 2024, 8:32 PM
GitHubPRBot added a comment.Sep 27 2024, 8:39 PM

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4954

Dbrant moved this task from Code Review to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Sep 27 2024, 9:02 PM
Dbrant moved this task from Merged and Waiting to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Oct 7 2024, 8:09 PM
ABorbaWMF moved this task from QA signoff to Did not pass QA on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Oct 8 2024, 11:07 PM
ABorbaWMF subscribed.

This is not working for me on Pixel 6, Android 14. Testing on 2.7.50505-r-2024-10-07

Long press options -
Wikipedia

share_142892354356765959.png (2×1 px, 1 MB)

Slack
Screenshot_20241008-160718.png (2×1 px, 1 MB)

Youtube
Screenshot_20241008-160733.png (2×1 px, 1 MB)

Dbrant moved this task from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Oct 9 2024, 3:51 PM
In T339295#10212831, @ABorbaWMF wrote:

This is not working for me on Pixel 6, Android 14. Testing on 2.7.50505-r-2024-10-07

Apologies, can you try again with yesterday's amended release:
https://releases.wikimedia.org/mobile/android/wikipedia/stable/wikipedia-2.7.50506-r-2024-10-08.apk

Also, was your comment intended for this task? T375367

ABorbaWMF moved this task from QA signoff to Ready for PM signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Oct 9 2024, 7:47 PM

Looking good for me on 2.7.50506-r-2024-10-08

JTannerWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Oct 16 2024, 4:02 PM
Dbrant closed this task as Resolved.Oct 21 2024, 12:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits