Page MenuHomePhabricator
Create Task
Maniphest T337832

Update the OnboardingDialog styles
Open, Needs TriagePublic
Actions

Description

As commented in Dialog: automatically display dividers when content is scrollable, Cdx-dialog will change from using gap to use padding in CSS styles to achieve the Dialog layout.
Once this happens, we will need to update our CSS styles to adapt to this change.

Details

SubjectRepoBranchLines +/-
Frontend documentation: Adapt OnboardingDialog styles to changes in CdxDialogmediawiki/extensions/GrowthExperimentsmaster+25 -3
Frontend documentation: Adapt OnboardingDialog styles to changes in CdxDialogmediawiki/extensions/GrowthExperimentsmaster+36 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

• VYanez-WMF created this task.May 31 2023, 10:02 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 31 2023, 10:02 AM
• VYanez-WMF removed a project: Growth-Team.May 31 2023, 10:03 AM
gerritbot added a comment.Jun 9 2023, 10:32 AM

Change 928807 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Adapt OnboardingDialog styles to changes in CdxDialog

https://gerrit.wikimedia.org/r/928807

gerritbot added a project: Patch-For-Review.Jun 9 2023, 10:32 AM
gerritbot added a comment.Jun 9 2023, 11:20 AM

Change 928807 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Adapt OnboardingDialog styles to changes in CdxDialog

https://gerrit.wikimedia.org/r/928807

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 11:29 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 9 2023, 12:00 PM
Sgs added a comment.Jun 15 2023, 12:13 PM

Note that there are new styles affecting the dialog body that need to be addressed:

Screenshot 2023-06-15 at 13.35.03.png (1×1 px, 178 KB)
Screenshot 2023-06-15 at 14.02.25.png (1×1 px, 242 KB)
Screenshot 2023-06-15 at 14.02.58.png (1×1 px, 239 KB)
extra body paddingextra header padding-bottomextra footer padding-top
gerritbot added a comment.Jun 15 2023, 12:21 PM

Change 930611 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Adapt OnboardingDialog styles to changes in CdxDialog

https://gerrit.wikimedia.org/r/930611

gerritbot added a project: Patch-For-Review.Jun 15 2023, 12:21 PM
gerritbot added a comment.Jun 16 2023, 9:21 AM

Change 930611 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: Adapt OnboardingDialog styles to changes in CdxDialog

https://gerrit.wikimedia.org/r/930611

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2023, 9:30 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 16 2023, 10:00 AM
Aklapper removed • VYanez-WMF as the assignee of this task.Aug 24 2023, 4:59 PM

Removing inactive task assignee who's not with WMF anymore. (WMF Growth-Team: Please do so as part of team offboarding steps - thanks.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits