Page MenuHomePhabricator
Create Task
Maniphest T337527

1.41.0-wmf.13 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jeena
Release Version
1.41.0-wmf.13
Release Date
Jun 12 2023, 12:00 AM

2023 week 24 1.41-wmf.13 Changes wmf/1.41.0-wmf.13

This MediaWiki Train Deployment is scheduled for the week of Monday, June 12th:

Monday June 12thTuesday, June 13thWednesday, June 14thThursday, June 15thFriday
Backports only.Branch wmf.13 and deploy to Group 0 Wikis.Deploy wmf.13 to Group 1 Wikis.Deploy wmf.13 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.13 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.12
Next: 1.41.0-wmf.14
SubjectRepoBranchLines +/-
Revert "Implement Language Converter for yue (Cantonese)"mediawiki/corewmf/1.41.0-wmf.13+20 -180
group2 wikis to 1.41.0-wmf.13operations/mediawiki-configmaster+327 -327
group1 wikis to 1.41.0-wmf.13operations/mediawiki-configmaster+544 -544
group0 wikis to 1.41.0-wmf.13operations/mediawiki-configmaster+544 -544
group1 wikis to 1.41.0-wmf.13operations/mediawiki-configmaster+544 -544
group0 wikis to 1.41.0-wmf.13operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.13operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.13mediawiki/corewmf/1.41.0-wmf.13+986 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.May 25 2023, 10:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2023, 10:20 PM
thcipriani assigned this task to jnuche.May 25 2023, 10:31 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jeena.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (They Live 🕶️🧟).
daniel subscribed.EditedJun 6 2023, 8:43 AM
Risky Patch! 🚂🔥
Lucas_Werkmeister_WMDE subscribed.EditedJun 6 2023, 9:14 AM

This code is used for all hooks, it is exercised hundreds of times with every request, and most test cases. If somethign is wrong with it, we will know very soon.

Indeed: T338213

Edit: The patch was temporarily reverted, but a new version of it, with a tiny adjustment to hopefully avoid the issues, is already up for review.

Edit 2: The reinstatement was already merged, so we’re back in “risky” territory – but so far it hasn’t broken CI again :)

hashar added a subtask: T338495: beta-scap-sync-world failure — SSL peer certificate or SSH remote key was not OK.Jun 9 2023, 6:32 AM
hashar mentioned this in T338495: beta-scap-sync-world failure — SSL peer certificate or SSH remote key was not OK.Jun 9 2023, 6:34 AM
TheresNoTime removed a subtask: T338495: beta-scap-sync-world failure — SSL peer certificate or SSH remote key was not OK.Jun 9 2023, 3:27 PM
Ladsgroup subscribed.Jun 9 2023, 10:56 PM
Daimona subscribed.Jun 10 2023, 3:06 PM
Jdlrobson subscribed.Jun 12 2023, 6:53 PM

During this train please ping me if you notice any issues with menu items displaying without icons in the mobile (Minerva) skin. None of these should be train blockers for this train, but I'd like to fix any issues relating to that promptly (see https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/928965 for example).

gerritbot added a comment.Jun 13 2023, 2:07 AM

Change 928916 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.13] Branch commit for wmf/1.41.0-wmf.13

https://gerrit.wikimedia.org/r/928916

gerritbot added a project: Patch-For-Review.Jun 13 2023, 2:07 AM
gerritbot added a comment.Jun 13 2023, 2:26 AM

Change 928916 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.13] Branch commit for wmf/1.41.0-wmf.13

https://gerrit.wikimedia.org/r/928916

gerritbot added a comment.Jun 13 2023, 3:01 AM

Change 929434 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929434

gerritbot added a comment.Jun 13 2023, 3:02 AM

Change 929434 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929434

Stashbot added a comment.Jun 13 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-13T03:02:42Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.13 refs T337527

Stashbot added a comment.Jun 13 2023, 3:52 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-13T03:52:09Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.13 refs T337527 (duration: 49m 27s)

gerritbot added a comment.Jun 13 2023, 8:12 AM

Change 929629 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929629

gerritbot added a comment.Jun 13 2023, 8:13 AM

Change 929629 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929629

Stashbot added a comment.Jun 13 2023, 8:20 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-13T08:20:17Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.13 refs T337527

gerritbot added a comment.Jun 13 2023, 8:44 AM

Change 929647 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@wmf/1.41.0-wmf.13] Revert "Implement Language Converter for yue (Cantonese)"

https://gerrit.wikimedia.org/r/929647

Winston_Sung subscribed.Jun 13 2023, 8:47 AM

[ Risky patch ] for backporting to wmf.13: since we've never removed a LC before
--https://gerrit.wikimedia.org/r/929447

In T337527#8926621, @gerritbot wrote:

Change 929647 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@wmf/1.41.0-wmf.13] Revert "Implement Language Converter for yue (Cantonese)"

https://gerrit.wikimedia.org/r/929647

Func subscribed.Jun 13 2023, 9:03 AM
In T337527#8926625, @Winston_Sung wrote:

[ Risky patch ] for backporting to wmf.13: since we've never removed a LC before
--https://gerrit.wikimedia.org/r/929447

I think ideally we should arrange it into June 15 UTC afternoon backport window if wmf13 deployed as normal schedule since the yue wiki is in group2.

jeena moved this task from Backlog to In progress on the Release-Engineering-Team (They Live 🕶️🧟) board.Jun 13 2023, 6:14 PM
matmarex added a subtask: T338978: Image and Media upload fails in Beta cluster.Jun 13 2023, 7:54 PM
jnuche closed subtask T338978: Image and Media upload fails in Beta cluster as Resolved.Jun 14 2023, 8:10 AM
jnuche removed a subtask: T338927: RecentChanges missing arrow to expand collapsed entries.Jun 14 2023, 8:56 AM
gerritbot added a comment.Jun 14 2023, 9:13 AM

Change 929993 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929993

gerritbot added a comment.Jun 14 2023, 9:14 AM

Change 929993 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929993

Stashbot added a comment.Jun 14 2023, 9:21 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-14T09:21:15Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.13 refs T337527

Stashbot added a comment.Jun 14 2023, 9:28 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-14T09:28:12Z] <jnuche@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.13 refs T337527 (duration: 06m 56s)

jnuche added a subtask: T339094: LogicException: Must call prepareContent() or prepareUpdate() before calling MediaWiki\Storage\DerivedPageDataUpdater::getRenderedRevision.Jun 14 2023, 9:52 AM
gerritbot added a comment.Jun 14 2023, 9:55 AM

Change 929999 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929999

gerritbot added a comment.Jun 14 2023, 9:55 AM

Change 929999 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/929999

Stashbot added a comment.Jun 14 2023, 10:03 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-14T10:03:35Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.13 refs T337527

jnuche added a comment.EditedJun 14 2023, 10:59 AM

After rolling back to wmf.12, now the Kartographer extension in group1 wikis is giving a small but constant stream of errors, like this one.

Volume is low and the T339094 blocker is already receiving attention by @Ladsgroup, so I'm going to wait a bit longer before I try to roll the train forward (which would require reverting the patches mentioned in T339094).

Ladsgroup closed subtask T339094: LogicException: Must call prepareContent() or prepareUpdate() before calling MediaWiki\Storage\DerivedPageDataUpdater::getRenderedRevision as Resolved.Jun 14 2023, 12:30 PM
gerritbot added a comment.Jun 14 2023, 12:33 PM

Change 930168 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/930168

gerritbot added a comment.Jun 14 2023, 12:34 PM

Change 930168 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/930168

Stashbot added a comment.Jun 14 2023, 12:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-14T12:41:39Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.13 refs T337527

Stashbot added a comment.Jun 14 2023, 12:47 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-14T12:47:50Z] <jnuche@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.13 refs T337527 (duration: 06m 10s)

jnuche added a comment.Jun 14 2023, 12:53 PM

After deploying wmf.13 to group1 again, Kartographer errors are gone.

gerritbot added a comment.Jun 15 2023, 8:04 AM

Change 930516 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/930516

gerritbot added a comment.Jun 15 2023, 8:05 AM

Change 930516 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.13

https://gerrit.wikimedia.org/r/930516

Stashbot added a comment.Jun 15 2023, 8:13 AM

Mentioned in SAL (#wikimedia-operations) [2023-06-15T08:13:31Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.13 refs T337527

gerritbot added a comment.Jun 15 2023, 2:19 PM

Change 929647 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.13] Revert "Implement Language Converter for yue (Cantonese)"

https://gerrit.wikimedia.org/r/929647

Stashbot mentioned this in T59106: Implement LanguageConverter for yue (Cantonese).Jun 15 2023, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-15T14:19:46Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:929647|Revert "Implement Language Converter for yue (Cantonese)" (T59106 T337527)]]

Stashbot added a comment.Jun 15 2023, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-15T14:21:11Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and wsung: Backport for [[gerrit:929647|Revert "Implement Language Converter for yue (Cantonese)" (T59106 T337527)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jun 15 2023, 2:29 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-15T14:29:39Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:929647|Revert "Implement Language Converter for yue (Cantonese)" (T59106 T337527)]] (duration: 09m 53s)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 15 2023, 3:00 PM
Winston_Sung added a comment.Jun 15 2023, 4:16 PM
In T337527#8926625, @Winston_Sung wrote:

[ Risky patch ] for backporting to wmf.13: since we've never removed a LC before
--https://gerrit.wikimedia.org/r/929447

In T337527#8926621, @gerritbot wrote:

Change 929647 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@wmf/1.41.0-wmf.13] Revert "Implement Language Converter for yue (Cantonese)"

https://gerrit.wikimedia.org/r/929647

Merged and backported. Doesn't seem to cause any issue.

jnuche closed this task as Resolved.Jun 19 2023, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits