Page MenuHomePhabricator
Create Task
Maniphest T324460

Search Preview: Search Preview doesn't work for articles with special characters in the title
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The search preview is not opening. There is an error in the devtools console: Error: Syntax error, unrecognized expression: [title='Geoffroy's cat']

What should have happened instead?:
The search preview for Geoffroy's catand other articles with special characters in the title should appear.

Details

SubjectRepoBranchLines +/-
Search Preview: Search Preview doesn't work for articles with special characters in the titlemediawiki/extensions/SearchVuemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

vadim-kovalenko created this task.Dec 5 2022, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2022, 1:22 PM
vadim-kovalenko renamed this task from Search Preview: Search Preview doesn't work for articles with speciad characters to Search Preview: Search Preview doesn't work for articles with special characters in the title.Dec 5 2022, 1:23 PM
gerritbot added a comment.Dec 5 2022, 3:23 PM

Change 863465 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/extensions/SearchVue@master] Search Preview: Search Preview doesn't work for articles with special characters in the title

https://gerrit.wikimedia.org/r/863465

gerritbot added a project: Patch-For-Review.Dec 5 2022, 3:23 PM
vadim-kovalenko claimed this task.Dec 5 2022, 3:25 PM
vadim-kovalenko moved this task from Triage to Current Work on the Structured-Data-Backlog board.
vadim-kovalenko edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
vadim-kovalenko moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Dec 5 2022, 9:24 PM

Change 863465 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search Preview: Search Preview doesn't work for articles with special characters in the title

https://gerrit.wikimedia.org/r/863465

vadim-kovalenko mentioned this in rESVUda111592e1a1: Search Preview: Search Preview doesn't work for articles with special….Dec 5 2022, 9:24 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 5 2022, 9:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 5 2022, 10:00 PM
vadim-kovalenko moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 6 2022, 9:48 AM
CBogen added a project: SDAW-Search-Improvements (Milestone 2: QuickView MVP).Dec 8 2022, 8:03 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 15 2022, 12:05 AM
Etonkovidova subscribed.

Checked in betalabs - the search Preview correctly displays articles with special characters in their titles.

Screen Shot 2022-12-14 at 4.02.18 PM.png (895×1 px, 657 KB)
Screen Shot 2022-12-14 at 4.01.22 PM.png (984×1 px, 401 KB)
Etonkovidova closed this task as Resolved.Jan 6 2023, 9:19 PM

Checked after deployment (wmf.17) to ruwiki, ptwiki, and idwiki - the issue is fixed.

Etonkovidova mentioned this in T326861: [S] [betalabs] Mobile - Search Preview displays Console errors for articles with apostrophe in the title.Jan 12 2023, 8:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits