Wrong list type used in visual diff
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Dec 2 2022, 6:20 PM

Description

The bullet points display incorrectly, because the list uses <li> elements nested in <dl>. They should be nested in <ul> instead.

(It seems that the <dl> is somehow getting transplanted from a nested list that correctly uses <dd> and <dl>.)

Expected rendering:

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (5a692bdf1)	mediawiki/extensions/VisualEditor	master	+1 -1
	List diffs: Fix overwriting top-level list when nested item added	VisualEditor/VisualEditor	master	+25 -11

Mentioned In: T337698: Non-existent localisation message ⧼visualeditor-listbutton-undefined-tooltip⧽ appears in a visual diff
T333410: Visual diff shows wrong list type on context items when item in a nested list with different type is removed

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2022, 6:20 PM

Change 973375 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] List diffs: Fix overwriting top-level list when nested item added

Change 973375 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] List diffs: Fix overwriting top-level list when nested item added

Change 974219 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5a692bdf1)

Change 974219 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5a692bdf1)

matmarex closed this task as Resolved.Nov 14 2023, 6:11 PM

matmarex claimed this task.