🍰 Simplify the value format in deserializers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ollie.Shotton_WMDE
	Nov 23 2022, 12:46 PM

Description

if the DataValue type is wikibase-entityid:
- use the EntityIdParser (that's already passed into PropertyValuePairDeserializer) to create an EntityId
- create a new EntityIdValue from the EntityId
- create the PropertyValueSnak from the property id and the EntityIdValue
- return the PropertyValueSnak

Details

	Subject	Repo	Branch	Lines +/-
	REST: Simplify the value format in deserializers	mediawiki/extensions/Wikibase	master	+199 -36

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		WMDE-leszek	T322734 🍰 Simplify value format for some value types in statement data of REST API requests and responses
		Resolved		Ollie.Shotton_WMDE	T323702 🍰 Simplify the value format in deserializers

Event Timeline

Ollie.Shotton_WMDE created this task.Nov 23 2022, 12:46 PM

Ollie.Shotton_WMDE claimed this task.Nov 23 2022, 1:12 PM

Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 18) board.

Ollie.Shotton_WMDE renamed this task from 🍰 Simplify the value format in PropertyValuePairDeserializer to 🍰 Simplify the value format in deserializers.Nov 23 2022, 2:45 PM

Ollie.Shotton_WMDE mentioned this in T322734: 🍰 Simplify value format for some value types in statement data of REST API requests and responses.

Change 860060 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Simplify the value format in deserializers

https://gerrit.wikimedia.org/r/860060

gerritbot added a project: Patch-For-Review.Nov 23 2022, 3:08 PM

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 18) board.Nov 24 2022, 9:59 AM

Change 860060 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Simplify the value format in deserializers

https://gerrit.wikimedia.org/r/860060

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2022, 3:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 25 2022, 4:01 PM

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 18) board.Nov 28 2022, 8:25 AM