Page MenuHomePhabricator
Create Task
Maniphest T321751

Change Evaluator Request Type to a Bespoke Type
Closed, ResolvedPublic
Actions

Description

Evaluator requests shouldn't be Z7s but a custom type specifying

  • the input arguments
  • the programming language
  • the code string

and, later, things like

  • whether to use reentrance
  • custom serialization and deserialization code strings

Using a custom type will allow the Avro schema to compress things much more efficiently.

Details

SubjectRepoBranchLines +/-
Change interface between evaluator and executors to be request format-agnostic.mediawiki/services/function-evaluatormaster+1 K -5 K
Update function-schemata sub-module to HEAD (a363827)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (a363827)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (a363827)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (a363827)mediawiki/tools/wikilambda-climaster+1 -1
Change Avro-serialized request to a bespoke type.mediawiki/services/function-schematamaster+216 -2
Customize query in gerrit

Related Objects

Event Timeline

cmassaro created this task.Oct 26 2022, 10:00 PM
cmassaro added a project: function-schemata.
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 15 2022, 8:00 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: G2. Correct & efficient on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 15 2022, 8:45 PM
cmassaro claimed this task.Dec 5 2022, 9:08 PM
cmassaro added a project: Abstract Wikipedia Fix-It tasks.
gerritbot added a comment.Dec 6 2022, 10:22 PM

Change 865175 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Change Avro-serialized request to a bespoke type.

https://gerrit.wikimedia.org/r/865175

gerritbot added a project: Patch-For-Review.Dec 6 2022, 10:22 PM
gerritbot added a comment.Dec 7 2022, 2:14 AM

Change 865221 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Change interface between evaluator and executors to be request format-agnostic.

https://gerrit.wikimedia.org/r/865221

gerritbot added a comment.Dec 7 2022, 3:58 PM

Change 865175 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Change Avro-serialized request to a bespoke type.

https://gerrit.wikimedia.org/r/865175

cmassaro mentioned this in rMSFS98d11c63d410: Change Avro-serialized request to a bespoke type..Dec 7 2022, 3:59 PM
gerritbot added a comment.Dec 7 2022, 4:50 PM

Change 865697 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865697

gerritbot added a comment.Dec 7 2022, 4:50 PM

Change 865700 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865700

gerritbot added a comment.Dec 7 2022, 4:50 PM

Change 865698 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865698

gerritbot added a comment.Dec 7 2022, 4:51 PM

Change 865699 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865699

gerritbot added a comment.Dec 7 2022, 6:57 PM

Change 865699 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865699

gerritbot added a comment.Dec 7 2022, 6:58 PM

Change 865697 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865697

Jdforrester-WMF mentioned this in rMTWCdb09a0416cbb: Update function-schemata sub-module to HEAD (a363827).Dec 7 2022, 7:00 PM
Jdforrester-WMF mentioned this in rMSFO6c34a8279579: Update function-schemata sub-module to HEAD (a363827).
gerritbot added a comment.Dec 7 2022, 7:00 PM

Change 865700 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865700

gerritbot added a comment.Dec 7 2022, 7:01 PM

Change 865698 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (a363827)

https://gerrit.wikimedia.org/r/865698

Jdforrester-WMF mentioned this in rMSFE8db2f4791766: Update function-schemata sub-module to HEAD (a363827).Dec 7 2022, 7:02 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 7 2022, 8:00 PM
gerritbot added a comment.Jan 5 2023, 3:58 PM

Change 865221 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Change interface between evaluator and executors to be request format-agnostic.

https://gerrit.wikimedia.org/r/865221

cmassaro mentioned this in rMSFEb898718ed7ca: Change interface between evaluator and executors to be request format-agnostic..Jan 5 2023, 3:59 PM
Jdforrester-WMF closed this task as Resolved.Jan 9 2023, 4:52 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 9 2023, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits