Page MenuHomePhabricator

PHP code for wikilambda_perform_test cannot handle expanded implementations or testers
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  • Send a request to wikilambda_perform_test that includes expanded objects in the implementations or testers array

Observed behavior:

Failure

Expected behavior (Acceptance criteria):

Success

Notes
There are a couple of places in the PHP code that assume implementations and testers are ZIDs, not expanded objects

Completion checklist

Event Timeline

Change 849120 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Fix flow where expanded implementation is sent to API for perform_test.

https://gerrit.wikimedia.org/r/849120

Change 849120 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix flow where expanded implementation is sent to API for perform_test.

https://gerrit.wikimedia.org/r/849120

Another patch still needed to ensure expanded testers are handled properly.

Change 855980 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Support receipt of JSON testers in the perform_test API method.

https://gerrit.wikimedia.org/r/855980

Change 855980 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Support receipt of JSON testers in the perform_test API method.

https://gerrit.wikimedia.org/r/855980