| • TThoabala | |
| Sep 29 2022, 7:49 AM |
| F35787837: T318898_VisualEditing_GB_CompositeBlock_Chrome_Pass.png | |
| Nov 16 2022, 11:58 PM |
| F35787834: T318898_VisualEditing_GB_LocalBlock_Chrome_Pass.png | |
| Nov 16 2022, 11:58 PM |
| F35787832: T318898_VisualEditing_GB_IPRange_Chrome_Pass.png | |
| Nov 16 2022, 11:58 PM |
| F35787830: T318898_VisualEditing_GB_IP_Chrome_Pass.png | |
| Nov 16 2022, 11:58 PM |
Following T257701: Add global blocks into CompositeBlocks rather than treating them separately
Remove usage of User::isBlockedGlobally and User::getGlobalBlock in VisualEditor
Usage of User::isBlockedGlobally found here
Usage of User::getGlobalBlock found here
Testing
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T231109 Remove Core coupling with GlobalBlocking extension | |||
| Open | None | T319069 Remove global-blocks-specific methods and hook from User class | |||
| Open | Spike | None | T315644 Global blocks should be treated as a subtype of blocks | ||
| Resolved | Cyndymediawiksim | T317337 Deprecate global-blocks-specific methods and hook | |||
| Resolved | • TThoabala | T317342 Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions | |||
| Resolved | Cyndymediawiksim | T318898 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in VisualEditor | |||
| Resolved | Tchanders | T257701 Add global blocks into CompositeBlocks rather than treating them separately | |||
| Resolved | Tchanders | T317308 GlobalBlocking should specify block error message key | |||
| Resolved | • AGueyte | T317201 Allow extensions to modify block error message key via a hook | |||
| Resolved | STran | T317190 GlobalBlock should extend AbstractBlock instead of DatabaseBlock |
Change 856527 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):
[mediawiki/extensions/VisualEditor@master] Remove usage of User::isBlockedGlobally and User::getGlobalBlock
@GMikesell-WMF If you're testing this one, it might be easiest to test it on Beta rather than setting up VisualEditor locally. You may need to be logged in, and you may need to go to Special:Preferences#mw-prefsection-editing to ensure VisualEditor is enabled.
Change 856527 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove usage of User::isBlockedGlobally and User::getGlobalBlock
@Tchanders I validated that I was receiving a block message when testing global block IP, range, local sitewide, and composite blocks as seen in the screenshots below. I could not do XFF since it doesn't work in beta but can test it locally if you want me to.
Is the block message error coming up as a notification fine, compared to how it usually shows the block message on the whole page?
Also, is it ok that the Local block notification is different than the other Global block messages since it's in the yellow block?
Test Environment: Beta
Browser: Chrome
Global Block IP
Global Block IP Range
Local Block Sitewide
Composite Block
I could not do XFF since it doesn't work in beta but can test it locally if you want me to.
Thanks @GMikesell-WMF. I don't think that's necessary, as the code change is small and doesn't treat XFF blocks differently.
Is the block message error coming up as a notification fine, compared to how it usually shows the block message on the whole page?
That's fine - this is just how the visual editor displays messages.
Also, is it ok that the Local block notification is different than the other Global block messages since it's in the yellow block?
That's fine too - it just means that the translation for this message has been overridden on the wiki to add some styling. (Here's the page that one can edit to override this message: https://en.m.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Blockedtext)
@Tchanders Got it, thanks! If that's the case, everything looks good, and I will be moving this to Done.