Page MenuHomePhabricator
Create Task
Maniphest T315292

Regression: Hovering parameter list in single template mode still does auto-scroll
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Split off from T312926: Regression: mouse hover at top of the parameter list causing automatic scrolling (VE template dialog): When the template dialog shows a single template with a very long list of parameters, the crazy unwanted auto-scrolling to the very top still happens. The reason is that the name of the template is not shown in the sidebar in this mode. This creates a special case where the sticky header is shorter.

Details

SubjectRepoBranchLines +/-
Fix calling order in template dialog .getSetupProcess()mediawiki/extensions/VisualEditormaster+8 -8
Add missing call to .recalculateStickyHeaderHeight()mediawiki/extensions/VisualEditormaster+5 -0
Dynamically calculate height of toolbar sticky headersmediawiki/extensions/VisualEditormaster+28 -6
Improve sticky height calculationmediawiki/extensions/VisualEditormaster+14 -4
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Aug 16 2022, 9:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2022, 9:52 AM
thiemowmde set the point value for this task to 2.Aug 16 2022, 9:54 AM
WMDE-Fisch claimed this task.Aug 16 2022, 1:41 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-08-03 board.
gerritbot added a comment.Aug 17 2022, 6:50 AM

Change 824121 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Improve sticky height calculation

https://gerrit.wikimedia.org/r/824121

gerritbot added a project: Patch-For-Review.Aug 17 2022, 6:50 AM
WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-08-03 board.Aug 17 2022, 6:52 AM
WMDE-Fisch moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Aug 17 2022, 7:27 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2022-08-17.Aug 17 2022, 8:12 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-08-17 board.
gerritbot added a comment.Aug 17 2022, 11:49 AM

Change 824188 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Dynamically calculate height of toolbar sticky headers

https://gerrit.wikimedia.org/r/824188

gerritbot added a comment.Aug 18 2022, 12:47 PM

Change 824121 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] Improve sticky height calculation

Reason:

Lets go for I15231d66bb832b92d1924881b0df7dbe9f26a921

https://gerrit.wikimedia.org/r/824121

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 19 2022, 6:51 AM
gerritbot added a comment.Aug 19 2022, 7:06 AM

Change 824188 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Dynamically calculate height of toolbar sticky headers

https://gerrit.wikimedia.org/r/824188

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2022, 7:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 19 2022, 8:00 AM
VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Aug 25 2022, 3:49 PM
thiemowmde moved this task from Demo to Doing on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 30 2022, 8:58 AM
gerritbot added a comment.Aug 30 2022, 9:57 AM

Change 827971 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add missing call to .recalculateStickyHeaderHeight()

https://gerrit.wikimedia.org/r/827971

gerritbot added a project: Patch-For-Review.Aug 30 2022, 9:57 AM
thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 30 2022, 9:58 AM
gerritbot added a comment.Aug 30 2022, 12:23 PM

Change 827995 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix calling order in template dialog .getSetupProcess()

https://gerrit.wikimedia.org/r/827995

gerritbot added a comment.Aug 30 2022, 12:31 PM

Change 827971 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add missing call to .recalculateStickyHeaderHeight()

https://gerrit.wikimedia.org/r/827971

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 30 2022, 1:00 PM
gerritbot added a comment.Aug 30 2022, 1:28 PM

Change 827995 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix calling order in template dialog .getSetupProcess()

https://gerrit.wikimedia.org/r/827995

Lena_WMDE added a project: WMDE-TechWish-Sprint-2022-08-31.Aug 31 2022, 11:10 AM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-08-31 board.Aug 31 2022, 11:11 AM
Lena_WMDE removed WMDE-Fisch as the assignee of this task.Aug 31 2022, 11:17 AM
thiemowmde moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-08-31 board.Aug 31 2022, 2:51 PM
WMDE-Fisch removed a project: Patch-For-Review.Sep 13 2022, 7:49 AM
WMDE-Fisch closed this task as Resolved.Sep 13 2022, 9:19 AM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-08-31 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits