| ECohen_WMDE | |
| Jul 13 2022, 10:41 AM |
| F35315958: Scrolling bug.gif | |
| Jul 13 2022, 10:41 AM |
Steps to replicate the issue (include links if applicable):
What happens?:
The list starts auto-scrolling upwards until the top parameter has scrolled into view
What should have happened instead?:
No scrolling
Software version (skip for WMF-hosted wikis like Wikipedia):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | WMDE-Fisch | T312926 Regression: mouse hover at top of the parameter list causing automatic scrolling (VE template dialog) | ||
| Invalid | None | T313002 Browser's autoscroll doesn't work well with sticky outline header |
Change 813638 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/extensions/VisualEditor@master] Don't always scroll when highlighting
This one is suddenly acting better, but I don't understand why. I've played with different window sizes, and the autoscroll on hover will pull a line into view to be fully visible, but doesn't continue forever. I guess we can close until we hear more bug reports?
Change 813638 abandoned by Awight:
[mediawiki/extensions/VisualEditor@master] Don't always scroll when highlighting
Reason:
Seems to not be necessary.
This one is suddenly acting better, but I don't understand why. I've played with different window sizes, and the autoscroll on hover will pull a line into view to be fully visible, but doesn't continue forever. I guess we can close until we hear more bug reports?
So strange - when I checked last week it as fixed. Just tested on beta to double check and confirm to close, but the bug is back. Is back for you too @awight ?
The issue is related to our custom scrolling tweak that makes sure elements are not hidden behind the sticky when scrolled into view. See also T313002: Browser's autoscroll doesn't work well with sticky outline header. We currently have that workaround tweak that takes the height of the header into account and adjusts the scroll into view with a padding of the same size. [1]
Unfortunately this size is hardcoded at the moment because the place where it's used is buried a bit deeper in the dependency chain and we wanted to avoid calculating this height dynamically and passing it on over a lot of classes.
The fixed height we use for the padding is the height with the template title in the sticky header. So for single part transclusions it's a bit too much and you will get that automatic scrolling effect.
Three ways to move forward here ordered by effort:
Change 819046 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):
[mediawiki/extensions/VisualEditor@master] Tweak the hard coded top scroll padding for the parameter list
FYI: That patch is just a minor tweak for the multi part transclusion. Fixing an issues with 1px that still might lead to auto scroll when you move your mouse to that 1px at the top of the parameter list.
Change 819046 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Tweak the hard coded top scroll padding for the parameter list
Change 819060 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Scroll below sticky header only if sticky header is present
Change 819060 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Scroll below sticky header only if sticky header is present
Change 819507 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Show "no parameters" message only when there are no parameters
Change 819508 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Tweak the hard coded top scroll padding for the parameter list
Change 819516 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Restore scrolling parameters into view with(out) sticky header
Change 819535 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.23] Restore scrolling parameters into view with(out) sticky header
Change 819524 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Tweaks to focus/scrolling code relative to sticky header
Change 819516 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Restore scrolling parameters into view with(out) sticky header
Change 819535 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.23] Restore scrolling parameters into view with(out) sticky header
The patches merged should fix the issue for cases with and without the sticky header. We're not introducing a dynamic calculation for now but the main user facing issues should be gone.
Change 819524 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Tweaks to focus/scrolling code relative to sticky header
Change 819508 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Tweak the hard coded top scroll padding for the parameter list
Change 819507 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Show "no parameters" message only when there are no parameters
In today's demo time we found a single remaining special case. Moved to a new ticket: T312926: Regression: mouse hover at top of the parameter list causing automatic scrolling (VE template dialog)