Page MenuHomePhabricator

Replace 'articles' icon with 'copy' icon in various places
Closed, ResolvedPublic

Assigned To
Authored By
Esanders
Jul 11 2022, 12:37 PM
Referenced Files
F38219923: image.png
Oct 13 2023, 3:53 AM
F35314005: image.png
Jul 11 2022, 12:59 PM
F35314001: image.png
Jul 11 2022, 12:59 PM
F35313998: image.png
Jul 11 2022, 12:59 PM

Description

After T295058 there will be a dedicated 'copy' icon in OOUI, so we don't have to use 'articles' as an approximation anymore.

Places this used:

  • mw.widgets.CopyTextLayout, used by:
    • ApiSandbox for copying wikitext output
    • CheckUsers's investigate wikitable generator
    • MMV's share tool
    • UploadWizard after upload use tool
    • UrlShortener
  • VE's MobileActionsContextItem

Event Timeline

Change 812861 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] CopyTextLayout: Use 'copy' icon

https://gerrit.wikimedia.org/r/812861

Change 812862 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] MobileActionsContextItem: Use 'copy' icon

https://gerrit.wikimedia.org/r/812862

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF updated the task description. (Show Details)

Change 812862 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] MobileActionsContextItem: Use 'copy' icon

https://gerrit.wikimedia.org/r/812862

Change 812861 merged by jenkins-bot:

[mediawiki/core@master] CopyTextLayout: Use 'copy' icon

https://gerrit.wikimedia.org/r/812861

Change 817291 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1ab6be70d)

https://gerrit.wikimedia.org/r/817291

Change 817291 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1ab6be70d)

https://gerrit.wikimedia.org/r/817291

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d5c8383ce7/w/

So why UrlShortener still uses the articles icon?

image.png (192×339 px, 7 KB)

...Because in a later commit making mw.widgets.CopyTextLayout.js based on an OOUI widget this change has been erased.

Change 965698 had a related patch set uploaded (by Jack who built the house; author: Jack who built the house):

[oojs/ui@master] CopyTextLayout: Use 'copy' icon

https://gerrit.wikimedia.org/r/965698

Change 965698 merged by jenkins-bot:

[oojs/ui@master] CopyTextLayout: Use 'copy' icon

https://gerrit.wikimedia.org/r/965698