Page MenuHomePhabricator
Create Task
Maniphest T312213

Focus is sometimes lost when unchecking a parameter using space
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When de-selecting a parameter using space focus is sometimes lost. There seem to be at least to cases where that happens. One of them got worse after removing the selection in T312085: Remove selection when selected parameter is unchecked.

Steps to reproduce:

  • Load the template dialog with a template that has several parameters checked
  • Use the keyboard to tab into the parameter selection in the sidebar

1st case:

  • Use space to uncheck a parameter that's not selected
  • Use space again to check it
  • Use space again to uncheck it
  • Focus will be lost and you cannot use the spacebar to trigger the same parameter again

2st case:

  • Use space to uncheck a parameter that's selected
  • Focus will be lost and you cannot use the spacebar to trigger the same parameter again

Details

SubjectRepoBranchLines +/-
Fix forgotten "setPage" property because of merge conflictmediawiki/extensions/VisualEditormaster+4 -4
Fix "current page" not being reset when page is removedmediawiki/extensions/VisualEditormaster+1 -0
Fix sidebar losing focus when unchecking params with spacemediawiki/extensions/VisualEditormaster+8 -4
Minor fixes and optimizations to ParameterSelectWidgetmediawiki/extensions/VisualEditormaster+6 -3
Differ between setting and highlighting a parametermediawiki/extensions/VisualEditormaster+45 -44
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Jul 6 2022, 12:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2022, 12:55 PM
WMDE-Fisch moved this task from To Triage to Triaged on the VisualEditor board.Jul 6 2022, 12:55 PM
WMDE-Fisch mentioned this in T312085: Remove selection when selected parameter is unchecked.
awight mentioned this in T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.Jul 6 2022, 1:20 PM
WMDE-Fisch claimed this task.Jul 7 2022, 1:11 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-06 board.
awight claimed this task.Jul 8 2022, 12:08 PM
awight subscribed.

(Stealing a base!)

awight removed awight as the assignee of this task.Jul 8 2022, 12:46 PM
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 8 2022, 12:51 PM
gerritbot added a comment.Jul 9 2022, 7:00 AM

Change 812435 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Differ between setting and highlighting a parameter

https://gerrit.wikimedia.org/r/812435

gerritbot added a project: Patch-For-Review.Jul 9 2022, 7:00 AM
WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 9 2022, 7:02 AM
WMDE-Fisch claimed this task.Jul 11 2022, 9:05 AM
lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 11 2022, 2:54 PM
WMDE-Fisch moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 12 2022, 9:03 AM
awight moved this task from Demo to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 12 2022, 10:33 AM
awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-06 board.
gerritbot added a comment.Jul 12 2022, 10:48 AM

Change 812435 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Differ between setting and highlighting a parameter

https://gerrit.wikimedia.org/r/812435

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 12 2022, 11:31 AM
lilients_WMDE removed WMDE-Fisch as the assignee of this task.EditedJul 18 2022, 12:58 PM
lilients_WMDE moved this task from Demo to Sprint Backlog on the WMDE-TechWish-Sprint-2022-07-06 board.
lilients_WMDE subscribed.

Moving this back because the behaviour happens again in the current master branch. This patch might be the reason: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/814163.

gerritbot added a comment.Jul 18 2022, 1:57 PM

Change 814817 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix sidebar loosing focus when unchecking params with space

https://gerrit.wikimedia.org/r/814817

gerritbot added a project: Patch-For-Review.Jul 18 2022, 1:57 PM
lilients_WMDE moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 18 2022, 2:29 PM
gerritbot added a comment.Jul 19 2022, 2:39 PM

Change 815302 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Minor fixes and optimizations to ParameterSelectWidget

https://gerrit.wikimedia.org/r/815302

gerritbot added a comment.Jul 19 2022, 3:24 PM

Change 815313 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix "current page" not being reset when page is removed

https://gerrit.wikimedia.org/r/815313

thiemowmde added a project: WMDE-TechWish-Sprint-2022-07-20.Jul 20 2022, 8:08 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-20 board.
gerritbot added a comment.Jul 20 2022, 9:35 AM

Change 815302 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Minor fixes and optimizations to ParameterSelectWidget

https://gerrit.wikimedia.org/r/815302

gerritbot added a comment.Jul 20 2022, 9:40 AM

Change 814817 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix sidebar losing focus when unchecking params with space

https://gerrit.wikimedia.org/r/814817

gerritbot added a comment.Jul 20 2022, 9:42 AM

Change 815313 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix "current page" not being reset when page is removed

https://gerrit.wikimedia.org/r/815313

lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-20 board.Jul 20 2022, 9:53 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.22; 2022-07-25); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 20 2022, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 10:30 AM
gerritbot added a comment.Aug 1 2022, 7:43 AM

Change 818995 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix forgotten "setPage" property because of merge conflict

https://gerrit.wikimedia.org/r/818995

gerritbot added a project: Patch-For-Review.Aug 1 2022, 7:43 AM
gerritbot added a comment.Aug 1 2022, 9:37 AM

Change 818995 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix forgotten "setPage" property because of merge conflict

https://gerrit.wikimedia.org/r/818995

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Aug 1 2022, 11:00 AM
thiemowmde closed this task as Resolved.Aug 16 2022, 9:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits