Remove obsolete bits from mediawiki.action.view.redirect.js
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tacsipacsi
	Jun 27 2022, 9:06 PM

Description

rMW resources/src/mediawiki.action/mediawiki.action.view.redirect.js has a lot of compatibility checks/hacks that are no longer necessary:

Supporting browsers that don’t support History.replaceState(). The last Grade A browsers without History.replaceState() became Grade C in 2017 (T128115).
Firefox <33 jumping support. Firefox <39 is not supported at all (not even Basic support) since April 2022 (T297313). The feature tests don’t seem to catch it, so JS may load there, but removing the jumping support won’t cause runtime errors, only a somewhat degraded UX (no jump to section). Since these versions are explicitly unsupported, I think this is acceptable.
Supporting Safari 0.x–2.x (WebKit <420). I couldn’t find out when was support for such ancient Safaris dropped, probably they have been unsupported ever since there are browser support was formalized. (The hack was added in 4dc8d4a3f52, more than 15 years ago, mentioning that the nightlies were already fixed by then…)

	Subject	Repo	Branch	Lines +/-
	mediawiki.action.view.redirect: Remove obsolete browser support code	mediawiki/core	master	+9 -34

Status	Assigned	Task
Resolved	Tacsipacsi	T311461 Remove obsolete bits from mediawiki.action.view.redirect.js
Resolved	Jdforrester-WMF	T128115 Drop support for ES3 javascript browsers in MediaWiki
Resolved	Krinkle	T102318 Convert startup blacklist to feature test
Resolved	Krinkle	T128924 Study effect of proposed ResourceLoader feature test in production
Resolved	Volker_E	T297313 Move Firefox 27-38 from Basic support to Unknown support

Tacsipacsi changed the task status from Open to In Progress.Jun 27 2022, 9:06 PM

Tacsipacsi created this task.

Change 809023 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/core@master] Remove obsolete bits from mediawiki.action.view.redirect.js

Change 809023 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.action.view.redirect: Remove obsolete browser support code