[regression] Margining collapse applying to Vector heading when title BELOW tabs
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 23 2022, 11:25 PM

Description

Pixel flagged a UI regression relating to the margin underneath the heading which was caused by moving mw-body-subheader under #bodyContent (https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/807232)

Screen Shot 2022-06-23 at 5.32.33 PM.png (1×2 px, 411 KB)

Iring on the side of caution we should not change the margin unintentionally.

List of steps to reproduce (step by step, including full links if applicable):

Set $wgVectorTitleAboveTabs = false;

What happens?:

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

	Subject	Repo	Branch	Lines +/-
	Revise margin collapsing rules with new layout	mediawiki/skins/Vector	master	+5 -8

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jun 23 2022, 11:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2022, 11:25 PM

Jdlrobson added a project: Regression.Jun 23 2022, 11:25 PM

Jdlrobson updated the task description. (Show Details)

• nray updated the task description. (Show Details)Jun 23 2022, 11:33 PM

Change 808091 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Revise margin collapsing rules with new layout

https://gerrit.wikimedia.org/r/808091

gerritbot added a project: Patch-For-Review.Jun 23 2022, 11:33 PM

Jdlrobson renamed this task from Margining collapse applying to Vector heading when title BELOW tabs to [regression] Margining collapse applying to Vector heading when title BELOW tabs.Jun 23 2022, 11:33 PM

Jdlrobson triaged this task as High priority.

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 23 2022, 11:50 PM

Change 808091 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revise margin collapsing rules with new layout

https://gerrit.wikimedia.org/r/808091

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2022, 4:30 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 24 2022, 4:44 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 24 2022, 5:00 PM

No longer flagged on pixel.wmcloud.org

	F35269375: Screen Shot 2022-06-23 at 5.32.33 PM.png
	Jun 23 2022, 11:33 PM

	F35269363: Screen Shot 2022-06-23 at 4.20.34 PM.png
	Jun 23 2022, 11:25 PM

[regression] Margining collapse applying to Vector heading when title BELOW tabsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

[regression] Margining collapse applying to Vector heading when title BELOW tabs
Closed, ResolvedPublicBUG REPORT
Actions