AC:
- Add the info help icon for ASN
- Add the following text to the help popup: A unique identifier for networks assigned to a region and further to organizations like governments and ISPs
• Prtksxna | |
Jun 21 2022, 4:14 AM |
F35283165: asn_popup_beta.png | |
Jun 28 2022, 9:09 AM |
F35265190: image.png | |
Jun 22 2022, 5:33 PM |
F35265182: image.png | |
Jun 22 2022, 5:33 PM |
F35265187: image.png | |
Jun 22 2022, 5:33 PM |
F35265185: image.png | |
Jun 22 2022, 5:33 PM |
F35265170: image.png | |
Jun 22 2022, 5:33 PM |
Restricted File | |
Jun 22 2022, 3:50 PM |
AC:
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Add help icon to infobox ASN | mediawiki/extensions/IPInfo | master | +12 -5 |
We have a slight design issue here, the help popup is melting with the sidebar text, should I fix it in this patch or create a new ticket?
cc @Tchanders
{F35264850}
Change 807591 had a related patch set uploaded (by AGueyte; author: AGueyte):
[mediawiki/extensions/IPInfo@master] Add help icon to infobox ASN
The problem comes from the backwards align that we set on the help popup:
popup: { $content: $( '<span>' ).text( propertyTooltip ), padded: true, align: 'backwards', // <--------------- HERE position: 'above' },
We could solve this by removing the align config, but this still overlap the main menu, even on a fairly normal window width:
Perhaps better, we could set it to 'forwards':
Left column | Middle column | Right column |
RTL language:
Change 807591 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Add help icon to infobox ASN
Here is what the popup looks like on beta, Vector 2022, English:
I also tested Vector 2010, Minerva, MonoBook and Timeless in French, German and Hebrew at different zoom levels.
We are using an OOUI widget so I assume it should work across different browsers.
Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (f2f0771) 06:39, 28 June 2022.
Test browser: Firefox 91.