Page MenuHomePhabricator
Create Task
Maniphest T310839

Do not grey out page title when in edit mode (Vector 2022)
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
Jun 16 2022, 9:12 PM
Tags
Referenced Files
F35280407: Screen Shot 2022-06-27 at 12.21.11 PM.png
Jun 27 2022, 10:21 AM
F35268957: switch to editor.webm
Jun 23 2022, 7:25 PM
F35266072: switch to editor.webm
Jun 23 2022, 1:18 AM
F35265965: after.webm
Jun 22 2022, 11:51 PM
F35265964: before.webm
Jun 22 2022, 11:51 PM
F35247554: Group Copy.jpg
Jun 16 2022, 9:12 PM
F35247550: Group.jpg
Jun 16 2022, 9:12 PM
Subscribers
Aklapper
• alexhollender_WMF
Batorsz
DLynch
Esanders
Jdlrobson
Jdrewniak
View All 13 Subscribers

Description

Description

Now that we have moved the VE toolbar below the page title we no longer need to grey out the page title in order to communicate that it is not editable.

currentupdated
Group.jpg (822×1 px, 391 KB)
Group Copy.jpg (822×1 px, 392 KB)

Notes

approval from Editing-team: T310197#8010152

Details

SubjectRepoBranchLines +/-
Do not grey out page title while loading on Vector 2022mediawiki/extensions/VisualEditorwmf/1.39.0-wmf.17+5 -6
Use the data-ve-target-container attribute to position VEmediawiki/skins/Vectormaster+2 -3
Do not grey out page title while loading on Vector 2022mediawiki/extensions/VisualEditormaster+5 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Jun 16 2022, 9:12 PM
Jdlrobson added a comment.Jun 21 2022, 8:18 PM

@alexhollender_WMF is this for all skins, or just the new Vector? if the new Vector what's the reasoning for keeping the old one the same?

gerritbot added a comment.Jun 22 2022, 12:16 AM

Change 807232 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@master] Use the data-ve-target-container attribute to position VE

https://gerrit.wikimedia.org/r/807232

gerritbot added a project: Patch-For-Review.Jun 22 2022, 12:16 AM
Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Jun 22 2022, 12:17 AM
Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

(Note if this is Vector 2022 only this is fixed by the fix for T310197.)

Jdlrobson triaged this task as Medium priority.Jun 22 2022, 12:17 AM
Jdlrobson set the point value for this task to 0.
• alexhollender_WMF renamed this task from Do not grey out page title when in edit mode to Do not grey out page title when in edit mode (Vector 2022).Jun 22 2022, 7:43 PM
In T310839#8017921, @Jdlrobson wrote:

@alexhollender_WMF is this for all skins, or just the new Vector? if the new Vector what's the reasoning for keeping the old one the same?

Vector 2022 only

gerritbot added a comment.Jun 22 2022, 11:51 PM

Change 807655 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/807655

matmarex added a comment.EditedJun 22 2022, 11:51 PM

While testing the VE patch, I noticed that the title was still being greyed out while the editor was loading (but not after it was loaded). My patch above resolves this issue.

BeforeAfter
Jdlrobson moved this task from Blocked on Others to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.EditedJun 23 2022, 12:36 AM

@alexhollender_WMF this should be testable shortly on the beta cluster https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?action=edit
Please move to needs more work or sign off depending on how your testing goes.

matmarex attached a referenced file: F35265965: after.webm. (Show Details)Jun 23 2022, 12:50 AM
matmarex attached a referenced file: F35265964: before.webm. (Show Details)
gerritbot added a comment.Jun 23 2022, 12:58 AM

Change 807232 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use the data-ve-target-container attribute to position VE

https://gerrit.wikimedia.org/r/807232

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 23 2022, 1:00 AM
• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Jun 23 2022, 1:18 AM
• alexhollender_WMF moved this task from Design Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

thanks for catching that @matmarex.

In T310839#8021622, @Jdlrobson wrote:

@alexhollender_WMF this should be testable shortly on the beta cluster https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?action=edit
Please move to needs more work or sign off depending on how your testing goes.

what I'm seeing on beta does not match what @matmarex posted in T310839#8021563. notice that while the editor is loading the page title and toolbar are greyed out:

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 23 2022, 5:04 PM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 23 2022, 5:55 PM

Change 807655 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/807655

Jdlrobson assigned this task to • alexhollender_WMF.Jun 23 2022, 5:59 PM
Jdlrobson moved this task from Blocked on Others to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• alexhollender_WMF added a comment.Jun 23 2022, 6:03 PM

@Jdlrobson where should I test this? I'm not seeing any changes from yesterday on beta

Jdlrobson added a comment.Jun 23 2022, 6:13 PM

Patch got merged 8 minutes ago, so will hopefully be on the beta cluster shortly.

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2022, 6:30 PM
• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Jun 23 2022, 7:25 PM
• alexhollender_WMF moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Macro seal-of-approval: fan tastic

ovasileva added a comment.Jun 27 2022, 10:21 AM

Looks good, resolving! From the beta cluster:

Screen Shot 2022-06-27 at 12.21.11 PM.png (625×1 px, 345 KB)

ovasileva closed this task as Resolved.Jun 27 2022, 10:21 AM
ovasileva claimed this task.
gerritbot added a comment.Jun 28 2022, 10:32 PM

Change 809308 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.17] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/809308

gerritbot added a project: Patch-For-Review.Jun 28 2022, 10:32 PM
gerritbot added a comment.Jun 28 2022, 11:13 PM

Change 809308 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.17] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/809308

Stashbot added a comment.Jun 28 2022, 11:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-28T23:20:37Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.17/extensions/VisualEditor/modules/ve-mw/preinit: Backport: [[gerrit:809308|Do not grey out page title while loading on Vector 2022 (T310839)]] (duration: 03m 28s)

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2022, 11:30 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.17; 2022-06-20); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 8:02 PM
matmarex mentioned this in T322725: Allow selection of the page title in 2017 Wikitext Editor on Vector 2022.Nov 9 2022, 5:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits