Page MenuHomePhabricator

Shortcut to add a template conflicts with existing VE RTL shortcut
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

We discovered that one of the shortcuts we chose is already in use. Even though the RTL functionality doesn't currently work in the dialog we want to change it to reduce confusion and a possible future conflict if the RTL functionality becomes possible.

Requirements

  • Switch "Add a template" shortcut from Ctrl+Alt+D to Ctrl + D. On the mac, use Cmd-D

Event Timeline

I think this was accidentally assigned because I created a subticket from the other one.

Lena_WMDE set the point value for this task to 1.Nov 3 2021, 2:16 PM

Change 736480 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Update the shortcut for adding a template in the template dialog

https://gerrit.wikimedia.org/r/736480

Change 736480 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update the shortcut for adding a template in the template dialog

https://gerrit.wikimedia.org/r/736480

From today's demo time: I realized that Ctrl+Alt+D minimizes all windows in Ubuntu.

Screenshot from 2021-11-09 10-35-17.png (368×891 px, 50 KB)

That's a little confusing, because the actual keyboard shortcut for this is described as Ctrl+Super+D (with super being the Windows key). But there is another mapping that makes the Windows key and Alt behave the same (in certain situations?). I can see this in gnome-tweaks:

Screenshot from 2021-11-09 10-40-30.png (539×502 px, 80 KB)

Suggestion: Just use Ctrl+D. This shortcut isn't free either. It's the bookmark feature in many browsers (tested with Chrome and Firefox). However, what's the point of bookmarking an active template editor dialog? @ECohen_WMDE, do you think this is fine? What should it be on Mac then?

Change 737626 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Update shortcut to add a part in the template dialog, take #3

https://gerrit.wikimedia.org/r/737626

Team has decided to use <control>-D.

Change 737626 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update shortcut to add a part in the template dialog, take #3

https://gerrit.wikimedia.org/r/737626

Just tried this on beta and it's not working for me (the shortcut is still bookmarking the page). Is this a bug or is it not yet live on beta?

Actually after discussing with Timur, we seem to be having different issues and which go beyond just this shortcut. Will create a follow-up ticket to track them all together

This might be because a specific Mac shortcut is needed. We had no chance to fully test this on Mac, yet.

Change 740785 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Fix shortcut for adding a part in the template dialog on MacOS

https://gerrit.wikimedia.org/r/740785

Change 740786 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix missing Meta+D shortcut on Mac

https://gerrit.wikimedia.org/r/740786

Change 740785 abandoned by Andrew-WMDE:

[mediawiki/extensions/VisualEditor@master] Fix shortcut for adding a part in the template dialog on MacOS

Reason:

Going with I1edc2b3b0a77e02bf8e7ac789cabe007c5f5c527

https://gerrit.wikimedia.org/r/740785

Change 740786 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix missing Meta+D shortcut on Mac

https://gerrit.wikimedia.org/r/740786

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-11-24 board.