Maniphest T292689

extensions/CodeReview - replace the block-related methods
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Vlad.shapik
	Oct 7 2021, 7:41 AM

Tags

Referenced Files

None

Subscribers

Details

	Subject	Repo	Branch	Lines +/-
	Avoid using User::isBlocked()	mediawiki/extensions/CodeReview	master	+124 -111
	Avoid using User::isBlocked()	mediawiki/extensions/CodeReview	master	+79 -64

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T277511 Drop hard-deprecated User methods once they've been hard-deprecated in at least once release
		Open		None	T274211 Finish hard-deprecation and removal of User methods depecated prior to MW 1.36
		Resolved		None	T276371 Avoid using User ::isBlocked, ::isBlockedFrom, ::blockedFor, ::isBlockedFromCreateAccount
		Resolved		Vlad.shapik	T292689 extensions/CodeReview - replace the block-related methods

Event Timeline

Vlad.shapik triaged this task as Medium priority.Oct 7 2021, 7:41 AM

Vlad.shapik created this task.

Change 732958 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CodeReview@master] Avoid using User::isBlocked()

https://gerrit.wikimedia.org/r/732958

gerritbot added a project: Patch-For-Review.Oct 22 2021, 12:16 PM

Vlad.shapik moved this task from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Oct 26 2021, 3:29 PM

Vlad.shapik moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.Oct 26 2021, 3:36 PM

Change 737029 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CodeReview@master] Avoid using User::isBlocked()

https://gerrit.wikimedia.org/r/737029

Change 737029 abandoned by Vlad.shapik:

[mediawiki/extensions/CodeReview@master] Avoid using User::isBlocked()

Reason:

Misclick... It is the duplicate of I727365f5129d9a2ee8dfe988326ddd6d329db924

https://gerrit.wikimedia.org/r/737029

Vlad.shapik moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Nov 5 2021, 12:57 PM

Vlad.shapik moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Nov 15 2021, 4:05 PM

Change 732958 merged by jenkins-bot:

[mediawiki/extensions/CodeReview@master] Avoid using User::isBlocked()

https://gerrit.wikimedia.org/r/732958

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 15 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2021, 5:10 PM

Vlad.shapik closed this task as Resolved.Nov 29 2021, 9:45 AM