from stylelint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	taavi
	Sep 5 2021, 6:37 AM

Description

See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/718817 (patch set 1) and https://libraryupgrader2.wmcloud.org/logs2/428397: no rules were failing, but libup still tried to disable them.

Details

	Subject	Repo	Branch	Lines +/-
	Add stylelint ignore to NearbyPages	mediawiki/extensions/NearbyPages	master	+5 -0

Customize query in gerrit

Event Timeline

taavi created this task.Sep 5 2021, 6:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2021, 6:37 AM

If an extension is not using Gruntfile.js, LibUp will run stylelint over **/*.{css,less}, expecting that the extension has configured stylelint to ignore vendor/, node_modules, etc.

https://gerrit.wikimedia.org/r/plugins/gitiles/labs/libraryupgrader/+/refs/heads/master/runner/runner/__init__.py#1004

Looking at the log, it seems to have tried linting all the CSS in vendor/, there needs to be an exclusion/ignore rule set up for that.

Legoktm renamed this task from LibUp tried to disable many stylelint rules even when none were failing to NearbyPages does not exclude vendor/ or node_modules/ from stylelint.Sep 5 2021, 7:10 AM

Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Sep 7 2021, 7:05 PM

Jdlrobson moved this task from Backlog to WVUI migrations on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 7 2021, 8:09 PM

Change 719351 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/NearbyPages@master] Add stylelint ignore to NearbyPages

https://gerrit.wikimedia.org/r/719351

gerritbot added a project: Patch-For-Review.Sep 7 2021, 8:12 PM

Change 719351 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] Add stylelint ignore to NearbyPages

https://gerrit.wikimedia.org/r/719351

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 9:10 PM

Jdlrobson closed this task as Resolved.Sep 7 2021, 9:18 PM