Page MenuHomePhabricator
Create Task
Maniphest T290105

Adyen Checkout: Further CSS tweaks
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Damilare
Authored By
AndyRussG
Aug 31 2021, 7:18 PM
Tags
Referenced Files
F34636074: Screenshot_20210907-222444_Chrome.jpg
Sep 7 2021, 9:32 PM
F34636076: Screenshot_20210907-222432_Chrome.jpg
Sep 7 2021, 9:32 PM
F34626954: Screenshot_2021-08-31 Make your donation now - Payments.png
Aug 31 2021, 7:18 PM
F34626953: Screenshot_2021-08-31 Make your donation now - Payments(1).png
Aug 31 2021, 7:18 PM
Subscribers
Aklapper
AndyRussG
jgleeson

Description

Different fields have slightly different heights:

Screenshot_2021-08-31 Make your donation now - Payments(1).png (1×1 px, 100 KB)

This looks worse when more address fields are required:

Screenshot_2021-08-31 Make your donation now - Payments.png (1×1 px, 104 KB)

Details

SubjectRepoBranchLines +/-
Adyen Checkout: Further CSS tweaksmediawiki/extensions/DonationInterfacemaster+12 -3
Adyen Checkout: Further CSS tweaksmediawiki/extensions/DonationInterfacemaster+3 -2
Customize query in gerrit

Event Timeline

AndyRussG created this task.Aug 31 2021, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2021, 7:18 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Aug 31 2021, 7:38 PM
• DStrine set the point value for this task to 2.Aug 31 2021, 7:41 PM
XenoRyet added a project: fundraising sprint Quantum Leapfrog.Aug 31 2021, 8:35 PM
• DStrine triaged this task as High priority.Sep 2 2021, 4:58 PM
Damilare claimed this task.Sep 3 2021, 4:20 PM
gerritbot added a comment.Sep 7 2021, 8:35 PM

Change 719358 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Adyen Checkout: Further CSS tweaks

https://gerrit.wikimedia.org/r/719358

gerritbot added a project: Patch-For-Review.Sep 7 2021, 8:35 PM
gerritbot added a comment.Sep 7 2021, 9:15 PM

Change 719358 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Adyen Checkout: Further CSS tweaks

https://gerrit.wikimedia.org/r/719358

jgleeson subscribed.EditedSep 7 2021, 9:32 PM

Hey @Damilare, so as mentioned on IRC here is what I'm seeing when testing your patch on mobile using Chrome under Android.

Ingenico - State select text height

Screenshot_20210907-222444_Chrome.jpg (2×972 px, 331 KB)

and

Adyen Checkout - State select text height

Screenshot_20210907-222432_Chrome.jpg (2×972 px, 423 KB)

Note: I'm pretty sure the Adyen Checkout cc field bug, no space between that and email, is unrelated to your patch.

jgleeson added a comment.Sep 7 2021, 9:43 PM
In T290105#7337928, @gerritbot wrote:

Change 719358 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Adyen Checkout: Further CSS tweaks

https://gerrit.wikimedia.org/r/719358

I've reverted that merged commit.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 10:11 PM
gerritbot added a comment.Sep 8 2021, 12:55 PM

Change 719514 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Adyen Checkout: Further CSS tweaks

https://gerrit.wikimedia.org/r/719514

gerritbot added a project: Patch-For-Review.Sep 8 2021, 12:55 PM
jgleeson moved this task from Backlog to Review on the fundraising sprint Quantum Leapfrog board.Sep 8 2021, 3:30 PM
gerritbot added a comment.Sep 8 2021, 5:04 PM

Change 719514 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Adyen Checkout: Further CSS tweaks

https://gerrit.wikimedia.org/r/719514

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2021, 5:10 PM
jgleeson moved this task from Review to Pending Deployment on the fundraising sprint Quantum Leapfrog board.Sep 13 2021, 1:14 PM
• DStrine added a project: fundraising sprint Roller Toaster.Sep 14 2021, 7:42 PM
jgleeson moved this task from Backlog to Done on the fundraising sprint Roller Toaster board.Sep 23 2021, 3:53 PM
XenoRyet closed this task as Resolved.Sep 28 2021, 7:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits