Remove Content::getDeletionUpdates
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Jun 28 2021, 11:53 PM

Description

Content::getDeletionUpdates was deprecated since 1.32 in favor of ContentHandler::getDeletionUpdates

However, 1 deployed extension still overrides it

Gadgets

After that, all usages of this method can be removed and the method itself can be removed.

This task is similar to T285729 and both can be worked on together.

Details

Subject	Repo	Branch	Lines +/-
Remove Content::getDeletionUpdates() and all usage of it.	mediawiki/core	master	+4 -106
Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.	mediawiki/extensions/Wikibase	master	+0 -25
Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.	mediawiki/extensions/Gadgets	master	+37 -28

Customize query in gerrit

Related Objects

Mentioned Here: T285729: Remove Content::getSecondaryDataUpdates

Event Timeline

• Pchelolo created this task.Jun 28 2021, 11:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2021, 11:53 PM

• Pchelolo updated the task description. (Show Details)Jun 29 2021, 12:02 AM

• Pchelolo moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.

roman-stolar moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Jul 15 2021, 12:03 PM

Change 704796 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Gadgets@master] Override ContentHandler::getDeletionUpdates to use it instead of Content::getDeletionUpdates.

https://gerrit.wikimedia.org/r/704796

gerritbot added a project: Patch-For-Review.Jul 15 2021, 2:41 PM

Krinkle added a project: MediaWiki-extensions-Gadgets.Jul 15 2021, 5:49 PM

Change 704796 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Override ContentHandler::getDeletionUpdates and ContentHandler::getSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/704796

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2021, 4:10 PM

roman-stolar updated the task description. (Show Details)Jul 19 2021, 11:42 AM

Change 705861 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Remove Content::getDeletionUpdates() and all usage of it.

https://gerrit.wikimedia.org/r/705861

gerritbot added a project: Patch-For-Review.Jul 21 2021, 11:29 AM

Change 705868 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Wikibase@master] Remove useless test EntityContentTestCase::testGetDeletionUpdates.

https://gerrit.wikimedia.org/r/705868

Change 705868 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove useless tests EntityContentTestCase::testGetDeletionUpdates & EntityContentTestCase::testGetSecondaryDataUpdates.

https://gerrit.wikimedia.org/r/705868

Change 705861 merged by jenkins-bot:

[mediawiki/core@master] Remove Content::getDeletionUpdates() and all usage of it.

https://gerrit.wikimedia.org/r/705861

• Pchelolo moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Jul 22 2021, 1:45 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 22 2021, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2021, 2:10 PM

• Pchelolo closed this task as Resolved.Aug 1 2021, 1:57 PM