undefined is not an object (evaluating 'context.state.filterValues[options.type].assessment')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

normalized_message

undefined is not an object (evaluating 'context.state.filterValues[options.type].assessment')

exception.trace

at search https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch&skin=minerva&version=17dg0:247:416
at https://commons.m.wikimedia.org/w/index.php?search=[search term]&title=Special:MediaSearch&type=image#/search:198:750
at https://commons.m.wikimedia.org/w/index.php?search=[search term]&title=Special:MediaSearch&type=image#/search:200:459
at getMoreResultsForTabIfAvailable https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch&skin=minerva&version=17dg0:205:758
at He https://commons.m.wikimedia.org/w/index.php?search=[search term]&title=Special:MediaSearch&type=image#/search:215:236
at He https://commons.m.wikimedia.org/w/index.php?search=[search term]&title=Special:MediaSearch&type=image#/search:215:236
at https://commons.m.wikimedia.org/w/index.php?search=[search term]&title=Special:MediaSearch&type=image#/search:238:240
at intersectionCallback https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch&skin=minerva&version=17dg0:191:199

Impact

No user-facing impact observed thus far

Notes

28 occurrences since yesterday post-train. May be a result of the switch from WMBI to MediaSearch.

Details

Request URL: https://commons.m.wikimedia.org/w/index.php?search=[search term]&title=Special:MediaSearch&type=image

	Subject	Repo	Branch	Lines +/-
	Solve issue when FilterValues.assessment is undefined	mediawiki/extensions/MediaSearch	master	+19 -7

Customize query in gerrit

Related Objects

Mentioned In: rEMED2278482ba032: Solve issue when FilterValues.assessment is undefined
T283843: [S] filterValues is not an Object. (evaluating 'filter in filterValues')

Event Timeline

AnneT created this task.Jun 10 2021, 5:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2021, 5:21 PM

AnneT updated the task description. (Show Details)Jun 10 2021, 5:25 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJun 10 2021, 5:25 PM

CBogen edited projects, added Structured-Data-Backlog; removed Structured-Data-Backlog (Current Work).Jun 11 2021, 2:09 PM

Krinkle updated the task description. (Show Details)Jun 11 2021, 4:53 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jun 14 2021, 4:29 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Jun 14 2021, 5:04 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Jun 21 2021, 5:02 PM

egardner merged a task: T285485: Undefined is not an object (evaluating 'context.state.filterValues[options.type].assessment').Jun 24 2021, 6:03 PM

I have not yet been able to reproduce this error, but here's what I know about it:

has been happening ~30x/day ever since June 9 (this was when the assessment feature went live after a config patch I believe).
all occurrences are on the mobile site
seems to be happening on general searches that don't have the assessment filter enabled

Still seems pretty low-impact. Even though I don't know *why* the value of context.state.filterValues[ options.type ] is undefined in these cases, one potential way to fix would be to update the conditional that checks for assessment to first ensure context.state.filterValues[ options.type ] is always an object. This should be the case already, because the filterValues state for each media type is stored in Vuex and can only be changed via the mutations we have defined (which add or remove keys from objects but never assign a different type of value)...

Just as a learning opportunity, I have also looked around the code to see how things are set and what could trigger the above message. (this was very helfup to see the syntax used and the data flow! :) )

As Eric said, the code is well defined, and I could not see any possible instanced that would mark the "filterValues" as undefined (the only way to trigger the above error).

SimoneThisDot mentioned this in T283843: [S] filterValues is not an Object. (evaluating 'filter in filterValues').Jul 8 2021, 8:58 AM

Krinkle moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jul 13 2021, 1:18 AM

Krinkle added a project: WikibaseMediaInfo.

SimoneThisDot claimed this task.Jul 13 2021, 1:15 PM

SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.

SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jul 14 2021, 7:52 AM

Change 704499 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Solve issue when FilterValues.assessment is undefined

https://gerrit.wikimedia.org/r/704499

gerritbot added a project: Patch-For-Review.Jul 14 2021, 7:52 AM

Change 704499 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Solve issue when FilterValues.assessment is undefined