@MMiller_WMF @nettrom_WMF FYI, this could affect any experiment analysis run on the tags data.

For the old suggested edit tasks, where it isn't really possible to tell suggested and non-suggested edits apart, because they are both normal edits, we tracked edits the user made to a page to which they arrived via the suggested edits system. Link recommendations inherited that. We ended up with a setup where we hook into the save process so we could probably tag edits reliably now.

An ugly but simple hack would be to add some kind of URL flag via ve.init.mw.ArticleTarget.saveFlags and detect that in the onRecentChange_save hook.

In T284217#7132316, @Tgr wrote:

For the old suggested edit tasks, where it isn't really possible to tell suggested and non-suggested edits apart, because they are both normal edits, we tracked edits the user made to a page to which they arrived via the suggested edits system. Link recommendations inherited that. We ended up with a setup where we hook into the save process so we could probably tag edits reliably now.

An ugly but simple hack would be to add some kind of URL flag via ve.init.mw.ArticleTarget.saveFlags and detect that in the onRecentChange_save hook.

I don't know how often it happens, but we would want to track non-VE suggested edits as well.

In T284217#7131578, @Urbanecm_WMF wrote:

@MMiller_WMF @nettrom_WMF FYI, this could affect any experiment analysis run on the tags data.

If I understand correctly, this is pretty rare. It occurs when the user has help panel disabled and interacts with the link recommendation suggestions, which would only be existing users (who are not part of the experiment group) or experiment group users who find their way to the preference and toggle it off (and those users could be excluded from analysis by looking to see if the help panel preference is enabled or not).

@Urbanecm_WMF @Tgr @kostajh -- if this is really all caused by users who edit the page outside the workflow, having arrived at the page via the "add a link" in recent history, then I think it's okay to leave it the way it is for now without implementing the ugly but simple hack. Those are edits that resulted from the existence of "add a link".

But what would the non-hack way of fixing this be?

Change 698783 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Prevent adding "add links" edit tag when edit is made external to interface

https://gerrit.wikimedia.org/r/698783

In T284217#7140732, @MMiller_WMF wrote:

@Urbanecm_WMF @Tgr @kostajh -- if this is really all caused by users who edit the page outside the workflow, having arrived at the page via the "add a link" in recent history, then I think it's okay to leave it the way it is for now without implementing the ugly but simple hack. Those are edits that resulted from the existence of "add a link".

But what would the non-hack way of fixing this be?

I took a different approach in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/698783, there's a bit longer explanation there but tl;dr we know when an edit is using add link interface via the VisualEditor post-save hook, and can check at that time if 1) the edit did not use "add link" interface but 2) we expected it to so that we can then 3) untrack it for the user so that "add links" tag isn't added later on in the request cycle.

Change 698783 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Prevent adding "add links" edit tag when edit is made external to interface

https://gerrit.wikimedia.org/r/698783

Checked on wmf.14 and also re-checked the test cases reported in T277518: Add Links: edits from VE/source editor tagged as Suggested: add links (for possible regressions) - any edits done outside of link recommendations surface won't have Suggested:add links tag.

A question to @MMiller_WMF (and @nettrom_WMF) re tracking newcomer tasks.

• Undoing Suggested: add links edits - Suggested: add links tag (and Newcomer task tag) won't be displayed), only Undo tag will be present. It might make it difficult to track down reverted edits.

unstructured tasks	link recommendation task

@Etonkovidova -- I think what you're saying sounds fine. Ideally, we only want the "Suggested: add links" tag on those edits that are really adding links through our workflow. But what I would expect to see is the "Reverted" tag on the first edit in your screenshots (since they were undone in the second edit). I wonder why that's not there?