Page MenuHomePhabricator
Create Task
Maniphest T284058

Vuex refactoring for Section Translation
Closed, ResolvedPublic
Actions

Description

As Section Translation improves and new features are developed, a refactoring can help the code to remain organized. This ticket focuses on refactoring code about state management which is supported by the Vuex library.

Details

SubjectRepoBranchLines +/-
CX3 Build 0.1.0+20211129mediawiki/extensions/ContentTranslationwmf/1.38.0-wmf.9+7 -7
CX3 Build 0.1.0+20211129mediawiki/extensions/ContentTranslationmaster+7 -7
SX: Refactor vuex translation functionalitymediawiki/extensions/ContentTranslationmaster+393 -463
SX: Move translateSegment action from mediawiki to translator modulemediawiki/extensions/ContentTranslationmaster+59 -66
SX: Move initializeDashboardContext vuex action to composablemediawiki/extensions/ContentTranslationmaster+268 -257
SX vuex mediawiki/fetchPageMetadata: Fix to really return a promisemediawiki/extensions/ContentTranslationmaster+22 -10
SX vuex application actions: Add selectPageSectionByIndex actionmediawiki/extensions/ContentTranslationmaster+63 -18
SX vuex application: Remove selectInitialTranslationSegment actionmediawiki/extensions/ContentTranslationmaster+16 -34
SX vuex store: Remove application/createNewSectionSuggestion actionmediawiki/extensions/ContentTranslationmaster+64 -39
SX vuex store cleanup: Remove mediawiki/getPageSection gettermediawiki/extensions/ContentTranslationmaster+14 -13
Customize query in gerrit

Event Timeline

Pginer-WMF created this task.Jun 1 2021, 11:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2021, 11:16 AM
Pginer-WMF triaged this task as Medium priority.Jun 1 2021, 11:17 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2021-April-June) board.
gerritbot added a comment.Jun 1 2021, 1:07 PM

Change 697596 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX vuex store cleanup: Remove mediawiki/getPageSection getter

https://gerrit.wikimedia.org/r/697596

gerritbot added a project: Patch-For-Review.Jun 1 2021, 1:07 PM
gerritbot added a comment.Jun 1 2021, 4:07 PM

Change 697620 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX vuex store: Remove application/createNewSectionSuggestion action

https://gerrit.wikimedia.org/r/697620

gerritbot added a comment.Jun 2 2021, 4:51 AM

Change 697596 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX vuex store cleanup: Remove mediawiki/getPageSection getter

https://gerrit.wikimedia.org/r/697596

gerritbot added a comment.Jun 2 2021, 4:58 AM

Change 697620 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX vuex store: Remove application/createNewSectionSuggestion action

https://gerrit.wikimedia.org/r/697620

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 2 2021, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 2 2021, 5:10 AM
ngkountas moved this task from Priority Backlog to In Progress on the Language-Team (Language-2021-April-June) board.Jun 3 2021, 11:35 AM
Pginer-WMF moved this task from Backlog to General infrastructure on the SectionTranslation board.Jun 4 2021, 12:24 PM
gerritbot added a comment.Jun 8 2021, 9:56 AM

Change 698725 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX vuex application: Remove selectInitialTranslationSegment action

https://gerrit.wikimedia.org/r/698725

gerritbot added a project: Patch-For-Review.Jun 8 2021, 9:56 AM

Change 698734 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX vuex application actions: Add selectPageSectionByIndex action

https://gerrit.wikimedia.org/r/698734

gerritbot added a comment.Jun 8 2021, 9:56 AM

Change 698741 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX vuex mediawiki/fetchPageMetadata: Fix to really return a promise

https://gerrit.wikimedia.org/r/698741

gerritbot added a comment.Jun 9 2021, 5:44 AM

Change 698725 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX vuex application: Remove selectInitialTranslationSegment action

https://gerrit.wikimedia.org/r/698725

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.11; 2021-06-21); removed MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 9 2021, 6:00 AM
gerritbot added a comment.Jun 9 2021, 11:56 AM

Change 698734 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX vuex application actions: Add selectPageSectionByIndex action

https://gerrit.wikimedia.org/r/698734

gerritbot added a comment.Jun 9 2021, 11:57 AM

Change 698741 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX vuex mediawiki/fetchPageMetadata: Fix to really return a promise

https://gerrit.wikimedia.org/r/698741

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2021, 12:11 PM
Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 8:18 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-July-September) board.
Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:32 PM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Oct 6 2021, 7:22 AM

Change 726758 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Move initializeDashboardContext vuex action to composable

https://gerrit.wikimedia.org/r/726758

gerritbot added a project: Patch-For-Review.Oct 6 2021, 7:22 AM
gerritbot added a comment.Oct 18 2021, 10:14 AM

Change 726758 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Move initializeDashboardContext vuex action to composable

https://gerrit.wikimedia.org/r/726758

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 11:11 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 18 2021, 3:00 PM
gerritbot added a comment.Nov 24 2021, 2:32 PM

Change 741683 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Move translateSegment action from mediawiki to translator module

https://gerrit.wikimedia.org/r/741683

gerritbot added a project: Patch-For-Review.Nov 24 2021, 2:32 PM
gerritbot added a comment.Nov 24 2021, 11:31 PM

Change 741741 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Refactor vuex translation functionality

https://gerrit.wikimedia.org/r/741741

gerritbot added a comment.Nov 25 2021, 9:58 AM

Change 741683 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Move translateSegment action from mediawiki to translator module

https://gerrit.wikimedia.org/r/741683

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Nov 25 2021, 10:00 AM
gerritbot added a comment.Nov 25 2021, 11:10 AM

Change 741741 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Refactor vuex translation functionality

https://gerrit.wikimedia.org/r/741741

gerritbot added a comment.Nov 29 2021, 6:36 AM

Change 742284 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

gerritbot added a comment.Nov 29 2021, 4:19 PM

Change 742284 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

gerritbot added a comment.Dec 1 2021, 3:04 AM

Change 742849 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

gerritbot added a comment.Dec 1 2021, 3:19 AM

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

Need to fix Merge Conflict first.

https://gerrit.wikimedia.org/r/742849

gerritbot added a comment.Dec 1 2021, 6:09 AM

Change 742849 restored by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

gerritbot added a comment.Dec 2 2021, 12:47 PM

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

https://gerrit.wikimedia.org/r/742849

Pginer-WMF edited projects, added Language-Team (Language-2022-January-March); removed Language-Team (Language-2021-October-December).Jan 10 2022, 3:23 PM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-January-March) board.
Pginer-WMF changed the task status from Open to In Progress.Jan 11 2022, 4:49 PM
Nikerabbit closed this task as Resolved.Feb 15 2022, 9:26 AM
Nikerabbit claimed this task.
Nikerabbit reassigned this task from Nikerabbit to ngkountas.
Nikerabbit moved this task from In Progress to Done on the Language-Team (Language-2022-January-March) board.
Nikerabbit subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits