Page MenuHomePhabricator

Add SVGO to Wikimedia deployed extensions
Closed, ResolvedPublic

Description

Derived from T278656, extensions with SVGs should make use of SVGO in our own configuration.

Extensions in need:

  • GrowthExperiments
  • Math
  • Thanks
  • TimedMediaHandler
  • Translate

Event Timeline

Change 692641 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GrowthExperiments@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692641

Change 692848 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Math@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692848

Change 692854 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Translate@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692854

Tgr triaged this task as Low priority.May 21 2021, 1:00 PM

Change 692641 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692641

Change 692854 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692854

I am not sure if is a good idea to add indention to math images. This will increase the size to be transferred via network connections.

@Physikerwelt You're most definitely right for math SVGs, The only change needed would be to set pretty: false on the repo's '.svgo.config.js'.

Change 692848 abandoned by VolkerE:

[mediawiki/extensions/Math@master] build: Add SVGO to latest v2.3.0 and re-crush SVGs

Reason:

It seems they are only used for testing.
Hence abandoning.

https://gerrit.wikimedia.org/r/692848

Etonkovidova subscribed.

Checked GrowthExperiments in wmf.9 - no regression issues have been found. @Volker_E - the task should be open for addressing Thanks and
TimedMediaHandler?

@Etonkovidova Thanks for your service! :)
Yes, correct. Task remains open with other two extensions to go.

Change 760544 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/TimedMediaHandler@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760544

Change 760568 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Thanks@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760568

Change 760568 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760568

Change 760544 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] build: Add SVGO latest v2.8.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/760544

Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.