Page MenuHomePhabricator
Create Task
Maniphest T281762

Incorporate librarized Metrics Platform PHP client into EventLogging
Closed, ResolvedPublic
Actions

Details

Other Assignee
• EChetty
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• jlinehan claimed this task.Oct 6 2021, 2:11 PM
• jlinehan subscribed.
• jlinehan moved this task from Ready/Groomed to Discussed on the Metrics Platform board.Nov 17 2021, 2:39 PM
• EChetty moved this task from Discussed to QA/Review on the Metrics Platform board.Dec 6 2021, 2:54 PM
• EChetty moved this task from QA/Review to Discussed on the Metrics Platform board.Dec 15 2021, 2:19 PM
• EChetty reassigned this task from • jlinehan to phuedx.Jan 24 2022, 1:26 PM
• EChetty moved this task from Discussed to To be prioritised on the Metrics Platform board.Jan 24 2022, 3:18 PM
phuedx moved this task from To be prioritised to Ready/Groomed on the Metrics Platform board.Feb 16 2022, 9:49 AM
phuedx moved this task from Ready/Groomed to Discussed on the Metrics Platform board.Mar 10 2022, 1:31 PM
gerritbot added a comment.Mar 23 2022, 3:45 PM

Change 773263 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP]: Validate stream configuration

https://gerrit.wikimedia.org/r/773263

gerritbot added a project: Patch-For-Review.Mar 23 2022, 3:45 PM
gerritbot added a comment.Mar 25 2022, 10:39 AM

Change 773753 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP] Add MetricsClient::dispatch()

https://gerrit.wikimedia.org/r/773753

• EChetty moved this task from Discussed to QA/Review on the Metrics Platform board.Mar 31 2022, 12:52 PM
gerritbot added a comment.Apr 4 2022, 10:12 AM

Change 776889 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP] Simplify Context- and CurationController

https://gerrit.wikimedia.org/r/776889

phuedx moved this task from QA/Review to To be prioritised on the Metrics Platform board.Apr 11 2022, 12:50 PM
gerritbot added a comment.Apr 12 2022, 12:48 AM

Change 773263 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP]: Validate stream configuration

https://gerrit.wikimedia.org/r/773263

gerritbot added a comment.Apr 13 2022, 11:05 PM

Change 776889 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP] Simplify Context- and CurationController

https://gerrit.wikimedia.org/r/776889

gerritbot added a comment.Apr 14 2022, 11:26 PM

Change 773753 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP] Add MetricsClient::dispatch()

https://gerrit.wikimedia.org/r/773753

phuedx moved this task from To be prioritised to Discussed on the Metrics Platform board.Apr 28 2022, 8:39 AM
• EChetty moved this task from Discussed to QA/Review on the Metrics Platform board.May 4 2022, 7:01 PM
• EChetty moved this task from QA/Review to Discussed on the Metrics Platform board.May 5 2022, 11:06 AM
gerritbot added a comment.May 12 2022, 9:41 AM

Change 791319 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] Integration wikimedia/metrics-platform v0.1.0

https://gerrit.wikimedia.org/r/791319

phuedx added a parent task: T299916: Validate the new stream configuration properties.May 13 2022, 8:59 AM
phuedx mentioned this in T299916: Validate the new stream configuration properties.May 13 2022, 10:27 AM
phuedx added a comment.EditedMay 19 2022, 8:39 AM

In order to properly integrate the PHP Metrics Platform client (the "client") (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/791319) the following changes need to be made:

  • MetricsClient should call \Psr\Log\LoggerInterface::warning() rather than ::error() throughout
  • Making StreamConfig\StreamConfigFactory::getStreamConfig() return a null implementation of StreamConfig (NullStreamConfig) when $rawStreamConfigs is falsy. Currently, ::getStreamConfig() returns null, which causes the client to fail silently
gerritbot added a comment.May 19 2022, 9:00 AM

Change 793411 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP] Fix StreamConfigFactory::getStreamConfig

https://gerrit.wikimedia.org/r/793411

gerritbot added a comment.May 19 2022, 9:00 AM

Change 793412 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP] ::error() -> ::warning()

https://gerrit.wikimedia.org/r/793412

phuedx moved this task from Discussed to QA/Review on the Metrics Platform board.May 19 2022, 9:01 AM
gerritbot added a comment.May 25 2022, 12:34 AM

Change 793411 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP] Fix StreamConfigFactory::getStreamConfig

https://gerrit.wikimedia.org/r/793411

gerritbot added a comment.May 25 2022, 12:35 AM

Change 793412 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP] ::error() -> ::warning()

https://gerrit.wikimedia.org/r/793412

phuedx closed subtask T281765: Publish librarized Metrics Platform PHP client to Packagist as Resolved.May 26 2022, 9:56 AM
phuedx moved this task from QA/Review to Discussed on the Metrics Platform board.May 30 2022, 3:39 PM
phuedx added a comment.May 30 2022, 3:59 PM
In T281762#7941021, @phuedx wrote:

In order to properly integrate the PHP Metrics Platform client (the "client") (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/791319) the following changes need to be made…

Done™

AFAIK the last step to get the tests passing in CI is to add wikimedia/metrics-platform as a dependency in the mediawiki/vendor repository. The process for doing so is well documented.

gerritbot added a comment.May 30 2022, 6:25 PM

Change 801418 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] \Wikimedia\Metrics -> \Wikimedia\MetricsPlatform

https://gerrit.wikimedia.org/r/801418

Krinkle closed subtask T309656: Performance review for new Metrics Plaform JS library as Resolved.May 31 2022, 8:41 PM
gerritbot added a comment.May 31 2022, 8:51 PM

Change 801418 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] \Wikimedia\Metrics -> \Wikimedia\MetricsPlatform

https://gerrit.wikimedia.org/r/801418

phuedx mentioned this in T309985: Migrate WikiEditor EditAttemptStep instrument to Metrics Platform.Jun 6 2022, 2:35 PM
phuedx added a parent task: T309985: Migrate WikiEditor EditAttemptStep instrument to Metrics Platform.
gerritbot added a comment.Jun 13 2022, 10:23 AM

Change 805093 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/vendor@master] WIP: Add wikimedia/metrics-platform 0.1.0

https://gerrit.wikimedia.org/r/805093

gerritbot added a comment.Jun 13 2022, 4:22 PM

Change 805199 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP] Require php >= 7.2.9

https://gerrit.wikimedia.org/r/805199

gerritbot added a comment.Jun 14 2022, 6:19 AM

Change 805199 merged by Phuedx:

[mediawiki/libs/metrics-platform@master] [PHP] Require php >= 7.2.9

https://gerrit.wikimedia.org/r/805199

• WDoranWMF moved this task from Discussed to QA/Review on the Metrics Platform board.Jun 21 2022, 12:25 PM
phuedx moved this task from QA/Review to To be prioritised on the Metrics Platform board.Jul 4 2022, 9:25 AM
phuedx moved this task from To be prioritised to QA/Review on the Metrics Platform board.Jul 26 2022, 2:20 PM
Krinkle closed subtask T311120: Performance review for new Metrics Platform PHP library as Resolved.Aug 15 2022, 3:02 PM
gerritbot added a comment.Aug 26 2022, 8:48 AM

Change 826794 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP]: Reduce Integration interface

https://gerrit.wikimedia.org/r/826794

gerritbot added a comment.Aug 31 2022, 11:10 PM

Change 826794 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP]: Reduce Integration interface

https://gerrit.wikimedia.org/r/826794

• EChetty updated Other Assignee, added: • EChetty.Sep 27 2022, 3:30 PM
• EChetty edited projects, added Event-Platform; removed Product-Data-Infrastructure.
• EChetty removed subscribers: • jlinehan, • Mholloway.
Restricted Application added a project: Data-Engineering. · View Herald TranscriptSep 27 2022, 3:30 PM
• EChetty removed a project: Event-Platform.Sep 27 2022, 3:31 PM
• EChetty moved this task from QA/Review to Metrics Platform Kanban on the Metrics Platform board.Oct 1 2022, 4:28 PM
• EChetty edited projects, added Metrics Platform (Metrics Platform Kanban); removed Metrics Platform.
• EChetty moved this task from Ready to In Review on the Metrics Platform (Metrics Platform Kanban) board.
• EChetty edited projects, added Data-Engineering-Planning; removed Data-Engineering.Oct 18 2022, 6:04 PM
• EChetty moved this task from In Review to In Progress on the Metrics Platform (Metrics Platform Kanban) board.Nov 3 2022, 1:52 PM
• EChetty removed a project: Data-Engineering-Planning.Nov 7 2022, 11:13 AM
phuedx moved this task from In Progress to In Review on the Metrics Platform (Metrics Platform Kanban) board.Nov 7 2022, 3:21 PM
• EChetty raised the priority of this task from Medium to High.Nov 10 2022, 6:36 PM
phuedx moved this task from In Review to In Progress on the Metrics Platform (Metrics Platform Kanban) board.Nov 15 2022, 5:21 PM
phuedx moved this task from In Progress to In Review on the Metrics Platform (Metrics Platform Kanban) board.Nov 22 2022, 5:26 PM
gerritbot added a comment.Nov 23 2022, 5:08 PM

Change 805093 merged by jenkins-bot:

[mediawiki/vendor@master] Add wikimedia/metrics-platform 1.0.0

https://gerrit.wikimedia.org/r/805093

gerritbot added a comment.Nov 29 2022, 4:44 PM

Change 861898 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP]: Make MetricsClient implement Psr\Log\LoggerAwareInterface

https://gerrit.wikimedia.org/r/861898

gerritbot added a comment.Dec 1 2022, 5:29 PM

Change 861898 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP]: Make MetricsClient implement Psr\Log\LoggerAwareInterface

https://gerrit.wikimedia.org/r/861898

phuedx moved this task from In Review to In Progress on the Metrics Platform (Metrics Platform Kanban) board.Jan 25 2023, 6:31 PM
gerritbot added a comment.Jan 25 2023, 6:45 PM

Change 883645 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/libs/metrics-platform@master] [PHP] Introduce EventSubmitter interface

https://gerrit.wikimedia.org/r/883645

gerritbot added a comment.Jan 27 2023, 12:59 PM

Change 884298 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] Extract UserBucketService service class

https://gerrit.wikimedia.org/r/884298

gerritbot added a comment.Jan 27 2023, 12:59 PM

Change 884299 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] Extract EventLogging.StreamConfigs service

https://gerrit.wikimedia.org/r/884299

gerritbot added a comment.Jan 27 2023, 12:59 PM

Change 884301 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] Integrate wikimedia/metrics-platform 1.0.0

https://gerrit.wikimedia.org/r/884301

gerritbot added a comment.Jan 27 2023, 4:00 PM

Change 884300 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] Extract EventSubmitter interface

https://gerrit.wikimedia.org/r/884300

gerritbot added a comment.Feb 1 2023, 11:32 AM

Change 884301 abandoned by Phuedx:

[mediawiki/extensions/EventLogging@master] Integrate wikimedia/metrics-platform 1.0.0

Reason:

See I8031af03a9f229fa7f7577344291647bff25635e

https://gerrit.wikimedia.org/r/884301

phuedx moved this task from In Progress to In Review on the Metrics Platform (Metrics Platform Kanban) board.Feb 1 2023, 11:37 AM
gerritbot added a comment.Feb 2 2023, 8:08 PM

Change 883645 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] [PHP] Introduce EventSubmitter interface

https://gerrit.wikimedia.org/r/883645

• EChetty moved this task from In Review to In Progress on the Metrics Platform (Metrics Platform Kanban) board.Feb 8 2023, 3:37 PM
gerritbot added a comment.Feb 9 2023, 11:18 PM

Change 884298 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Extract UserBucketService service class

https://gerrit.wikimedia.org/r/884298

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 10 2023, 12:00 AM
phuedx moved this task from In Progress to In Review on the Metrics Platform (Metrics Platform Kanban) board.Feb 10 2023, 1:27 PM
• EChetty mentioned this in T309013: EditAttemptStep Migration to (monoschema) MP.Feb 16 2023, 12:07 PM
gerritbot added a comment.Feb 23 2023, 7:23 PM

Change 884299 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Extract EventLogging.StreamConfigs service

https://gerrit.wikimedia.org/r/884299

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 23 2023, 8:00 PM
gerritbot added a comment.Feb 24 2023, 7:46 PM

Change 884300 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Extract EventSubmitter interface

https://gerrit.wikimedia.org/r/884300

phuedx added a subtask: T330459: Add wikidata_qid property to metrics_event schema.Mar 1 2023, 12:15 PM
phuedx edited subtasks, added: T330460: Fix context values in Java client to pass EventLogging validation; removed: T330459: Add wikidata_qid property to metrics_event schema.
phuedx added a subscriber: CCicalese_WMF.EditedMar 1 2023, 12:19 PM

Before https://gerrit.wikimedia.org/r/c/791319 can be merged, we need to:

  1. Rebase it
  2. Land the patch for T330460: Fix context values in Java client to pass EventLogging validation
  3. Tag a new version of the PHP MPC
  4. Update the version of the PHP MPC in mediawiki/vendor to the above

/cc @CCicalese_WMF

Edit

#2 is done. I'm testing the PHP MPC now.

Mayakp.wiki mentioned this in T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.Mar 3 2023, 7:48 PM
gerritbot added a comment.Mar 21 2023, 3:20 PM

Change 791319 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Integrate wikimedia/metrics-platform 2.0.0

https://gerrit.wikimedia.org/r/791319

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 3:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 21 2023, 4:00 PM
phuedx moved this task from In Review to Ready to Deploy on the Metrics Platform (Metrics Platform Kanban) board.Mar 22 2023, 10:31 AM
phuedx closed subtask T330460: Fix context values in Java client to pass EventLogging validation as Resolved.Mar 23 2023, 3:12 PM
phuedx moved this task from Ready to Deploy to Sign Off on the Metrics Platform (Metrics Platform Kanban) board.Apr 3 2023, 11:37 AM
phuedx closed this task as Resolved.Apr 19 2023, 12:20 PM

Being bold.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits