Page MenuHomePhabricator
Create Task
Maniphest T277513

Incorporate newcomer tasks configurations to Special:EditGrowthConfig
Closed, ResolvedPublic
Actions

Description

Background

In T274031: Provide custom editing interface for GrowthExperiments on-wiki configuration, a new Special:EditGrowthConfig special page will be introduced. In its initial version, the special page will only allow to edit configuration aspects that are not already a part of MediaWiki:NewcomerTasks.json, ie. it only allows to edit variables currently managed by global variables.

Scope of this task

Add an interface for maintaining stuff from MediaWiki:NewcomerTasks.json directly from Special:EditGrowthConfig.

Details

SubjectRepoBranchLines +/-
Incorporate MediaWiki:NewcomerTasks into Special:EditGrowthConfigmediawiki/extensions/GrowthExperimentsmaster+216 -9
Change validation in ConfigHooks to use ConfigValidatorFactorymediawiki/extensions/GrowthExperimentsmaster+152 -53
Create ConfigValidatorFactory to create the config validatorsmediawiki/extensions/GrowthExperimentsmaster+80 -41
Prepare Special:EditGrowthConfig for multiple config pagesmediawiki/extensions/GrowthExperimentsmaster+233 -133
Make WikiPageConfigWriterFactory determine the validator that will be usedmediawiki/extensions/GrowthExperimentsmaster+29 -40
Provide a common interface for config validatorsmediawiki/extensions/GrowthExperimentsmaster+82 -44
WikiPageConfigWriter should support more than just MediaWiki:GrowthExperimentsConfig.jsonmediawiki/extensions/GrowthExperimentsmaster+146 -33
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Mar 15 2021, 10:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2021, 10:08 PM
Urbanecm_WMF claimed this task.Apr 14 2021, 5:18 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

I'm starting to work on this.

Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptApr 14 2021, 5:18 PM
Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 14 2021, 5:19 PM
Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.
Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.
kostajh triaged this task as Medium priority.Apr 15 2021, 8:01 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:33 PM
gerritbot added a comment.May 1 2021, 2:55 PM

Change 684024 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WIP: Prepare Special:EditGrowthConfig for multiple config pages

https://gerrit.wikimedia.org/r/684024

gerritbot added a project: Patch-For-Review.May 1 2021, 2:55 PM
gerritbot added a comment.May 1 2021, 10:09 PM

Change 684044 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WIP: Incorporate MediaWiki:NewcomerTasks into Special:EditGrowthConfig

https://gerrit.wikimedia.org/r/684044

gerritbot added a comment.May 1 2021, 10:38 PM

Change 684049 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigWriter should support more than just MediaWiki:GrowthExperimentsConfig.json

https://gerrit.wikimedia.org/r/684049

gerritbot added a comment.May 2 2021, 1:45 PM

Change 684096 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Provide a common interface for config validators

https://gerrit.wikimedia.org/r/684096

gerritbot added a comment.May 2 2021, 4:04 PM

Change 684107 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Make WikiPageConfigWriterFactory determine the validator that will be used

https://gerrit.wikimedia.org/r/684107

gerritbot added a comment.May 2 2021, 4:19 PM

Change 684049 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigWriter should support more than just MediaWiki:GrowthExperimentsConfig.json

Reason:

not needed anymore

https://gerrit.wikimedia.org/r/684049

gerritbot added a comment.May 2 2021, 7:18 PM

Change 684096 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Provide a common interface for config validators

https://gerrit.wikimedia.org/r/684096

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 2 2021, 8:00 PM
gerritbot added a comment.May 3 2021, 5:00 PM

Change 684107 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Make WikiPageConfigWriterFactory determine the validator that will be used

Reason:

https://gerrit.wikimedia.org/r/684107

gerritbot added a comment.May 3 2021, 5:00 PM

Change 684471 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Create ConfigValidatorFactory to create the config validators

https://gerrit.wikimedia.org/r/684471

gerritbot added a comment.May 3 2021, 9:14 PM

Change 684024 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Prepare Special:EditGrowthConfig for multiple config pages

https://gerrit.wikimedia.org/r/684024

gerritbot added a comment.May 3 2021, 10:00 PM

Change 684471 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create ConfigValidatorFactory to create the config validators

https://gerrit.wikimedia.org/r/684471

gerritbot added a comment.May 3 2021, 11:16 PM

Change 684531 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Change validation in ConfigHooks to use ConfigvalidatorFactory

https://gerrit.wikimedia.org/r/684531

Urbanecm_WMF moved this task from Backlog to In progress on the User-Urbanecm_WMF (Engineering) board.May 4 2021, 2:06 PM
gerritbot added a comment.May 6 2021, 11:32 PM

Change 684531 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change validation in ConfigHooks to use ConfigValidatorFactory

https://gerrit.wikimedia.org/r/684531

gerritbot added a comment.May 6 2021, 11:56 PM

Change 684044 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Incorporate MediaWiki:NewcomerTasks into Special:EditGrowthConfig

https://gerrit.wikimedia.org/r/684044

Urbanecm_WMF moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 7 2021, 2:52 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 12 2021, 11:56 PM
Urbanecm_WMF removed a project: Patch-For-Review.May 14 2021, 2:02 PM
Urbanecm_WMF closed this task as Resolved.Jun 2 2021, 4:08 PM
Urbanecm_WMF added a project: GrowthExperiments-EditGrowthConfig.Aug 3 2021, 11:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits