Page MenuHomePhabricator
Create Task
Maniphest T275747

When transcluded page is deleted, parent page does not update
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to Reproduce:

Two translatable pages: Base Page, Child Page (Transcluded in Base Page)
Both pages are marked for translation.
Both pages are translated to the language - fr

  1. Load the Base Page/fr. You should see the Child Page/fr transcluded
  2. Delete Child Page/fr
  3. Refresh Base Page/fr

Actual Results:

Base Page/fr still shows the deleted Child Page/fr

Expected Results:

Base Page/fr still should show the source language (eg: Child Page/en)

Related to: T47096: Add a way to transclude template or other page in the correct language

Details

Other Assignee
Umherirrender
SubjectRepoBranchLines +/-
page: Run HTMLCacheUpdateJob on delete for pages transclude the pagemediawiki/coremaster+9 -2
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Feb 25 2021, 9:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2021, 9:35 AM
Nikerabbit triaged this task as Low priority.May 10 2021, 11:12 AM
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
gerritbot added a comment.Oct 31 2023, 7:52 PM

Change 969970 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] page: Run HTMLCacheUpdateJob on delete for pages transclude the page

https://gerrit.wikimedia.org/r/969970

gerritbot added a project: Patch-For-Review.Oct 31 2023, 7:52 PM
Umherirrender claimed this task.Oct 31 2023, 7:52 PM
Umherirrender edited projects, added MediaWiki-Page-deletion; removed MediaWiki-extensions-Translate.
Umherirrender added a comment.Oct 31 2023, 8:18 PM

The provided patch set only fixed the issue when the page transclusion is done via {{:Child page}} or otherwise tracked in the templatelinks table, not sure about the example here.

It seems the wikitext is {{:Child page{{#translation:}}}} with the parser function provided by the translate extension, that should work after merge.

Krinkle added a project: MediaWiki-Core-HTTP-Cache.Nov 17 2023, 12:21 AM
Krinkle added a project: MediaWiki-Platform-Team (Radar).
gerritbot added a comment.Nov 17 2023, 12:38 AM

Change 969970 merged by jenkins-bot:

[mediawiki/core@master] page: Run HTMLCacheUpdateJob on delete for pages transclude the page

https://gerrit.wikimedia.org/r/969970

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2023, 1:10 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 17 2023, 2:00 AM
Umherirrender removed Umherirrender as the assignee of this task.Nov 17 2023, 2:13 PM
Umherirrender subscribed.

Not sure if this should be retested in the context of MediaWiki-extensions-Translate or can be seen as fixed.

abi_ claimed this task.Nov 20 2023, 9:50 AM
abi_ added projects: Language-Team (Language-2023-October-December), Localization Infrastructure FY2023-24.
abi_ set the point value for this task to 2.

I'll test this

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-October-December) board.Nov 20 2023, 9:51 AM
abi_ changed the task status from Open to In Progress.Nov 20 2023, 10:26 AM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-October-December) board.
abi_ updated Other Assignee, added: abi_.

Appears to work well. I'll test this on translatewiki.net before resolving.

abi_ removed abi_ as the assignee of this task.Nov 20 2023, 10:26 AM
Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.Nov 21 2023, 8:39 AM
abi_ claimed this task.Nov 23 2023, 12:23 PM
abi_ updated Other Assignee, added: Umherirrender; removed: abi_.
abi_ closed this task as Resolved.Nov 23 2023, 2:41 PM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-October-December) board.

Tested on translatewiki.net. Marking as resolved.

Nikerabbit added a project: Unplanned-Sprint-Work.Dec 5 2023, 8:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits