Page MenuHomePhabricator
Create Task
Maniphest T270450

User::isLoggedIn() is confusing
Closed, ResolvedPublic
Actions

Description

/**
 * Get whether the user is logged in
 * @return bool
 */
public function isLoggedIn() {
        return $this->isRegistered();
}

isLoggedIn being the same as isRegistered does not make any sense semantically; it dates from when a User object was only part of the current request, rather than a real object that can occur in other circumstances.

Details

SubjectRepoBranchLines +/-
User::isLogged was removed, replaced with isRegisteredmediawiki/skins/BlueSkymaster+0 -0
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/DisplayTitleREL1_36+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/DisplayTitleREL1_35+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/URNamesmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OnlineStatusBarmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Commentboxmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OfflineImportLexiconmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/JsonDatamaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/ContributionScoresmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/ConfirmAccountmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/CollapsibleVectormaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BreadCrumbs2master+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/AccountInfomaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/AutoCreateCategoryPagesmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/TwitterLoginmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/PageFormsmaster+5 -11
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/HSTSmaster+4 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/ImportFreeImagesmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Inboxmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/MultiLanguageManagermaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/NetworkAuthmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/NewUserActionsmaster+4 -1
User: Hard-deprecate the confusingly-named isLoggedIn() methodmediawiki/coremaster+7 -0
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/DisplayTitlemaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OpenIDmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Favoritesmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OnlineStatusmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/PronunciationRecordingmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SecureSessionsmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SkinPerNamespacemaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SocialLoginmaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SSLClientAuthenticationmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Surveymaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/TwnMainPagemaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WebChatmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Metrolookmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Ponchomaster+5 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BlueSpicePageAssignmentsmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BlueSpiceDashboardsmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BlueSpiceRemindermaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BlueSpicePrivacymaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BlueSpiceExpirymaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BlueSpiceExtendedSearchmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/BlueSpiceCalummamaster+10 -10
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/EditSubpagesmaster+4 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/CreateAPagemaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SportsTeamsmaster+20 -20
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/FanBoxesmaster+9 -9
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Commentsmaster+5 -5
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/MiniInvitemaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/PollNYmaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/QuizGamemaster+8 -8
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/UserStatusmaster+8 -8
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Challengemaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/EditSimilarmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/PictureGamemaster+13 -13
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikiForummaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/LinkFiltermaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OOJsUIAjaxLoginmaster+4 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Draftsmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/NewsBoxmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Tempomaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Nimbusmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Anisamaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikiTextLoggedInOutmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/VoteNYmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/PrivateDomainsmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SocialProfilemaster+27 -27
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/StickToThatLanguagemaster+1 -1
Swap out uses of User->isLoggedIn() with ->isRegistered()mediawiki/coremaster+133 -133
Follow-up 8632bf030: Missed onemediawiki/extensions/MobileFrontendmaster+1 -1
User: Deprecate confusingly-named isLoggedIn() methodmediawiki/coreREL1_35+5 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Vectormaster+9 -9
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/UniversalLanguageSelectormaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Wikibasemaster+5 -5
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/GlobalWatchlistmaster+5 -5
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/NewUserMessagemaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/DismissableSiteNoticemaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Translatemaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/VisualEditormaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/GlobalCssJsmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/LdapAuthenticationmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/ContactPagemaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/MobileFrontendmaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/GrowthExperimentsmaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/ContentTranslationmaster+5 -5
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Flowmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/LoginNotifymaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/BetaFeaturesmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/CentralNoticemaster+5 -5
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/MinervaNeuemaster+9 -9
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Echomaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Newslettermaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/CentralAuthmaster+6 -6
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/AbuseFiltermaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OAuthmaster+4 -4
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Thanksmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/Collectionmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/PageTriagemaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/SecurePollmaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikimediaMaintenancemaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikimediaMessagesmaster+3 -3
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/FlaggedRevsmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/MultimediaViewermaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikimediaEventsmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/OpenStackManagermaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikiLovemaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WebAuthnmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/extensions/WikimediaIncubatormaster+2 -2
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Nostalgiamaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/WikimediaApiPortalmaster+1 -1
Use User->isRegistered(), not deprecated isLoggedIn()mediawiki/skins/Timelessmaster+1 -1
User: Deprecate confusingly-named isLoggedIn() methodmediawiki/coremaster+5 -1
Show related patches Customize query in gerrit

Related Objects

Mentioned In
rSPIVcfee790ea755: isLogged in was removed in favor of isRegistered
rEDPT639a04ef89c0: Use User->isRegistered(), not deprecated isLoggedIn()
rEDPTaaa88bc19cdc: Use User->isRegistered(), not deprecated isLoggedIn()
rEOILa03782b5f79e: Use User->isRegistered(), not deprecated isLoggedIn()
rENAUf966a3a0e3e9: Use User->isRegistered(), not deprecated isLoggedIn()
rECNSbb3429ecffd7: Use User->isRegistered(), not deprecated isLoggedIn()
rEACP19452131d94c: Use User->isRegistered(), not deprecated isLoggedIn()
rECAC96439acd49e5: Use User->isRegistered(), not deprecated isLoggedIn()
rENUACb000125d5442: Use User->isRegistered(), not deprecated isLoggedIn()
rEIBXbe6413f7b9d9: Use User->isRegistered(), not deprecated isLoggedIn()
rEDPT12c445d758cf: Use User->isRegistered(), not deprecated isLoggedIn()
rEPRRdd1b668f8a6f: Use User->isRegistered(), not deprecated isLoggedIn()
rMSPOd9842623781c: Use User->isRegistered(), not deprecated isLoggedIn()
rEBUFb0afe78749af: Use User->isRegistered(), not deprecated isLoggedIn()
rEBSESdce991efde9e: Use User->isRegistered(), not deprecated isLoggedIn()
rEBUC4aae71d6a608: Use User->isRegistered(), not deprecated isLoggedIn()
rEBUHdda8f6165492: Use User->isRegistered(), not deprecated isLoggedIn()
rMSBCa8440481d5b1: Use User->isRegistered(), not deprecated isLoggedIn()
rEBTDd8ed31fa735d: Use User->isRegistered(), not deprecated isLoggedIn()
rEOAL842a51ada7f5: Use User->isRegistered(), not deprecated isLoggedIn()
rEPGA852654d5ace9: Use User->isRegistered(), not deprecated isLoggedIn()
rECPG5fa8c81e03a2: Use User->isRegistered(), not deprecated isLoggedIn()
rEPRDbfe1aaacc153: Use User->isRegistered(), not deprecated isLoggedIn()
rENBX0be1cc468a89: Use User->isRegistered(), not deprecated isLoggedIn()
rSANIfa6646a8a45e: Use User->isRegistered(), not deprecated isLoggedIn()
rESPR726a4e9e34b3: Use User->isRegistered(), not deprecated isLoggedIn()
rEGLWf6e5c240ffb0: Use User->isRegistered(), not deprecated isLoggedIn()
rECPAa447576202f7: Use User->isRegistered(), not deprecated isLoggedIn()
rEWAT6d2024f17f14: Use User->isRegistered(), not deprecated isLoggedIn()
Mentioned Here
rEMFR8632bf0305e0: Use User->isRegistered(), not deprecated isLoggedIn()
rMW388d95d7b8a5: De-cruftification continues. * Replacing Namespace:: functions with NS_…
rMWf7201e3b9b81: Convert WatchedItem and friends to UserIdentity

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.May 7 2021, 8:46 AM

Change 685929 merged by jenkins-bot:

[mediawiki/skins/Anisa@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685929

gerritbot added a comment.May 7 2021, 8:46 AM

Change 685931 merged by jenkins-bot:

[mediawiki/skins/Nimbus@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685931

gerritbot added a comment.May 7 2021, 8:46 AM

Change 685934 merged by jenkins-bot:

[mediawiki/skins/Tempo@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685934

gerritbot added a comment.May 7 2021, 8:46 AM

Change 685858 merged by jenkins-bot:

[mediawiki/extensions/NewsBox@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685858

gerritbot added a comment.May 7 2021, 8:46 AM

Change 685841 merged by jenkins-bot:

[mediawiki/extensions/Drafts@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685841

Zabe mentioned this in rESPR726a4e9e34b3: Use User->isRegistered(), not deprecated isLoggedIn().May 7 2021, 8:47 AM
Zabe mentioned this in rSANIfa6646a8a45e: Use User->isRegistered(), not deprecated isLoggedIn().May 7 2021, 8:49 AM
Zabe mentioned this in rENBX0be1cc468a89: Use User->isRegistered(), not deprecated isLoggedIn().May 7 2021, 8:52 AM
Zabe mentioned this in rEPRDbfe1aaacc153: Use User->isRegistered(), not deprecated isLoggedIn().
gerritbot added a comment.May 7 2021, 8:57 AM

Change 685854 merged by jenkins-bot:

[mediawiki/extensions/LinkFilter@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685854

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685818 merged by jenkins-bot:

[mediawiki/extensions/WikiForum@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685818

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685815 merged by jenkins-bot:

[mediawiki/extensions/PictureGame@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685815

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685803 merged by jenkins-bot:

[mediawiki/extensions/EditSimilar@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685803

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685801 merged by jenkins-bot:

[mediawiki/extensions/Challenge@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685801

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685781 merged by jenkins-bot:

[mediawiki/extensions/UserStatus@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685781

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685780 merged by jenkins-bot:

[mediawiki/extensions/QuizGame@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685780

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685777 merged by jenkins-bot:

[mediawiki/extensions/PollNY@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685777

gerritbot added a comment.May 7 2021, 8:57 AM

Change 685769 merged by jenkins-bot:

[mediawiki/extensions/MiniInvite@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685769

gerritbot added a comment.May 7 2021, 8:58 AM

Change 685767 merged by jenkins-bot:

[mediawiki/extensions/Comments@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685767

gerritbot added a comment.May 7 2021, 8:58 AM

Change 685764 merged by jenkins-bot:

[mediawiki/extensions/FanBoxes@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685764

gerritbot added a comment.May 7 2021, 8:58 AM

Change 685761 merged by jenkins-bot:

[mediawiki/extensions/SportsTeams@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685761

gerritbot added a comment.May 7 2021, 9:00 AM

Change 685768 merged by Jack Phoenix:

[mediawiki/extensions/CreateAPage@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685768

Zabe mentioned this in rECPG5fa8c81e03a2: Use User->isRegistered(), not deprecated isLoggedIn().May 7 2021, 9:03 AM
Zabe mentioned this in rEPGA852654d5ace9: Use User->isRegistered(), not deprecated isLoggedIn().May 7 2021, 9:12 AM
Zabe mentioned this in rEOAL842a51ada7f5: Use User->isRegistered(), not deprecated isLoggedIn().May 7 2021, 10:10 AM
gerritbot added a comment.May 7 2021, 4:46 PM

Change 685844 merged by jenkins-bot:

[mediawiki/extensions/EditSubpages@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685844

Zabe added a comment.May 9 2021, 12:39 PM
In T270450#6708423, @Jdforrester-WMF wrote:

We're technically ready to hard-deprecate; is this too soon, do people feel?

I have now uploaded patches for all remaining repositories, so I think we can proceed with the hard-deprecation.

gerritbot added a comment.May 10 2021, 6:49 AM

Change 685763 merged by jenkins-bot:

[mediawiki/skins/BlueSpiceCalumma@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685763

gerritbot added a comment.May 10 2021, 6:50 AM

Change 685765 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685765

gerritbot added a comment.May 10 2021, 6:50 AM

Change 685791 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExpiry@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685791

gerritbot added a comment.May 10 2021, 6:50 AM

Change 685793 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePrivacy@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685793

gerritbot added a comment.May 10 2021, 6:50 AM

Change 685798 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceReminder@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685798

gerritbot added a comment.May 10 2021, 6:50 AM

Change 685829 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceDashboards@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685829

gerritbot added a comment.May 10 2021, 6:50 AM

Change 685830 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePageAssignments@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685830

Zabe mentioned this in rEBTDd8ed31fa735d: Use User->isRegistered(), not deprecated isLoggedIn().May 10 2021, 6:51 AM
Zabe mentioned this in rEBUHdda8f6165492: Use User->isRegistered(), not deprecated isLoggedIn().
Zabe mentioned this in rMSBCa8440481d5b1: Use User->isRegistered(), not deprecated isLoggedIn().
Zabe mentioned this in rEBUC4aae71d6a608: Use User->isRegistered(), not deprecated isLoggedIn().
Zabe mentioned this in rEBSESdce991efde9e: Use User->isRegistered(), not deprecated isLoggedIn().May 10 2021, 6:53 AM
Zabe mentioned this in rEBUFb0afe78749af: Use User->isRegistered(), not deprecated isLoggedIn().
gerritbot added a comment.May 10 2021, 8:08 AM

Change 685932 merged by jenkins-bot:

[mediawiki/skins/Poncho@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685932

gerritbot added a comment.May 10 2021, 8:08 AM

Change 685930 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685930

gerritbot added a comment.May 10 2021, 8:08 AM

Change 685926 merged by jenkins-bot:

[mediawiki/extensions/WebChat@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685926

gerritbot added a comment.May 10 2021, 8:08 AM

Change 685922 merged by jenkins-bot:

[mediawiki/extensions/TwnMainPage@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685922

gerritbot added a comment.May 10 2021, 8:09 AM

Change 685918 merged by jenkins-bot:

[mediawiki/extensions/Survey@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685918

gerritbot added a comment.May 10 2021, 8:09 AM

Change 685916 merged by jenkins-bot:

[mediawiki/extensions/SSLClientAuthentication@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685916

gerritbot added a comment.May 10 2021, 8:09 AM

Change 685874 merged by jenkins-bot:

[mediawiki/extensions/SocialLogin@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685874

gerritbot added a comment.May 10 2021, 8:09 AM

Change 685872 merged by jenkins-bot:

[mediawiki/extensions/SkinPerNamespace@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685872

gerritbot added a comment.May 10 2021, 8:13 AM

Change 685870 merged by jenkins-bot:

[mediawiki/extensions/SecureSessions@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685870

gerritbot added a comment.May 10 2021, 8:13 AM

Change 685868 merged by jenkins-bot:

[mediawiki/extensions/PronunciationRecording@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685868

gerritbot added a comment.May 10 2021, 8:13 AM

Change 685862 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatus@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685862

gerritbot added a comment.May 10 2021, 8:13 AM

Change 685806 merged by jenkins-bot:

[mediawiki/extensions/Favorites@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685806

gerritbot added a comment.May 10 2021, 8:13 AM

Change 685808 merged by jenkins-bot:

[mediawiki/extensions/OpenID@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685808

Zabe mentioned this in rMSPOd9842623781c: Use User->isRegistered(), not deprecated isLoggedIn().May 10 2021, 8:19 AM
Zabe mentioned this in rEPRRdd1b668f8a6f: Use User->isRegistered(), not deprecated isLoggedIn().May 10 2021, 8:37 AM
gerritbot added a comment.May 10 2021, 3:16 PM

Change 685839 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685839

Zabe mentioned this in rEDPT12c445d758cf: Use User->isRegistered(), not deprecated isLoggedIn().May 10 2021, 3:19 PM
gerritbot added a comment.May 10 2021, 4:52 PM

Change 651677 merged by jenkins-bot:

[mediawiki/core@master] User: Hard-deprecate the confusingly-named isLoggedIn() method

https://gerrit.wikimedia.org/r/651677

gerritbot added a comment.May 11 2021, 12:27 PM

Change 685859 merged by jenkins-bot:

[mediawiki/extensions/NewUserActions@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685859

gerritbot added a comment.May 11 2021, 12:27 PM

Change 685857 merged by jenkins-bot:

[mediawiki/extensions/NetworkAuth@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685857

gerritbot added a comment.May 11 2021, 12:27 PM

Change 685856 merged by jenkins-bot:

[mediawiki/extensions/MultiLanguageManager@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685856

gerritbot added a comment.May 11 2021, 12:27 PM

Change 685848 merged by jenkins-bot:

[mediawiki/extensions/Inbox@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685848

gerritbot added a comment.May 11 2021, 12:27 PM

Change 685846 merged by jenkins-bot:

[mediawiki/extensions/ImportFreeImages@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685846

gerritbot added a comment.May 11 2021, 12:28 PM

Change 685845 merged by jenkins-bot:

[mediawiki/extensions/HSTS@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685845

Zabe mentioned this in rEIBXbe6413f7b9d9: Use User->isRegistered(), not deprecated isLoggedIn().May 11 2021, 12:28 PM
Zabe updated the task description. (Show Details)May 11 2021, 12:35 PM
Zabe mentioned this in rENUACb000125d5442: Use User->isRegistered(), not deprecated isLoggedIn().May 11 2021, 12:53 PM
gerritbot added a comment.May 11 2021, 1:46 PM

Change 685809 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageForms@master] Use User->isRegistered(), not deprecated isLoggedIn()

Reason:

Obsolete via I66b50d5f632872543376aee2a849122ede9966b4.

https://gerrit.wikimedia.org/r/685809

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685816 merged by jenkins-bot:

[mediawiki/extensions/TwitterLogin@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685816

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685828 merged by jenkins-bot:

[mediawiki/extensions/AutoCreateCategoryPages@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685828

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685827 merged by jenkins-bot:

[mediawiki/extensions/AccountInfo@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685827

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685832 merged by jenkins-bot:

[mediawiki/extensions/BreadCrumbs2@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685832

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685833 merged by jenkins-bot:

[mediawiki/extensions/CollapsibleVector@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685833

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685834 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685834

gerritbot added a comment.May 11 2021, 2:08 PM

Change 685838 merged by jenkins-bot:

[mediawiki/extensions/ContributionScores@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685838

Zabe mentioned this in rECAC96439acd49e5: Use User->isRegistered(), not deprecated isLoggedIn().May 11 2021, 2:08 PM
Zabe mentioned this in rEACP19452131d94c: Use User->isRegistered(), not deprecated isLoggedIn().
Zabe mentioned this in rECNSbb3429ecffd7: Use User->isRegistered(), not deprecated isLoggedIn().May 11 2021, 2:13 PM
Zabe mentioned this in rENAUf966a3a0e3e9: Use User->isRegistered(), not deprecated isLoggedIn().May 11 2021, 2:31 PM
gerritbot added a comment.May 13 2021, 5:02 PM

Change 685850 merged by Umherirrender:

[mediawiki/extensions/JsonData@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685850

gerritbot added a comment.May 13 2021, 5:05 PM

Change 685861 merged by jenkins-bot:

[mediawiki/extensions/OfflineImportLexicon@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685861

gerritbot added a comment.May 13 2021, 5:05 PM

Change 685802 merged by jenkins-bot:

[mediawiki/extensions/Commentbox@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685802

Zabe mentioned this in rEOILa03782b5f79e: Use User->isRegistered(), not deprecated isLoggedIn().May 13 2021, 5:07 PM
gerritbot added a comment.May 13 2021, 5:07 PM

Change 685863 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatusBar@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685863

gerritbot added a comment.May 13 2021, 5:09 PM

Change 685924 merged by jenkins-bot:

[mediawiki/extensions/URNames@master] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/685924

Zabe removed a project: Patch-For-Review.Aug 14 2021, 12:40 PM
Zabe added a comment.Nov 24 2021, 11:50 AM

Got removed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/740096.

Zabe closed this task as Resolved.Nov 24 2021, 11:50 AM
Zabe updated the task description. (Show Details)
gerritbot added a comment.Dec 24 2021, 4:16 PM

Change 749776 had a related patch set uploaded (by Cicalese; author: ZabeMath):

[mediawiki/extensions/DisplayTitle@REL1_35] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/749776

gerritbot added a project: Patch-For-Review.Dec 24 2021, 4:16 PM

Change 749777 had a related patch set uploaded (by Cicalese; author: ZabeMath):

[mediawiki/extensions/DisplayTitle@REL1_36] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/749777

gerritbot added a comment.Dec 24 2021, 4:26 PM

Change 749776 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_35] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/749776

gerritbot added a comment.Dec 24 2021, 4:26 PM

Change 749777 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_36] Use User->isRegistered(), not deprecated isLoggedIn()

https://gerrit.wikimedia.org/r/749777

CCicalese_WMF mentioned this in rEDPTaaa88bc19cdc: Use User->isRegistered(), not deprecated isLoggedIn().Dec 24 2021, 4:26 PM
CCicalese_WMF mentioned this in rEDPT639a04ef89c0: Use User->isRegistered(), not deprecated isLoggedIn().
gerritbot added a comment.Jun 10 2022, 6:58 PM

Change 804624 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/BlueSky@master] User::isLogged was removed, replaced with isRegistered

https://gerrit.wikimedia.org/r/804624

gerritbot added a comment.Jun 10 2022, 8:23 PM

Change 804624 abandoned by Jforrester:

[mediawiki/skins/BlueSky@master] User::isLogged was removed, replaced with isRegistered

Reason:

Done in I9112002a700d3b0a9e9de53b778ff2b3f4ff555d.

https://gerrit.wikimedia.org/r/804624

Jdlrobson mentioned this in rSPIVcfee790ea755: isLogged in was removed in favor of isRegistered.Aug 15 2022, 8:00 AM
valerio.bozzolan subscribed.Dec 16 2022, 9:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits