VisualEditor Uri exception breaks display of CentralNotice banners
Closed, ResolvedPublic
Actions

Description

Visit https://hi.wikipedia.org/wiki/%E0%A4%AE%E0%A5%88%E0%A4%B0%E0%A4%BE%E0%A4%A5%E0%A4%A8#During_the_last_two_or_three_weeks_before_the_marathon,_runners_will_typically_reduce_their_weekly_training,_gradually,_by_as_much_as_50%-75%_of_previous_peak_volume,_and_take_at_least_a_couple_of_days_of_complete_rest_to_allow_their_bodies_to_recover_from_any_strong_effort._The_last_long_training_run_might_be_undertaken_no_later_than_two_weeks_prior_to_the_event._This_is_a_phase_of_training_known_as_tapering._Many_marathon_runners_also_%22carbo-load%22_(increase_carbohydrate_intake_while_holding_total_caloric_intake_constant)_during_the_week_before_the_marathon_to_allow_their_bodies_to_store_more_glycogen.

An "Exception in module-execute in module ext.visualEditor.desktopArticleTarget.init:" error is thrown. This also propagates to ext.centralNotice.startUp meaning banners will not show (see T269948#6693286)

Also occurs on https://no.wikipedia.org/w/index.php?oldid=prev&diff=20998556&title=Uformelt%20spr%E5k

Example: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.12.16/clienterror/?id=AXZqoI1Ia1L68BhcI2k4

Details

	Subject	Repo	Branch	Lines +/-
	Try/catch Uri creation	mediawiki/extensions/VisualEditor	master	+9 -2

Customize query in gerrit

Related Objects

Mentioned In: T325249: Replace use of mw.Uri in VE with native URL API
Mentioned Here: T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash
T269948: CentralNotice throws exception on malformed URIs

Event Timeline

Jdlrobson created this task.Dec 16 2020, 6:25 PM

Restricted Application added subscribers: jeblad, Danmichaelo, Aklapper. · View Herald TranscriptDec 16 2020, 6:25 PM

Change 649468 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/VisualEditor@master] Try/catch Uri creation

https://gerrit.wikimedia.org/r/649468

gerritbot added a project: Patch-For-Review.Dec 16 2020, 6:25 PM

Jdlrobson renamed this task from VisualEditor breaking display of CentralNotice banners to VisualEditor Uri exception breaks display of CentralNotice banners.Dec 16 2020, 6:26 PM

Jdlrobson updated the task description. (Show Details)

thcipriani added a project: MediaWiki-extensions-CentralNotice.Dec 16 2020, 7:47 PM

thcipriani moved this task from Untriaged to Dec 2020 on the Wikimedia-production-error board.

AndyRussG added a project: Fundraising-Backlog.Dec 17 2020, 1:17 AM

AndyRussG subscribed.

• DStrine moved this task from Triage to Blocked or not fr-tech on the Fundraising-Backlog board.Dec 17 2020, 4:54 PM

Change 649468 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Try/catch Uri creation

https://gerrit.wikimedia.org/r/649468

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 5 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2021, 9:10 PM

ppelberg closed this task as Resolved.Jan 12 2021, 4:37 PM

ppelberg claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 12 2021, 4:37 PM

(the root cause of this is T106244)

matmarex mentioned this in T325249: Replace use of mw.Uri in VE with native URL API.Dec 14 2022, 10:11 PM

VisualEditor Uri exception breaks display of CentralNotice bannersClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

VisualEditor Uri exception breaks display of CentralNotice banners
Closed, ResolvedPublic
Actions