OAuth extension - unused variable in SpecialMWOAuthManageMyGrants.php
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To

Authored By

	Art.tsymbar
	Oct 10 2020, 11:29 AM

Description

There is an unused variable: $lang = $this->getLanguage() in the handleConsumerForm() method of the SpecialMWOAuthManageMyGrants class of the OAuth ext.
Is to be removed.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialMWOAuthManageMyGrants: unused variable	mediawiki/extensions/OAuth	master	+0 -1

Customize query in gerrit

Event Timeline

Art.tsymbar created this task.Oct 10 2020, 11:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2020, 11:29 AM

Art.tsymbar set the point value for this task to 0.5.Oct 10 2020, 11:31 AM

Art.tsymbar reassigned this task from Art.tsymbar to Vlad.shapik.Oct 12 2020, 8:15 AM

Vlad.shapik moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Oct 16 2020, 9:06 AM

Change 634483 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/OAuth@master] SpecialMWOAuthManageMyGrants: unused variable

https://gerrit.wikimedia.org/r/634483

gerritbot added a project: Patch-For-Review.Oct 16 2020, 10:13 AM

Change 634483 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] SpecialMWOAuthManageMyGrants: unused variable

https://gerrit.wikimedia.org/r/634483

Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 16 2020, 3:14 PM

Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 16 2020, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 4:10 PM

Reedy closed this task as Resolved.Oct 25 2020, 8:31 PM