Page MenuHomePhabricator
Create Task
Maniphest T259960

Inject services into API modules and special pages
Open, LowPublic
Actions

Description

Since T222388 it has been possible to inject services into API modules and special pages.

Some SpecialPages in core now do this: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/58b7003abb72d4c042164ad7e2262c6a8e4f0f9a/includes/specialpage/SpecialPageFactory.php#69

API modules in core don't seem to do it yet: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/58b7003abb72d4c042164ad7e2262c6a8e4f0f9a/includes/api/ApiMain.php#61

SpecialPage and ApiBase access the service container directly.

There are discussions happening in code reviews on individual patches about whether (or when) we should be injecting services in core API modules and special pages. It would be good to have some guidance so we can resolve these conversations consistently.

Details

SubjectRepoBranchLines +/-
Simplify special pages now that GlobalUsage no longer extends themmediawiki/coremaster+13 -23
Simplify ApiUserrights now that CentralAuth no longer extends itmediawiki/coremaster+10 -80
api: Inject services into ApiQuery classmediawiki/coremaster+40 -16
SpecialMovePage: stop falling back to global statemediawiki/coremaster+33 -36
API: Change object specs for remaining un-serviced API modulesmediawiki/coremaster+118 -39
api: Inject services into ApiQueryContributorsmediawiki/coremaster+40 -7
api: Inject services into ApiWatchlistTraitmediawiki/coremaster+166 -33
api: Inject services into ApiQuery(All)(Deleted)Revisionsmediawiki/coremaster+277 -62
api: Inject services into ApiQueryFileRepoInfomediawiki/coremaster+24 -18
api: Inject services into ApiUpload classmediawiki/coremaster+23 -5
api: Use injected services in ApiQuerySearchmediawiki/coremaster+10 -9
api: Inject services into ApiQueryImageInfo/ApiQueryStashImageInfomediawiki/coremaster+94 -20
api: Inject services into ApiQueryWatchlistRaw/ApiQueryWatchlistmediawiki/coremaster+75 -20
api: Inject services into ApiQueryAllImagesmediawiki/coremaster+13 -4
api: Inject services into ApiQueryAllMessagesmediawiki/coremaster+55 -11
api: Inject services into ApiQueryRecentChangesmediawiki/coremaster+27 -8
api: Inject services into ApiQueryAllPagesmediawiki/coremaster+25 -6
api: Inject services into ApiQueryUserContribsmediawiki/coremaster+28 -8
api: Inject services into ApiQueryUsersmediawiki/coremaster+45 -14
api: Inject services into ApiQuerySiteinfomediawiki/coremaster+136 -65
api: Inject services into ApiQueryDeletedrevsmediawiki/coremaster+29 -9
api: Inject services into ApiQueryAllUsersmediawiki/coremaster+33 -5
api: Inject ChangeTagDefStore into ApiQueryLogEventsmediawiki/coremaster+10 -4
api: Inject services into ApiQueryAllLinksmediawiki/coremaster+50 -10
api: Inject services into ApiQueryQueryPagemediawiki/coremaster+13 -4
api: Inject services into ApiQueryAuthManagerInfomediawiki/coremaster+26 -10
api: Inject services into ApiQueryLangLinksmediawiki/coremaster+25 -8
api: Inject services into ApiQueryLinksmediawiki/coremaster+24 -6
api: Inject services into ApiQueryDuplicateFilesmediawiki/coremaster+20 -9
api: Inject services into ApiEditPagemediawiki/coremaster+42 -14
ApiParse: inject servicesmediawiki/coremaster+81 -29
api: Inject services into ApiOpenSearchmediawiki/coremaster+26 -4
api: Inject services into ApiDeletemediawiki/coremaster+24 -8
api: Inject services into ApiSetPageLanguagemediawiki/coremaster+36 -6
api: Inject services into ApiImageRotatemediawiki/coremaster+33 -7
api: Inject RepoGroup into ApiMovemediawiki/coremaster+9 -5
api: Inject services into ApiMergeHistorymediawiki/coremaster+25 -4
api: Inject services into ApiQueryPagePropsmediawiki/coremaster+30 -16
api: Inject services into ApiComparePagesmediawiki/coremaster+28 -8
ApiHelp: inject SkinFactorymediawiki/coremaster+24 -3
ApiFileRevert: inject RepoGroupmediawiki/coremaster+24 -4
ApiFeedWatchlist: inject servicesmediawiki/coremaster+24 -5
ApiFeedContributions: inject servicesmediawiki/coremaster+83 -13
ApiExpandTemplates: inject servicesmediawiki/coremaster+37 -10
ApiPatrol: inject RevisionStoremediawiki/coremaster+25 -5
Inject AuthManager into some api classesmediawiki/coremaster+171 -74
Inject CommentStore service into api query modulesmediawiki/coremaster+129 -38
Api: inject more abuse filter servicesmediawiki/extensions/AbuseFiltermaster+116 -22
ApiTag: inject servicesmediawiki/coremaster+34 -9
Api: inject AbuseFilterPermissionManager where neededmediawiki/extensions/AbuseFiltermaster+150 -27
Inject services into SpecialProvideSubmittedTextmediawiki/extensions/TwoColConflictmaster+28 -9
Inject services into SpecialTemplateSandboxmediawiki/extensions/TemplateSandboxmaster+39 -14
Inject services into SpecialCiteThisPagemediawiki/extensions/CiteThisPagemaster+41 -22
Inject services into SpecialFeedItemmediawiki/extensions/FeaturedFeedsmaster+19 -4
Inject services into SpecialCategoryTreemediawiki/extensions/CategoryTreemaster+17 -5
Inject services into DisambiguationPages/DisambiguationPageLinksmediawiki/extensions/Disambiguatormaster+58 -12
Inject the needed dependencies into ApiBlockmediawiki/coremaster+25 -3
Inject services into abstract ChangesListSpecialPagemediawiki/coremaster+182 -21
Prepare special page constructor for service injection in coremediawiki/extensions/MultiUploadmaster+3 -2
Inject SearchEngineFactory into special pagesmediawiki/coremaster+73 -17
Inject LanguageConverterFactory into special pagesmediawiki/coremaster+163 -28
Change object specs for remaining un-serviced special pagesmediawiki/coremaster+77 -27
Inject services into SpecialRecentChanges/SpecialRecentChangesLinkedmediawiki/coremaster+105 -23
Add release notes about service injection in special pagesmediawiki/coremaster+7 -0
Inject services into SpecialWatchlist/SpecialEditWatchlistmediawiki/coremaster+122 -55
Reapply "Inject services into SpecialUserrights"mediawiki/coremaster+51 -21
Inject services into SpecialContributions/SpecialDeletedContributionsmediawiki/coremaster+610 -158
Prepare special page constructor for service injection in coremediawiki/extensions/QuizGamemaster+7 -4
Prepare special page constructor for service injection in coremediawiki/extensions/GlobalPreferencesmaster+2 -2
Prepare special page constructor for service injection in coremediawiki/extensions/SocialProfilemaster+6 -1
Prepare special page constructor for service injection in coremediawiki/extensions/FanBoxesmaster+6 -1
Prepare special page constructor for service injection in coremediawiki/extensions/PictureGamemaster+6 -1
Prepare special page constructor for service injection in coremediawiki/extensions/PollNYmaster+6 -1
Prepare special page constructor for service injection in coremediawiki/extensions/GlobalContribsmaster+4 -2
Prepare special page constructor for service injection in coremediawiki/extensions/GlobalUserrightsmaster+2 -1
Prepare special page constructor for service injection in coremediawiki/extensions/CentralAuthmaster+2 -1
Inject services into SpecialUpload/SpecialUploadStashmediawiki/coremaster+58 -42
Revert "Inject services into SpecialUserrights"mediawiki/coremaster+20 -50
Inject services into SpecialPreferencesmediawiki/coremaster+48 -14
Inject services into SpecialUserrightsmediawiki/coremaster+51 -21
Use SpecialPageFactory to create special pages in testmediawiki/extensions/ORESmaster+7 -3
Inject SpecialPageFactory into SpecialPage and use itmediawiki/coremaster+35 -44
Inject services into SpecialSearchmediawiki/coremaster+111 -29
Inject AuthManager into SpecialPage and use itmediawiki/coremaster+110 -35
Inject services into SpecialAllMessagesmediawiki/coremaster+74 -15
Inject services into SpecialLogmediawiki/coremaster+100 -31
Inject services into SpecialRandom and friendsmediawiki/coremaster+88 -19
Inject UserCache into ApiUnblockmediawiki/coremaster+35 -41
Inject services into SpecialMovepagemediawiki/coremaster+90 -33
Inject LinkBatchFactory into QueryPage and use itmediawiki/coremaster+266 -35
Inject DBLoadBalancer into abstract QueryPage (part 2)mediawiki/coremaster+165 -33
Inject DBLoadBalancer into abstract QueryPagemediawiki/coremaster+151 -78
Inject ContentLanguage into SpecialPage and use itmediawiki/coremaster+56 -72
Inject services into SpecialAllPages/SpecialPrefixindexmediawiki/coremaster+58 -14
Inject services into ApiStashEditmediawiki/coremaster+61 -22
Inject services into ApiResetPasswordmediawiki/coremaster+27 -6
Inject services into ApiChangeContentModelmediawiki/coremaster+39 -11
Inject services into SpecialComparePagesmediawiki/coremaster+54 -17
Inject TalkPageNotificationManager into ApiClearHasMsgmediawiki/coremaster+26 -6
Inject services into SpecialProtectedtitlesmediawiki/coremaster+40 -12
Inject services into SpecialMyLanguagemediawiki/coremaster+35 -9
Inject services into SpecialProtectedpagesmediawiki/coremaster+107 -25
Inject DBLoadBalancer into SpecialUncategorizedCategoriesmediawiki/coremaster+20 -3
Inject services into SpecialExport/SpecialImportmediawiki/coremaster+43 -20
Inject Parser into SpecialVersionmediawiki/coremaster+16 -5
Inject dependencies into ApiSetNotificationTimestampmediawiki/coremaster+56 -12
Inject UserCache into SpecialListFiles/SpecialNewFilesmediawiki/coremaster+18 -4
Inject services into SpecialPageLanguagemediawiki/coremaster+53 -14
Inject services into SpecialUndeletemediawiki/coremaster+90 -39
Inject services into SpecialListGroupRightsmediawiki/coremaster+29 -10
Inject services into SpecialChangeContentModelmediawiki/coremaster+32 -18
Inject services into SpecialMergeHistorymediawiki/coremaster+71 -19
Inject services into SpecialNewpagesmediawiki/coremaster+132 -31
Inject LinkBatchFactory into SpecialListRedirectsmediawiki/coremaster+18 -6
Inject DBLoadBalancer into SpecialMIMESearchmediawiki/coremaster+23 -5
Inject LinkBatchFactory into SpecialTrackingCategoriesmediawiki/coremaster+17 -5
Inject services into SpecialExpandTemplatesmediawiki/coremaster+26 -12
Inject services into SpecialListUsers/SpecialActiveUsersmediawiki/coremaster+171 -44
Inject PasswordFactory into SpecialBotPasswordsmediawiki/coremaster+16 -7
Inject services into SpecialRunJobsmediawiki/coremaster+26 -7
Inject services into SpecialListFilesmediawiki/coremaster+162 -34
Inject DBLoadBalancer into SpecialPagesWithPropmediawiki/coremaster+19 -4
Inject services into SpecialFileDuplicateSearchmediawiki/coremaster+39 -14
Inject UserNamePrefixSearch into SpecialEmailUsermediawiki/coremaster+30 -5
Inject services into SpecialNewFilesmediawiki/coremaster+94 -29
Inject services into SpecialCategoriesmediawiki/coremaster+35 -12
Inject NamespaceInfo into SpecialStatisticsmediawiki/coremaster+15 -6
Inject UserFactory into SpecialEmailInvalidatemediawiki/coremaster+23 -3
Inject PermissionManager into SpecialTagsmediawiki/coremaster+20 -13
Inject SpecialPageFactory into SpecialSpecialpagesmediawiki/coremaster+16 -5
Inject UserFactory into SpecialConfirmEmailmediawiki/coremaster+14 -3
Inject services into ApiValidatePasswordmediawiki/coremaster+37 -6
Inject RepoGroup into SpecialWantedfilesmediawiki/coremaster+20 -5
Inject DBLoadBalancer into SpecialLinkSearchmediawiki/coremaster+17 -8
Inject DBLoadBalancer into SpecialWantedpagesmediawiki/coremaster+18 -4
Inject services into SpecialBrokenRedirects/SpecialDoubleRedirectsmediawiki/coremaster+87 -32
Inject services into SpecialMediaStatisticsmediawiki/coremaster+27 -6
Inject services into SpecialUnwatchedPagesmediawiki/coremaster+28 -7
Inject services into SpecialWithoutInterwikimediawiki/coremaster+27 -7
Inject service into SpecialUncategorizedPages/Categories/Templatesmediawiki/coremaster+45 -18
Inject NamespaceInfo service into SpecialDeadendPages/AncientPages/LonelyPagesmediawiki/coremaster+51 -27
Inject services into SpecialBookSourcesmediawiki/coremaster+34 -8
Inject NamespaceInfo service into SpecialMostCategories/SpecialMostInterwikismediawiki/coremaster+36 -12
Inject NamespaceInfo service into SpecialShortPages/SpecialLongPagesmediawiki/coremaster+34 -9
Inject ContentLanguage service into SpecialLockdbmediawiki/coremaster+13 -8
Inject AuthManager service into SpecialChangeEmailmediawiki/coremaster+10 -6
Inject services into SpecialWhatLinksHeremediawiki/coremaster+45 -12
Inject services into SpecialUnblockmediawiki/coremaster+49 -8
Inject services into SpecialBlockmediawiki/coremaster+114 -43
Change SpecialUnblock::processUIUnblock to closure and inject servicemediawiki/coremaster+29 -26
Inject services into SpecialBlockList/SpecialAutoblockListmediawiki/coremaster+220 -41
Inject service into SpecialFewestRevisions/SpecialMostRevisionsmediawiki/coremaster+25 -9
Inject PermissionManager service to all special pagesmediawiki/coremaster+1 K -544
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT259960 Inject services into API modules and special pages
 OpenNoneT265197 Make class SpecialUserRights a real special page and move all helper function to own service
 OpenNoneT265199 Move SpecialUpload::getInitialPageText to a upload related service for proper service injection
 OpenNoneT265200 Create service to handle ImageGalleryBase::factory with service injection
 OpenNoneT265201 Make SpecialVersion a real special page and move all helper function to own service
 OpenNoneT265300 Stop extending core's SpecialUpload
 ResolvedmatmarexT265301 GlobalUsage should not extend core's SpecialWantedfiles
 ResolvedmatmarexT265307 Update extensions that extend core SpecialMostimages class
 ResolvedNoneT265308 Update extensions that extend core SpecialRandompage class
 OpenNoneT265309 Fix extensions that extend core SpecialAllPages class
 OpenNoneT265310 Stop extending core's SpecialRecentChanges
 ResolvedNoneT221722 ApiQueryBlocks should not be aware of the container
 ResolveddmazaT219684 BlockRestriction should be a service instead of a singleton
 ResolvedMainframe98T222388 Create a mechanism for SpecialPages and API modules to have dependencies injected into them
 ResolvedZabeT253077 Convert MWGrants to a service with dependency injection
 ResolvedDannyS712T253061 Convert UserCache to a service with dependency injection
 ResolvedcscottT247194 Convert TrackingCategories to a service with DI
 ResolvedKrinkleT265398 Use DI for Profiler class instance in MediaWiki core code
OpenNoneT265400 Research to create service for SessionManager::singleton()/getGlobalSession()
 OpenNoneT265403 Research to create service for HTMLForm::factory and html fields
 OpenDaimonaT265541 Make class SpecialEmailUser a real special page and move all helper functions to their own service
 ResolvedLadsgroupT245964 Split up and servicify ChangeTags class
 OpenNoneT253184 Convert SiteStats to a service with dependency injection
 ResolvedDAlangi_WMFT265749 Research to create service for DeferredUpdates::addUpdate()
 OpenNoneT265769 Research to create service for BotPassword class
 Resolved• PcheloloT265767 Research to create service for CentralIdLookup::factory
 OpenNoneT265818 Make class SpecialPageLanguage a real special page and move helper function to own service
 OpenNoneT265819 Research to create service for PageDataRequestHandler
 OpenNoneT265825 Research to create service for RevisionDeleter
 DuplicateNoneT265827 Research to create service for PageArchive
 OpenNoneT265924 Stop extending core's SpecialPreferences
 OpenNoneT265942 Research to create service for DoubleRedirectJob::fixRedirects
 ResolvedVlad.shapikT265944 Make class WatchAction a real action class and move helper function to own service
 ResolvedCCicalese_WMFT280750 Hard deprecate watchlist methods in WatchAction
 ResolvedVlad.shapikT285399 extensions/LiquidThreads: avoid using WatchAction::getWatchToken
 ResolvedNikerabbitT265945 Stop extending core's SpecialMovePage
 StalledNoneT266065 Stop extending core's SpecialEditWatchlist
 ResolvedJdlrobsonT299589 Change markup of Watchlist top tabs to support skinning
 OpenBUG REPORTNoneT299799 Use JavaScript for updating the items on SpecialEditWatchlist
 OpenNoneT363032 Mobile should separate out Saved reading list and editor Watchlist experiences.
 OpenNoneT266168 Research to create service for ImportStreamSource class
 ResolvedFuncT266480 Extension should not create LogPager, use LogEventsList::showLogExtract or custom select query instead
 OpenNoneT266484 Turn ContribsPager into an internal-only class (discontinue support to use in extensions)
 OpenNoneT266978 Research how to inject PermissionManager into abstract SpecialPage
 OpenNoneT266979 Research how to inject LinkRendererFactory into abstract SpecialPage
 DeclinedNoneT269521 Stop extending core's SpecialContributions
 OpenNoneT264213 ApiThreadAction extends ApiEditPage
 ResolvedZabeT285797 Stop extending core's ApiUserrights
 DeclinedNoneT285798 Stop extending core's ApiOptions
 OpenNoneT286050 Stop extending core's ApiQueryImageInfo
 ResolvedUmherirrenderT286079 Research to create service for Collation class
 OpenNoneT286154 Research what to do with static ApiOpenSearch::getOpenSearchTemplate (dependency injection)
 OpenNoneT286155 Research what to do with static ApiHelp::getHelp (service injection)
 OpenNoneT283314 Convert ApiPageSet to a service rather than a subclass of ApiBase
 OpenNoneT286156 How to use service injection in context of static function from ApiResult class?
 OpenNoneT286264 Research what to do with static ApiQueryUserInfo::getCentralUserInfo (service injection)
 OpenNoneT311758 Inject ReadOnlyMode service into SpecialPage base class

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jul 2 2021, 2:13 PM

Change 702945 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryDuplicateFiles

https://gerrit.wikimedia.org/r/702945

gerritbot added a comment.Jul 2 2021, 2:27 PM

Change 702971 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryLangLinks

https://gerrit.wikimedia.org/r/702971

gerritbot added a comment.Jul 2 2021, 2:35 PM

Change 702974 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryLinks class

https://gerrit.wikimedia.org/r/702974

gerritbot added a comment.Jul 2 2021, 3:46 PM

Change 702945 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryDuplicateFiles

https://gerrit.wikimedia.org/r/702945

gerritbot added a comment.Jul 2 2021, 3:47 PM

Change 702974 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryLinks

https://gerrit.wikimedia.org/r/702974

gerritbot added a comment.Jul 2 2021, 6:10 PM

Change 702998 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryContributors

https://gerrit.wikimedia.org/r/702998

gerritbot added a comment.Jul 2 2021, 6:25 PM

Change 702971 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryLangLinks

https://gerrit.wikimedia.org/r/702971

gerritbot added a comment.Jul 2 2021, 6:41 PM

Change 702999 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryImageInfo/ApiQueryStashImageInfo

https://gerrit.wikimedia.org/r/702999

gerritbot added a comment.Jul 2 2021, 6:55 PM

Change 702998 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryContributors

https://gerrit.wikimedia.org/r/702998

Umherirrender added a subtask: T286079: Research to create service for Collation class.Jul 2 2021, 7:20 PM
gerritbot added a comment.Jul 2 2021, 7:55 PM

Change 703001 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryFileRepoInfo

https://gerrit.wikimedia.org/r/703001

gerritbot added a comment.Jul 2 2021, 8:02 PM

Change 703002 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryAuthManagerInfo

https://gerrit.wikimedia.org/r/703002

gerritbot added a comment.Jul 2 2021, 8:54 PM

Change 703006 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryAllLinks

https://gerrit.wikimedia.org/r/703006

gerritbot added a comment.Jul 2 2021, 9:05 PM

Change 703007 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject ChangeTagDefStore into ApiQueryLogEvents

https://gerrit.wikimedia.org/r/703007

gerritbot added a comment.Jul 2 2021, 9:05 PM

Change 703002 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryAuthManagerInfo

https://gerrit.wikimedia.org/r/703002

gerritbot added a comment.Jul 2 2021, 9:11 PM

Change 703009 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryQueryPage

https://gerrit.wikimedia.org/r/703009

gerritbot added a comment.Jul 3 2021, 3:08 AM

Change 703009 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryQueryPage

https://gerrit.wikimedia.org/r/703009

gerritbot added a comment.Jul 3 2021, 3:13 AM

Change 703007 merged by jenkins-bot:

[mediawiki/core@master] api: Inject ChangeTagDefStore into ApiQueryLogEvents

https://gerrit.wikimedia.org/r/703007

gerritbot added a comment.Jul 3 2021, 3:14 AM

Change 703006 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryAllLinks

https://gerrit.wikimedia.org/r/703006

gerritbot added a comment.Jul 3 2021, 6:12 PM

Change 703035 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryFileRepoInfo

https://gerrit.wikimedia.org/r/703035

gerritbot added a comment.Jul 3 2021, 6:21 PM

Change 703036 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryAllPages

https://gerrit.wikimedia.org/r/703036

gerritbot added a comment.Jul 3 2021, 6:36 PM

Change 703041 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryDeletedRevisions

https://gerrit.wikimedia.org/r/703041

gerritbot added a comment.Jul 3 2021, 6:50 PM

Change 703044 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryRecentChanges

https://gerrit.wikimedia.org/r/703044

gerritbot added a comment.Jul 3 2021, 7:11 PM

Change 703045 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQuerySearch class/SearchApi trait

https://gerrit.wikimedia.org/r/703045

gerritbot added a comment.Jul 3 2021, 7:45 PM

Change 703047 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryAllMessages

https://gerrit.wikimedia.org/r/703047

gerritbot added a comment.Jul 3 2021, 7:59 PM

Change 703049 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryWatchlistRaw/ApiQueryWatchlist

https://gerrit.wikimedia.org/r/703049

gerritbot added a comment.Jul 3 2021, 8:25 PM

Change 703050 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQuerySiteinfo

https://gerrit.wikimedia.org/r/703050

gerritbot added a comment.Jul 3 2021, 8:48 PM

Change 703051 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryAllUsers

https://gerrit.wikimedia.org/r/703051

gerritbot added a comment.Jul 3 2021, 9:57 PM

Change 703054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryUsers

https://gerrit.wikimedia.org/r/703054

Umherirrender closed subtask T265767: Research to create service for CentralIdLookup::factory as Resolved.Jul 3 2021, 10:10 PM
gerritbot added a comment.Jul 3 2021, 10:19 PM

Change 703055 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryUserContribs

https://gerrit.wikimedia.org/r/703055

gerritbot added a comment.Jul 3 2021, 10:30 PM

Change 703056 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiQueryDeletedrevs

https://gerrit.wikimedia.org/r/703056

gerritbot added a comment.Jul 3 2021, 11:14 PM

Change 703051 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryAllUsers

https://gerrit.wikimedia.org/r/703051

gerritbot added a comment.Jul 3 2021, 11:16 PM

Change 703050 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQuerySiteinfo

https://gerrit.wikimedia.org/r/703050

gerritbot added a comment.Jul 3 2021, 11:16 PM

Change 703056 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryDeletedrevs

https://gerrit.wikimedia.org/r/703056

gerritbot added a comment.Jul 3 2021, 11:16 PM

Change 703055 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryUserContribs

https://gerrit.wikimedia.org/r/703055

gerritbot added a comment.Jul 3 2021, 11:19 PM

Change 703054 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryUsers

https://gerrit.wikimedia.org/r/703054

gerritbot added a comment.Jul 3 2021, 11:19 PM

Change 703044 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryRecentChanges

https://gerrit.wikimedia.org/r/703044

gerritbot added a comment.Jul 3 2021, 11:22 PM

Change 703036 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryAllPages

https://gerrit.wikimedia.org/r/703036

gerritbot added a comment.Jul 3 2021, 11:22 PM

Change 703035 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryAllImages

https://gerrit.wikimedia.org/r/703035

gerritbot added a comment.Jul 3 2021, 11:22 PM

Change 703047 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryAllMessages

https://gerrit.wikimedia.org/r/703047

gerritbot added a comment.Jul 3 2021, 11:23 PM

Change 703049 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryWatchlistRaw/ApiQueryWatchlist

https://gerrit.wikimedia.org/r/703049

gerritbot added a comment.Jul 3 2021, 11:48 PM

Change 703057 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Change object specs for remaining un-serviced api modules

https://gerrit.wikimedia.org/r/703057

gerritbot added a comment.Jul 4 2021, 12:47 PM

Change 703063 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Inject services into ApiWatchlistTrait

https://gerrit.wikimedia.org/r/703063

Umherirrender added a subtask: T286154: Research what to do with static ApiOpenSearch::getOpenSearchTemplate (dependency injection).Jul 4 2021, 12:56 PM
Umherirrender added a subtask: T286155: Research what to do with static ApiHelp::getHelp (service injection).Jul 4 2021, 1:48 PM
Umherirrender added a subtask: T283314: Convert ApiPageSet to a service rather than a subclass of ApiBase.
Umherirrender added a subtask: T286156: How to use service injection in context of static function from ApiResult class?.Jul 4 2021, 1:54 PM
gerritbot added a comment.Jul 4 2021, 11:41 PM

Change 702999 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryImageInfo/ApiQueryStashImageInfo

https://gerrit.wikimedia.org/r/702999

gerritbot added a comment.Jul 4 2021, 11:49 PM

Change 703045 merged by jenkins-bot:

[mediawiki/core@master] api: Use injected services in ApiQuerySearch

https://gerrit.wikimedia.org/r/703045

gerritbot added a comment.Jul 5 2021, 10:01 AM

Change 702932 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiUpload class

https://gerrit.wikimedia.org/r/702932

gerritbot added a comment.Jul 5 2021, 5:13 PM

Change 703001 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQueryFileRepoInfo

https://gerrit.wikimedia.org/r/703001

gerritbot added a comment.Jul 6 2021, 7:53 PM

Change 703041 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQuery(All)(Deleted)Revisions

https://gerrit.wikimedia.org/r/703041

gerritbot added a comment.Jul 6 2021, 8:53 PM

Change 703063 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiWatchlistTrait

https://gerrit.wikimedia.org/r/703063

Umherirrender added a subtask: T286264: Research what to do with static ApiQueryUserInfo::getCentralUserInfo (service injection).Jul 6 2021, 9:08 PM
• Pchelolo closed subtask T265944: Make class WatchAction a real action class and move helper function to own service as Resolved.Jul 13 2021, 3:17 PM
gerritbot added a comment.Sep 3 2021, 11:54 PM

Change 703057 merged by jenkins-bot:

[mediawiki/core@master] API: Change object specs for remaining un-serviced API modules

https://gerrit.wikimedia.org/r/703057

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Sep 4 2021, 12:00 AM
Umherirrender closed subtask T286079: Research to create service for Collation class as Resolved.Sep 4 2021, 1:36 AM
Zabe closed subtask T221722: ApiQueryBlocks should not be aware of the container as Resolved.Sep 21 2021, 2:43 PM
Nikerabbit changed the status of subtask T265945: Stop extending core's SpecialMovePage from Open to In Progress.Sep 28 2021, 7:34 AM
abi_ closed subtask T265945: Stop extending core's SpecialMovePage as Resolved.Oct 1 2021, 11:35 AM
gerritbot added a comment.Oct 1 2021, 1:25 PM

Change 725313 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] SpecialMovePage: stop faling back to global state

https://gerrit.wikimedia.org/r/725313

Mainframe98 merged a task: T232506: Inject services into special pages.Oct 1 2021, 3:57 PM
Mainframe98 subscribed.
Mainframe98 unsubscribed.
Mainframe98 mentioned this in T235115: Split special page alias resolution from SpecialPageFactory into a separate service.Oct 1 2021, 4:01 PM
gerritbot added a comment.Oct 1 2021, 4:53 PM

Change 725313 merged by jenkins-bot:

[mediawiki/core@master] SpecialMovePage: stop falling back to global state

https://gerrit.wikimedia.org/r/725313

matej_suchanek closed subtask T247194: Convert TrackingCategories to a service with DI as Resolved.Oct 16 2021, 8:27 AM
gerritbot added a comment.Oct 19 2021, 8:16 PM

Change 702464 merged by jenkins-bot:

[mediawiki/core@master] api: Inject services into ApiQuery class

https://gerrit.wikimedia.org/r/702464

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 19 2021, 9:00 PM
Daimona closed subtask T285797: Stop extending core's ApiUserrights as Resolved.Feb 13 2022, 2:23 PM
gerritbot added a comment.Feb 13 2022, 2:28 PM

Change 762109 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Simplify ApiUserrights now that CentralAuth no longer extends it

https://gerrit.wikimedia.org/r/762109

gerritbot added a comment.Feb 18 2022, 2:46 PM

Change 762109 merged by jenkins-bot:

[mediawiki/core@master] Simplify ApiUserrights now that CentralAuth no longer extends it

https://gerrit.wikimedia.org/r/762109

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.23; 2022-02-21); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Feb 18 2022, 3:00 PM
Umherirrender removed a project: Patch-For-Review.Apr 11 2022, 8:10 PM
Zabe removed a project: User-Zabe.Apr 13 2022, 1:23 AM
Umherirrender added a subtask: T311758: Inject ReadOnlyMode service into SpecialPage base class.Jun 30 2022, 5:30 PM
Zabe closed subtask T253077: Convert MWGrants to a service with dependency injection as Resolved.Sep 16 2022, 10:10 PM
matmarex closed subtask T265301: GlobalUsage should not extend core's SpecialWantedfiles as Resolved.Nov 16 2022, 7:15 PM
matmarex closed subtask T265307: Update extensions that extend core SpecialMostimages class as Resolved.
gerritbot added a comment.Nov 16 2022, 7:23 PM

Change 857752 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Simplify special pages now that GlobalUsage no longer extends them

https://gerrit.wikimedia.org/r/857752

gerritbot added a project: Patch-For-Review.Nov 16 2022, 7:23 PM
gerritbot added a comment.Nov 22 2022, 8:41 PM

Change 857752 merged by jenkins-bot:

[mediawiki/core@master] Simplify special pages now that GlobalUsage no longer extends them

https://gerrit.wikimedia.org/r/857752

Tgr closed subtask T266484: Turn ContribsPager into an internal-only class (discontinue support to use in extensions) as Resolved.Dec 22 2022, 3:54 AM
Umherirrender reopened subtask T266484: Turn ContribsPager into an internal-only class (discontinue support to use in extensions) as Open.Dec 22 2022, 4:26 PM
Ladsgroup closed subtask T245964: Split up and servicify ChangeTags class as Resolved.Jun 22 2023, 1:04 PM
Yaron_Koren closed subtask T266480: Extension should not create LogPager, use LogEventsList::showLogExtract or custom select query instead as Resolved.Jun 26 2023, 4:38 PM
Func reopened subtask T266480: Extension should not create LogPager, use LogEventsList::showLogExtract or custom select query instead as Open.Jun 26 2023, 4:41 PM
Daimona closed subtask T265749: Research to create service for DeferredUpdates::addUpdate() as Resolved.Jul 16 2023, 12:31 PM
Krinkle reopened subtask T265749: Research to create service for DeferredUpdates::addUpdate() as Open.Jul 20 2023, 2:24 AM
Krinkle closed subtask T265398: Use DI for Profiler class instance in MediaWiki core code as Resolved.Aug 7 2023, 1:54 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 7 2023, 2:10 AM
DAlangi_WMF closed subtask T265749: Research to create service for DeferredUpdates::addUpdate() as Resolved.Sep 11 2023, 1:49 PM
matmarex closed subtask T265308: Update extensions that extend core SpecialRandompage class as Resolved.Feb 20 2024, 4:55 PM
tstarling closed subtask T285798: Stop extending core's ApiOptions as Declined.Apr 2 2024, 10:05 PM
Jdlrobson changed the status of subtask T266065: Stop extending core's SpecialEditWatchlist from Open to Stalled.Apr 19 2024, 11:46 PM
Func closed subtask T266480: Extension should not create LogPager, use LogEventsList::showLogExtract or custom select query instead as Resolved.May 11 2024, 6:57 AM
Pppery closed subtask T269521: Stop extending core's SpecialContributions as Declined.Aug 18 2024, 5:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits