Not able to save a string longer than 400 characters
Closed, ResolvedPublic
Actions

Description

Problem:
Properties of datatype string have a configurable length limit. On Wikidata this is set to 1500 characters. Recently it no longer seems possible to enter values longer than 400 characters for Properties with datatype string. This change was not intended. We need to fix this and use the configured length limit again.

Pointers:

History...
- Ticket making the limit configurable: T198108
- Original report: https://www.wikidata.org/wiki/Wikidata:Project_chat#Quotation_field
Docs...
- Config setting: https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_options.html#autotoc_md298
Probable reproduction...
- Creating a monolingual text property, setting the setting to longer than 400, trying to add a statement of a length greater than 400

Acceptance criteria:

string values use the proper configured length limit

Details

	Subject	Repo	Branch	Lines +/-
	Reverse WB settings merge order for 2D arrays	mediawiki/extensions/Wikibase	master	+9 -3

Customize query in gerrit

Related Objects

Mentioned Here: T257447: Don’t load Repo settings in PHP entry point
T154660: Increase length limit for external identifier, string and URL datatype
T198108: Modify character limit for "string" and "monolingual text" on wikibase instances (not Wikidata).

Event Timeline

Bugreporter created this task.Aug 2 2020, 6:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2020, 6:43 PM

When was this set to 700? (can anyone find any record)?
I had a look at the patches in the linked ticket and nothing seems to have removed a 700 limit.
I also had a look in the current config and also on phab and dont see anything on either https://phabricator.wikimedia.org/search/query/0hMTYTuS7gwI/#R

T198108 looks like it was to add an option to change the limit. T154660 was to increase a limit (possibly this one) to 1500 but whatever was changed there doesn't seem to have been reverted. Is there something else that restricts it to 400?

Not sure when this was changed but https://www.wikidata.org/w/index.php?title=Q96884047&diff=1223503993&oldid=1223461969 (3 July) would now be too long. That's the most recently created item with "quotation or excerpt" but there may have been additions to existing items since then or long strings in other properties.

Message is:
"Could not save due to an error.

Must be no more than 400 characters long"

A more recent edit with more than 400 characters is https://www.wikidata.org/w/index.php?title=Q78161758&diff=1234767783&oldid=1234767538 (19 July).

Yeah this shouldn't have changed. We need to investigate.

Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.Aug 3 2020, 9:11 AM

In T259440#6354417, @Addshore wrote:

When was this set to 700? (can anyone find any record)?

Note the limit is not 700, but 1500. See https://codesearch.wmcloud.org/search/?q=VT%3Amonolingualtext&i=nope&files=&repos=

Lydia_Pintscher updated the task description. (Show Details)Aug 3 2020, 5:11 PM

Addshore moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Aug 4 2020, 12:13 PM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Aug 4 2020, 12:15 PM

ItamarWMDE claimed this task.Aug 7 2020, 11:05 AM

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Addshore updated the task description. (Show Details)Aug 7 2020, 11:29 AM

Appears to be related to changes made in T257447

The order override in some settings were broken and the default would override the set value. The two settings that were broken by this bug are string-limits and pagePropertiesRdf. Patch is coming.

Shall we backport it in Friday? @Lydia_Pintscher

Change 618981 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Reverse WB settings merge order for 2D arrays

https://gerrit.wikimedia.org/r/618981

gerritbot added a project: Patch-For-Review.Aug 7 2020, 1:34 PM

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 7 2020, 1:38 PM

Change 618981 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reverse WB settings merge order for 2D arrays

https://gerrit.wikimedia.org/r/618981

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2020, 3:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 7 2020, 4:00 PM

ItamarWMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 10 2020, 8:53 AM