Page MenuHomePhabricator

wikibase.client.init should define targets
Closed, DeclinedPublic

Description

wikibase.client.init currently does not define a targets (T235712). As a result it is silently removed from pages where it does not apply causing warnings. It must define these. If the code is not intended for mobile this should be handled in the logic that adds the module to the page.

Despite this, it doesn't load on desktop Minerva, so it seems like this logic is working:

Note that when run in mobile, non-mobile targeted modules will have a state of undefined)

I think all that Wikibase therefore needs to do is define targets (and verify the code loads or doesn't load in Minerva and mobile as before)

Event Timeline

Michael subscribed.

As I understand it, with the removal of the targets system, this is now mainly obsolete. The question what functionality we want on mobile seems to be the main topic of T326428: Make more Wikibase ResourceLoader modules available on mobile as well.